From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90D3F1F151C for ; Wed, 22 Apr 2026 06:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776838752; cv=none; b=Bk0g5SqY93V/NOUfn7eUg3CRo9YlIUEWAlyDf6IcRywER9z5eDtW4O7EOFbbFql5X7uf+SChzuvHIt/4mB/d6wwhWM2dk8TiHGdyFgRJIE/QBQZX9JKxnG0q8Ust/pLsC9rJ9wymFWeu3Y+NDByggWAFwmaYh9XBFIa199VzXI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776838752; c=relaxed/simple; bh=GhLCn87lDg0zVWE5r8YDpyCLm1zvULHLCWK8oqFTnb0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q+vQy520y8s2CLyz2dlhP4W59/Om4xrvvuIP6dxcqukqzXJiZkrMH14bCUaC+NoLlPuqTYUOgbVN0pKIu3LMoM0ClxzaZz+xEPfvQDyk/qdfSgxA3OrRBhMXXR3NRawxQD9qYHNMtwFTxbJKQyCXAkX1lEq6TMX2hGXSfdBqJwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W9yUAedo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GVSmpaCJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W9yUAedo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GVSmpaCJ" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M5BwcT3083122 for ; Wed, 22 Apr 2026 06:19:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NmV+ExxZZmmRYLRISOrru0LTP1LO55qj5WfaayyYBTM=; b=W9yUAedoabsC3bk6 gbUygCcbqobtVjb7siSk7sFG0SisKopS0MwHeZnbi3Zcihwl2/OTt+/kYS18l/WE VF1QWwNA+CvcaXcJ+GzKHZ9KHyyZ4p4iBM1J9RFLNBXzBSfjMk9pNwyl5zv1iSAu vpqNH6BHyctX7zM5OZqAZw5PB6M3pu6UW83jELWOwFQPE72F91jsrzLGBzNqUc8s v0ifP1t9CV4fTrK7RyPnDPHSPA7YbyBqZVXv1Fs9JlLbcph7040B8LczNIXG1YAX 6P4AnXZN6FZMMDeDGxKQQOM+yiUwA37UAT1CGjZSo/Hqy6GRJPmXWHSg0b8WnqUF uqunDw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenmj0en-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 06:19:09 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-82f6a5b4f88so6935793b3a.2 for ; Tue, 21 Apr 2026 23:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776838749; x=1777443549; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NmV+ExxZZmmRYLRISOrru0LTP1LO55qj5WfaayyYBTM=; b=GVSmpaCJD85GhjDukyKnUJIeLOkmHpg6OHnnlKWk2wTzdAt4HYE9Lx8APKj5VDk5jA WTPYYm/zc5jEQ8MEfNXd2YaT/JBM+AerTOHeRRhg45QDoEg/LOcaPbvQkiPcJiJ8Vlp1 T3g9VmT1qBKqUzI45CuHm1HhYULTs9tvc+sqQ21X+wWiOGohpEB4pOLuwAq4m3BQgcFU 9Fp9IsshjzAVaf30+YaL2nzRuE6Esrvwim3wsb9zN1ThR4Vxx526/1HSCbh31Zt19BAE BbhCqjXH8v8nEqQmzMiYjwQbuY+W64tl2PPiYxGBcpUhaA6kBcYdKQ7G4fvLEZMICw9R lMZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776838749; x=1777443549; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NmV+ExxZZmmRYLRISOrru0LTP1LO55qj5WfaayyYBTM=; b=J96dr2FVhS4QDSEDxTAwVcxEEHPSgSMvdqlbO8cgc3T2bkBTKAWbuRaGUsEdb16XEp +J4LjSRNF2pXfrnYIjQVjveSAWZwAHwQLVLtnKZ5htX4Z5M+ANNA4Rh/HDSZ3CclGgmY AgCkHR+/5iYrxOUvL9GjMyICnbYadWcOoMifBTYqdVdOSYBNvuxUlRTIzgzU+4NYPS88 Vn7mwYLe9r/GcGFyjwLK6v94CBtWjGr0lwzhqRkgAtJsJfeVzICYozJQFqh+uNMNlNE6 5jV4quaVzuly6j5ocDBj0Jn0A5GfIWQwK12nsrgHYe+azTpBY1KulsNp1YOitqSXnn7N i4Cw== X-Forwarded-Encrypted: i=1; AFNElJ8F6gEdpUFTP38laVD1Jfk/UedpKIp2GQlINEipvHbsIeyjjYiSAVjvbSBsb8EMOfexJdA5+nElAkN8@vger.kernel.org X-Gm-Message-State: AOJu0YxjXaXgrMaoVk3T1ES9hea9/ybaxSKJ4uc8CS4AFTYjHBvxwekD 1S3CQXYDC5q0Ds6U8FBWDQPBtBB5NAcGcCpNCnNmgcWNiMYr8PDBeC48rBT3tq54YwY2fiTrBwF sLy3HymYQtQAhJZoELUCBOdbfyI7UVcNnKqGMscaRamaDMI/AOB49OBtmXA7ouvmf X-Gm-Gg: AeBDieuV5jIMUOuAr3EsAQUMjvHXQgrbh7+bdRWopA2d4+E3jlli4qXlZVEQGC/WWrd uNov4Q4Fns8Oq/rKxjRZOTaM69EaFr9xPIeOGFZQ4E4RKSB2Fkfhy7Z4sUFF+owrZudFrtGhHd8 Q6HUmbXApmUet1U6zuFYQQ5GDDuSFleFIKHa9rdIG5YHVjbBAgupBTfUgHEYmtgPxr/4lyI8wIx r7YM4L48eC3har/g/zA40uANA6RPeCz1u/eVHymya3JkESyT5Ya3cB5pG8WWFsva8LBU59oquCs K56vWfTzyX3OvYQI+zbnBWhZmSwk+9c21lRbzbeMLgv/Na/kcJeLqxkaLDQ4XLElF7CCEG6fV/e +jw3Ja0EzcxkSjZvG+ZiXIRBmGKa9+zTw9k+YGxIo6sCW2KeeEBG5hhJiyxsNkkgA X-Received: by 2002:a05:6a00:8715:b0:82f:a89e:e16f with SMTP id d2e1a72fcca58-82fa89ee99fmr9654274b3a.14.1776838749047; Tue, 21 Apr 2026 23:19:09 -0700 (PDT) X-Received: by 2002:a05:6a00:8715:b0:82f:a89e:e16f with SMTP id d2e1a72fcca58-82fa89ee99fmr9654234b3a.14.1776838748498; Tue, 21 Apr 2026 23:19:08 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebbcfd7sm19942638b3a.32.2026.04.21.23.19.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2026 23:19:07 -0700 (PDT) Message-ID: <9c76be4a-e907-b5b6-e50f-0f37738752da@oss.qualcomm.com> Date: Wed, 22 Apr 2026 11:49:00 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 04/11] media: iris: Add helper to create a context bank device on iris vpu bus To: Dmitry Baryshkov Cc: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joerg Roedel , Will Deacon , Robin Murphy , Bjorn Andersson , Konrad Dybcio , Stefan Schmidt , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev References: <20260414-glymur-v1-0-7d3d1cf57b16@oss.qualcomm.com> <20260414-glymur-v1-4-7d3d1cf57b16@oss.qualcomm.com> Content-Language: en-US From: Vishnu Reddy In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: Tft39YioeWzuHNtn_T8JrtwWjjBhkyVU X-Proofpoint-ORIG-GUID: Tft39YioeWzuHNtn_T8JrtwWjjBhkyVU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDA1NyBTYWx0ZWRfX7oL/oqdE51al 6r6QouEqDbhkEnnLzeuU6g5Pwy3EeLx6jdwMGjUV6c/mPHvcIStmabbblWZ4o0pXOyYmBdyG+Hf ghBIRe9sTS1T0zghsNJ1ivohRZePBlxpwfF9ntidVWKIhfyGzDQB06oAzfY4Kp86/PqHmpHnSAB 9hu9f6LCUibssCQTSDdWx31F0+WxpTjUIErOr5x0pzT7VpwJht43emOro7cg93Jpxp1ulTtK+l9 62S0dzWh0WYJW+gnqusInLEkYoJQKvsRqGWS/3tuKk24LtBTJii9bdQVD1KH/Qh8grHJayh/FgR X2qYiJpbhk/BCivpgPwseRgalwCG4WNburzEaVElGf5oCZy71xqYQwFDTswBQJvd3+epxqI8bUZ tmz+382uT74RDztUCp1QDBe31ZJhBdbnaD6+EB+kpAwjzXt0gB6ZnOuFMJZUYUBcYa5Ea67cSDp MSF5R6jyNEXfT1MF++w== X-Authority-Analysis: v=2.4 cv=Xd65Co55 c=1 sm=1 tr=0 ts=69e8685d cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=S1jlUsJdER8BTHAalKsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-21_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 phishscore=0 bulkscore=0 malwarescore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220057 On 4/20/2026 11:26 PM, Dmitry Baryshkov wrote: > On Mon, Apr 20, 2026 at 07:33:01PM +0530, Vishnu Reddy wrote: >> On 4/17/2026 11:53 PM, Dmitry Baryshkov wrote: >>> On Fri, Apr 17, 2026 at 08:49:44PM +0530, Vishnu Reddy wrote: >>>> On 4/14/2026 8:48 PM, Dmitry Baryshkov wrote: >>>>> On Tue, Apr 14, 2026 at 10:30:00AM +0530, Vishnu Reddy wrote: >>>>>> From: Vikash Garodia >>>>>> >>>>>> Add a helper function to allocate and register context bank (CB) device >>>>>> on the iris vpu bus. The function ID associated with the CB is specified >>>>>> from the platform data, allowing the bus dma_configure callback to apply >>>>>> correct stream ID mapping when device is registered. >>>>>> >>>>>> Signed-off-by: Vikash Garodia >>>>>> Signed-off-by: Vishnu Reddy >>>>>> --- >>>>>> drivers/media/platform/qcom/iris/iris_resources.c | 33 +++++++++++++++++++++++ >>>>>> drivers/media/platform/qcom/iris/iris_resources.h | 1 + >>>>>> 2 files changed, 34 insertions(+) >>>>>> >>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c >>>>>> index 773f6548370a..a25e0f2e9d26 100644 >>>>>> --- a/drivers/media/platform/qcom/iris/iris_resources.c >>>>>> +++ b/drivers/media/platform/qcom/iris/iris_resources.c >>>>>> @@ -6,6 +6,7 @@ >>>>>> #include >>>>>> #include >>>>>> #include >>>>>> +#include >>>>>> #include >>>>>> #include >>>>>> #include >>>>>> @@ -141,3 +142,35 @@ int iris_disable_unprepare_clock(struct iris_core *core, enum platform_clk_type >>>>>> return 0; >>>>>> } >>>>>> + >>>>>> +static void iris_release_cb_dev(struct device *dev) >>>>>> +{ >>>>>> + kfree(dev); >>>>>> +} >>>>>> + >>>>>> +struct device *iris_create_cb_dev(struct iris_core *core, const char *name, const u32 *f_id) >>>>> Please move into the bus code and make it generic enough. >>>> Do you suggest to add a wrapper to pass the varying inputs to the generic >>>> bus, something like this >>>> struct device* create_and_register_device(dma_mask, parent_dev, *release, >>>> dev_name,...) >>> Definitely not the release function. The devname is also not that >>> important. The rest, yes, you are correct. >>> >>>>>> +{ >>>>>> + struct device *dev; >>>>>> + int ret; >>>>>> + >>>>>> + dev = kzalloc_obj(*dev); >>>>>> + if (!dev) >>>>>> + return ERR_PTR(-ENOMEM); >>>>>> + >>>>>> + dev->release = iris_release_cb_dev; >>>>>> + dev->bus = &iris_vpu_bus_type; >>>>>> + dev->parent = core->dev; >>>>>> + dev->coherent_dma_mask = core->iris_platform_data->dma_mask; >>>>>> + dev->dma_mask = &dev->coherent_dma_mask; >>>>> Would you also need to set the of_node? See >>>>> device_set_of_node_from_dev() >>>> It might be needed for FastRPC as they are following sub node approach, Iris >>>> does not need. >>> Wouldn't it save you from passing it to of_dma_configure_id()? >> Iris will pass parent device of_node, setting parent device is enough. > Set the of node and pass NULL to of_dma_configure_id. Passing of_node as NULL to of_dma_configure_id() won’t map the SID to device, If a dt sub node exists with iommus, the child’s of_node can be used. Otherwise, the parent’s of_node must be passed with a valid function ID present in iommu-map. >>>>>> + >>>>>> + dev_set_name(dev, "%s", name); >>>>>> + dev_set_drvdata(dev, (void *)f_id); >>>>>> + >>>>>> + ret = device_register(dev); >>>>>> + if (ret) { >>>>>> + put_device(dev); >>>>>> + return ERR_PTR(ret); >>>>>> + } >>>>>> + >>>>>> + return dev; >>>>>> +} >>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_resources.h b/drivers/media/platform/qcom/iris/iris_resources.h >>>>>> index 6bfbd2dc6db0..4a494627ff23 100644 >>>>>> --- a/drivers/media/platform/qcom/iris/iris_resources.h >>>>>> +++ b/drivers/media/platform/qcom/iris/iris_resources.h >>>>>> @@ -15,5 +15,6 @@ int iris_unset_icc_bw(struct iris_core *core); >>>>>> int iris_set_icc_bw(struct iris_core *core, unsigned long icc_bw); >>>>>> int iris_disable_unprepare_clock(struct iris_core *core, enum platform_clk_type clk_type); >>>>>> int iris_prepare_enable_clock(struct iris_core *core, enum platform_clk_type clk_type); >>>>>> +struct device *iris_create_cb_dev(struct iris_core *core, const char *name, const u32 *f_id); >>>>>> #endif >>>>>> >>>>>> -- >>>>>> 2.34.1 >>>>>>