From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Jun Nie <jun.nie@linaro.org>,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] PM / devfreq: qcom: Introduce CCI devfreq driver
Date: Wed, 1 Feb 2023 19:19:18 +0200 [thread overview]
Message-ID: <9c86f610-b8f8-a6e5-396a-1f6339c8529f@linaro.org> (raw)
In-Reply-To: <8eb9ba9b-dce8-5ece-6c2a-7e7a758c75ab@linaro.org>
On 01/02/2023 19:16, Bryan O'Donoghue wrote:
> On 01/02/2023 17:12, Dmitry Baryshkov wrote:
>> On 01/02/2023 17:17, Bryan O'Donoghue wrote:
>>> On 01/02/2023 14:58, Dmitry Baryshkov wrote:
>>>> On 01/02/2023 16:45, Bryan O'Donoghue wrote:
>>>>> On 01/02/2023 13:41, Dmitry Baryshkov wrote:
>>>>>>> cci-cpufreq {
>>>>>>> target-dev = <&cci_cache>;
>>>>>>> cpu-to-dev-map-0 =
>>>>>>> < 200000 200000000 >,
>>>>>>> < 345600 200000000 >,
>>>>>>> < 400000 200000000 >,
>>>>>>> < 533330 297600000 >,
>>>>>>> < 800000 297600000 >,
>>>>>>> < 960000 297600000 >,
>>>>>>> < 1113600 297000000 >,
>>>>>>> < 1344000 595200000 >,
>>>>>>> < 1459200 595200000 >,
>>>>>>> < 1497600 595200000 >,
>>>>>>> < 1651200 595200000 >;
>>>>>>> cpu-to-dev-map-4 =
>>>>>>> < 200000 200000000 >,
>>>>>>> < 249600 200000000 >,
>>>>>>> < 499200 297600000 >,
>>>>>>> < 800000 297600000 >,
>>>>>>> < 998400 595200000 >,
>>>>>>> < 1113600 595200000 >;
>>>>>> These should map to existing opp entries.
>>>>>>
>>>>>> I ended up doing the interconnect driver that maps a clock to the
>>>>>> interconnect. Then I can use it in the cpu opp tables.
>>>>>>
>>>>>
>>>>> Can you point us at what it is you are proposing ?
>>>>
>>>> https://patchwork.kernel.org/project/linux-arm-msm/patch/20230120061417.2623751-9-dmitry.baryshkov@linaro.org/
>>>>
>>> Is there no driver code too ?
>>
>> There are two parts, one is the 'CBF clock' driver, which just
>> provides a clock, another part actually connects the clock and
>> interconnect. Initially I implemented it as a part of the CBF driver
>> (see
>> https://patchwork.kernel.org/project/linux-arm-msm/patch/20230120061417.2623751-5-dmitry.baryshkov@linaro.org/), next revision will move the interconnect part to drivers/interconnect.
>>
>
> Ah so just to be clear - discussing with Dmitry - CCI has its own set of
> fuses.
>
> We have fusebin settings for clusterX and CCI.
>
> So, I think we agree this means a separate driver for cci is warranted.
Yes.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-02-01 17:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 8:02 [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm CCI dt-bindings Jun Nie
2023-02-01 8:02 ` [PATCH 2/2] PM / devfreq: qcom: Introduce CCI devfreq driver Jun Nie
2023-02-01 8:48 ` Krzysztof Kozlowski
2023-02-01 15:15 ` Jun Nie
2023-02-01 10:27 ` Bryan O'Donoghue
2023-02-01 11:02 ` Chanwoo Choi
2023-02-01 15:17 ` Jun Nie
2023-02-01 17:18 ` Dmitry Baryshkov
2023-02-01 11:32 ` Dmitry Baryshkov
2023-02-01 11:46 ` Bryan O'Donoghue
2023-02-01 13:41 ` Dmitry Baryshkov
2023-02-01 14:45 ` Bryan O'Donoghue
2023-02-01 14:58 ` Dmitry Baryshkov
2023-02-01 15:17 ` Bryan O'Donoghue
2023-02-01 17:12 ` Dmitry Baryshkov
2023-02-01 17:16 ` Bryan O'Donoghue
2023-02-01 17:19 ` Dmitry Baryshkov [this message]
2023-02-02 12:55 ` Jun Nie
2023-02-01 15:23 ` Jun Nie
2023-02-01 8:43 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm CCI dt-bindings Krzysztof Kozlowski
2023-02-02 9:29 ` Jun Nie
2023-02-02 9:42 ` Krzysztof Kozlowski
2023-02-03 3:45 ` Jun Nie
2023-02-03 7:06 ` Krzysztof Kozlowski
2023-02-01 10:46 ` Chanwoo Choi
2023-02-01 14:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c86f610-b8f8-a6e5-396a-1f6339c8529f@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jun.nie@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).