From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Bernhard Rosenkränzer" <bero@baylibre.com>,
linux-mediatek@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
matthias.bgg@gmail.com
Subject: Re: [PATCH v2 07/15] dt-bindings: mmc: mtk-sd: add bindings for MT8365 SoC
Date: Tue, 15 Nov 2022 10:44:57 +0100 [thread overview]
Message-ID: <9c883417-5a26-cc5d-a6c4-c00cba53f638@linaro.org> (raw)
In-Reply-To: <20221115025421.59847-8-bero@baylibre.com>
On 15/11/2022 03:54, Bernhard Rosenkränzer wrote:
> From: Fabien Parent <fparent@baylibre.com>
>
> Add MMC bindings for MT8365 bindings.
Drop second, redundant "bindings" from subject.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 6f8ecb4788eb8..36f9fce8f4795 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -35,6 +35,9 @@ properties:
> - mediatek,mt8192-mmc
> - mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> + - items:
> + - const: mediatek,mt8365-mmc
> + - const: mediatek,mt8183-mmc
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-15 9:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 21:10 [PATCH] arm64: dts: mediatek: Initial mt8365-evk support Bernhard Rosenkränzer
2022-11-08 10:02 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 00/15] Initial Mediatek MT8365 SOC and MT8365-EVK board support Bernhard Rosenkränzer
2022-11-15 2:54 ` [PATCH v2 01/15] arm64: dts: mediatek: Initial mt8365-evk support Bernhard Rosenkränzer
2022-11-15 9:23 ` AngeloGioacchino Del Regno
2022-11-15 9:41 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 02/15] dt-bindings: watchdog: mtk-wdt: Add MT8365 SoC bindings Bernhard Rosenkränzer
2022-11-15 9:01 ` AngeloGioacchino Del Regno
2022-11-15 9:42 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 03/15] dt-bindings: iio: adc: mediatek: add " Bernhard Rosenkränzer
2022-11-15 9:02 ` AngeloGioacchino Del Regno
2022-11-15 9:42 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 04/15] dt-bindings: i2c: i2c-mt65xx: add binding for MT8365 SoC Bernhard Rosenkränzer
2022-11-15 2:54 ` [PATCH v2 05/15] dt-bindings: usb: mediatek,mtu3: add MT8365 SoC bindings Bernhard Rosenkränzer
2022-11-15 9:43 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 06/15] dt-bindings: usb: mediatek,mtk-xhci: " Bernhard Rosenkränzer
2022-11-15 9:44 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 07/15] dt-bindings: mmc: mtk-sd: add bindings for MT8365 SoC Bernhard Rosenkränzer
2022-11-15 9:44 ` Krzysztof Kozlowski [this message]
2022-11-15 2:54 ` [PATCH v2 08/15] dt-bindings: nvmem: mediatek,efuse: add MT8365 bindings Bernhard Rosenkränzer
2022-11-15 9:45 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 09/15] dt-bindings: mfd: syscon: Add mt8365-syscfg Bernhard Rosenkränzer
2022-11-15 9:45 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 10/15] dt-bindings: timer: Add compatible for Mediatek MT8365 Bernhard Rosenkränzer
2022-11-15 9:46 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 11/15] dt-bindings: pinctrl: add bindings for Mediatek MT8365 SoC Bernhard Rosenkränzer
2022-11-15 9:46 ` Krzysztof Kozlowski
2022-11-15 14:11 ` Rob Herring
2022-11-15 2:54 ` [PATCH v2 12/15] dt-bindings: soc: mediatek: pwrap: add compatible for mt8365 Bernhard Rosenkränzer
2022-11-15 9:46 ` Krzysztof Kozlowski
2022-11-15 2:54 ` [PATCH v2 13/15] dt-bindings: irq: mtk, sysirq: add support " Bernhard Rosenkränzer
2022-11-15 2:54 ` [PATCH v2 14/15] dt-bindings: thermal: mediatek: add documentation for MT8365 SoC Bernhard Rosenkränzer
2022-11-15 2:54 ` [PATCH v2 15/15] dt-bindings: arm64: dts: mediatek: Add mt8365-evk board Bernhard Rosenkränzer
2022-11-15 9:47 ` Krzysztof Kozlowski
2022-11-15 13:50 ` [PATCH v2 00/15] Initial Mediatek MT8365 SOC and MT8365-EVK board support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c883417-5a26-cc5d-a6c4-c00cba53f638@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bero@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).