From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Richard Acayan <mailingradian@gmail.com>, linux-arm-msm@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/4] dmaengine: qcom: gpi: drop redundant of_device_id entries
Date: Wed, 28 Sep 2022 09:49:46 +0200 [thread overview]
Message-ID: <9c88a0ba-36c4-ae04-cf04-51174613893a@linaro.org> (raw)
In-Reply-To: <20220927014846.32892-5-mailingradian@gmail.com>
On 27/09/2022 03:48, Richard Acayan wrote:
> The drivers are transitioning from matching against lists of specific
> compatible strings to matching against smaller lists of more generic
> compatible strings. Continue the transition in the GPI DMA driver.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> drivers/dma/qcom/gpi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 89839864b4ec..e5f37d61f30a 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -2289,8 +2289,6 @@ static const struct of_device_id gpi_of_match[] = {
> { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 },
> { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 },
> { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 },
> - { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 },
> - { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
You cannot remove them that fast - it would be an ABI break. Just add a
comment that these are deprecated and devices should match with a
fallback compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-28 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 1:48 [PATCH v3 0/4] SDM670 GPI DMA support Richard Acayan
2022-09-27 1:48 ` [PATCH v3 1/4] dt-bindings: dma: qcom: gpi: add fallback compatible Richard Acayan
2022-09-28 7:48 ` Krzysztof Kozlowski
2022-09-27 1:48 ` [PATCH v3 2/4] dt-bindings: dma: qcom: gpi: add compatible for sdm670 Richard Acayan
2022-09-28 7:48 ` Krzysztof Kozlowski
2022-09-27 1:48 ` [PATCH v3 3/4] arm64: dts: qcom: add gpi-dma fallback compatible Richard Acayan
2022-09-28 7:48 ` Krzysztof Kozlowski
2022-09-27 1:48 ` [PATCH v3 4/4] dmaengine: qcom: gpi: drop redundant of_device_id entries Richard Acayan
2022-09-28 7:49 ` Krzysztof Kozlowski [this message]
2022-09-29 7:40 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c88a0ba-36c4-ae04-cf04-51174613893a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).