From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0FDC4332F for ; Sat, 12 Nov 2022 11:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233947AbiKLLPJ (ORCPT ); Sat, 12 Nov 2022 06:15:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231240AbiKLLPI (ORCPT ); Sat, 12 Nov 2022 06:15:08 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7432D192AB for ; Sat, 12 Nov 2022 03:15:07 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id d6so11890096lfs.10 for ; Sat, 12 Nov 2022 03:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BP3HObLwfnQ6Z033Q/+ZsVYc5sgYgaxGGPnUH0Zg5Zg=; b=D9CjHXdC2dDtUGwfpFzrppKqh3FCN2xg3+eiugFIqSdPBMtIc/ZqtiQB6wIv+N6xo2 fZRQ+OuQe7PNEaUQpRysJSHHCAF9tNIaMcmX+ndioHtqTedd10nfELorFV09fVegr3RU Z/+e1A3R3yW2kBiCKb4Tmi8nuBdzqHDnryaVBur52TP1G+0Xs3r7LkonykEJrlDdrVAL rS7/4nynNZpQZ3Gu710mccDL0ejFyR6otdDdRcdpvyIY7mt6a5yd60qFJvKaI0AUnare 6PpX+SuzJjr76KOG2SIIU4rpaAZiU1AuwlPQQFanB1+W25Ddi0gfPFdpJr9dJIglvHmm F5mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BP3HObLwfnQ6Z033Q/+ZsVYc5sgYgaxGGPnUH0Zg5Zg=; b=tT7vn1u/z+JOy1zJDuXht1cC34IEXm7OaqBM/nnrGtIgQJIfP2K0vPOP83cjoyIRlh VSN2ba6srRyWAEwAkQ3CBRj+odUtLSAPTkMB9VGGHVISEZdHWCUlDPLL2n8off4IgqW8 /gHWdKvyE3EpoPxx/BdUPVMT2Rzf3G4nvue3Uez/S+I1ccDLkCbt5XqQzEftTQMjUMBa qgirxL6VCg+ckP5v2PQ/cFeod0gHHqEeSnCscj1NKLARsaKXvHYQxQJE5SOXhOJxNdLq OQNhk8w7WdVBCx8c4I+YowmAkQrsyCrO+s5aSyUo2QPuSewh0vfGm474IiQ92lumn19P MPqQ== X-Gm-Message-State: ANoB5pkgYaelfjH6ExJAaRfUZC5ABRPRMZpJKFLut6t6W+B5ZR10bTSH I8bmG1ilqpH442wTTSYxyL3vJg== X-Google-Smtp-Source: AA0mqf63YnUBeua3mL7qR3PkxrkqtWWRHuxK7R+CfBrmhjcm4iJJ/tIaUB+VKUkYN7sx1ncWqJ7fvw== X-Received: by 2002:a19:5016:0:b0:4ad:5fbb:a5b0 with SMTP id e22-20020a195016000000b004ad5fbba5b0mr1832416lfb.466.1668251705808; Sat, 12 Nov 2022 03:15:05 -0800 (PST) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id u19-20020a05651220d300b0049462af8614sm823974lfr.145.2022.11.12.03.15.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Nov 2022 03:15:05 -0800 (PST) Message-ID: <9c94f81c-963e-d1a3-6514-f803bb7e05fa@linaro.org> Date: Sat, 12 Nov 2022 14:15:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 05/14] phy: qcom-qmp-combo: register clocks sooner To: Johan Hovold , Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221111092457.10546-1-johan+linaro@kernel.org> <20221111092457.10546-6-johan+linaro@kernel.org> Content-Language: en-GB From: Dmitry Baryshkov In-Reply-To: <20221111092457.10546-6-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/11/2022 12:24, Johan Hovold wrote: > Runtime PM should be enabled before registering the PHYs, but there is > no reason that the clocks can not be registered before enabling runtime > PM. This will have a side effect of DP and pipe clocks not using runtime PM during the clocks operations (see the code handling rpm_enabled in drivers/clk/clk.c). If this is an intended change, it should be described in the commit message. > > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index 1bc8567a8605..1a6aa61a12c5 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -2642,6 +2642,14 @@ static int qmp_combo_probe(struct platform_device *pdev) > if (ret) > goto err_node_put; > > + ret = phy_pipe_clk_register(qmp, usb_np); > + if (ret) > + goto err_node_put; > + > + ret = phy_dp_clks_register(qmp, dp_np); > + if (ret) > + goto err_node_put; > + > pm_runtime_set_active(dev); > ret = devm_pm_runtime_enable(dev); > if (ret) > @@ -2652,14 +2660,6 @@ static int qmp_combo_probe(struct platform_device *pdev) > */ > pm_runtime_forbid(dev); > > - ret = phy_pipe_clk_register(qmp, usb_np); > - if (ret) > - goto err_node_put; > - > - ret = phy_dp_clks_register(qmp, dp_np); > - if (ret) > - goto err_node_put; > - > qmp->usb_phy = devm_phy_create(dev, usb_np, &qmp_combo_usb_phy_ops); > if (IS_ERR(qmp->usb_phy)) { > ret = PTR_ERR(qmp->usb_phy); -- With best wishes Dmitry