From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>,
jic23@kernel.org, robh+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] iio:frequency:admv1014: add support for ADMV1014
Date: Thu, 10 Feb 2022 09:26:21 +0100 [thread overview]
Message-ID: <9cd8a336ed31eaf6bea2ad53f185abac22dc8474.camel@gmail.com> (raw)
In-Reply-To: <YgOtN+wha+j3ZFIO@smile.fi.intel.com>
On Wed, 2022-02-09 at 14:01 +0200, Andy Shevchenko wrote:
> On Mon, Feb 07, 2022 at 09:29:54PM +0100, Nuno Sá wrote:
> > On Sat, 2022-02-05 at 20:23 +0200, Andy Shevchenko wrote:
> > > On Mon, Jan 31, 2022 at 12:00:59PM +0200, Antoniu Miclaus wrote:
> > > > The ADMV1014 is a silicon germanium (SiGe), wideband,
> > > > microwave downconverter optimized for point to point microwave
> > > > radio designs operating in the 24 GHz to 44 GHz frequency
> > > > range.
> > >
> > > Excellent job!
> > > A few comments / questions below.
> > >
> > > ...
> > >
> > > > +config ADMV1014
> > > > + tristate "Analog Devices ADMV1014 Microwave
> > > > Downconverter"
> > > > + depends on SPI && COMMON_CLK && 64BIT
> > >
> > > Why 64BIT only?
> >
> > Could not resist on this one... The thing is that CCF uses unsigned
> > long for rates and this part operates in high GHz values. That
> > means,
> > as CCF stands, this cannot work on 32bit.
>
> I read it a bit differently, i.e. CCF has a bug that needs to be
> addressed.
>
Totally agreed...
However, this can be something that might take time
to support in CCF (I definetly have plans to send a RFC to, at least,
start the discussion around this) so I guess we can already support
this device like this. I believe this is somethig straight to remove
as soon as CCF works in 32bit archs for high speed devices...
- Nuno Sá
next prev parent reply other threads:[~2022-02-10 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 10:00 [PATCH v5 1/4] iio:frequency:admv1014: add support for ADMV1014 Antoniu Miclaus
2022-01-31 10:01 ` [PATCH v5 2/4] dt-bindings:iio:frequency: add admv1014 binding Antoniu Miclaus
2022-02-04 22:38 ` Rob Herring
2022-01-31 10:01 ` [PATCH v5 3/4] Documentation:ABI:testing:admv1014: add ABI docs Antoniu Miclaus
2022-01-31 10:01 ` [PATCH v5 4/4] MAINTAINERS: add maintainer for ADMV1014 driver Antoniu Miclaus
2022-02-05 18:23 ` [PATCH v5 1/4] iio:frequency:admv1014: add support for ADMV1014 Andy Shevchenko
2022-02-06 15:22 ` Jonathan Cameron
2022-02-07 20:29 ` Nuno Sá
2022-02-09 12:01 ` Andy Shevchenko
2022-02-10 8:26 ` Nuno Sá [this message]
2022-02-05 18:34 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd8a336ed31eaf6bea2ad53f185abac22dc8474.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).