From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Kyle Hsieh <kylehsieh1995@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v3 0/2] Add Meta(Facebook) ventura2 BMC(AST2600)
Date: Thu, 15 Jan 2026 11:42:45 +1030 [thread overview]
Message-ID: <9cdf03250dd923859638de4850ce4b4e4279bf8a.camel@codeconstruct.com.au> (raw)
In-Reply-To: <c391ded8-6569-48a2-9c49-6b68838f91b0@oss.qualcomm.com>
On Tue, 2026-01-13 at 08:17 +0100, Krzysztof Kozlowski wrote:
> On 13/01/2026 03:57, Kyle Hsieh wrote:
> > Summary:
> > Add linux device tree entry related to Meta(Facebook) ventura2.
> > specific devices connected to BMC(AST2600) SoC.
> >
> > Signed-off-by: Kyle Hsieh <kylehsieh1995@gmail.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> Where? How is this possible?
Kyle: Tags only apply to the patches they were provided for. Tacking
this one on the cover letter implies Krzysztof has acked the devicetree
as well, which is not the case with respect to [1].
[1]: https://lore.kernel.org/all/20251223-ginger-worm-of-swiftness-a8fa05@quoll/
It appears you're already using b4. b4 also handles tags for you:
https://b4.docs.kernel.org/en/latest/contributor/trailers.html
As it suggests, run `b4 trailers -u` to automatically and correctly
apply tags you have received for your changes.
Please fix the issue here (remove the tag from the cover-letter, apply
tags to the correct patches) and send again, _after_ you've addressed
all further feedback on v3.
Andrew
prev parent reply other threads:[~2026-01-15 1:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 2:57 [PATCH v3 0/2] Add Meta(Facebook) ventura2 BMC(AST2600) Kyle Hsieh
2026-01-13 2:57 ` [PATCH v3 1/2] dt-bindings: arm: aspeed: add Meta ventura2 board Kyle Hsieh
2026-01-13 7:18 ` Krzysztof Kozlowski
2026-01-13 2:57 ` [PATCH v3 2/2] ARM: dts: aspeed: ventura2: Add Meta ventura2 BMC Kyle Hsieh
2026-01-13 19:33 ` Andrew Lunn
2026-01-15 1:24 ` Andrew Jeffery
2026-01-13 7:17 ` [PATCH v3 0/2] Add Meta(Facebook) ventura2 BMC(AST2600) Krzysztof Kozlowski
2026-01-15 1:12 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cdf03250dd923859638de4850ce4b4e4279bf8a.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kylehsieh1995@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox