From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EF377E777 for ; Tue, 9 Apr 2024 09:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712654005; cv=none; b=eyo03P+JCrH9yyDCmkw9emty1be9kUzBODzd4fKoqWlmxCM9oNB7F7q4AKcl7zbBY1CGYypttr+12JHxTHr72/z8EuLUlam8js7tC3RrUW26TySl8uXUIcY0Ci5Fz8TI1PYPpPertOB+OYrt0M89zeyHJ9BYDmqluG8IEPghVlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712654005; c=relaxed/simple; bh=DDDP1MRm7J507ibgfXCuV7RGp0XeST5hGJXpspFd8rM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=AdPPUNPrEE/SqnK+KwEmplOwR6d4Z8cB2/LHQQEamJuRpG/xHScM3LTzdYtYMYq1OOLUdyyoq2h0sb3UbIiBhR458FHd4VPDVje1DgQ+aeVVYoi2fQAyjko+jwSbLTU//2+p4ASUuEGuAM3+cuBw/NpDxMYdOfaK1YC7/9vNcmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ru7XW-0004PQ-Cr; Tue, 09 Apr 2024 11:13:14 +0200 Message-ID: <9ce35b9bb5a15891f6bd01bd54b7dc84b3ba4021.camel@pengutronix.de> Subject: Re: [PATCH v1] arm64: dts: imx8mm: fix missing pgc_vpu_* power domain parent From: Lucas Stach To: Vitor Soares , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Vitor Soares , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Tue, 09 Apr 2024 11:13:13 +0200 In-Reply-To: <20240409085802.290439-1-ivitro@gmail.com> References: <20240409085802.290439-1-ivitro@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Hi Vitor, Am Dienstag, dem 09.04.2024 um 09:58 +0100 schrieb Vitor Soares: > From: Vitor Soares >=20 > The pgc_vpu_* nodes miss the reference to the power domain parent, > leading the system to hang during the resume. >=20 This change is not correct. The vpumix domain is controlled through the imx8mm-vpu-blk-ctrl and must not be directly triggered by the child domains in order to guarantee proper power sequencing. If the sequencing is incorrect for resume, it needs to be fixed in the blk-ctrl driver. I'll happily assist if you have any questions about this intricate mix between GPC and blk-ctrl hardware/drivers. Regards, Lucas > As these PU domains are nested inside the vpumix domain, let's reference > it accordingly. After this change, the suspend/resume is working. >=20 > Cc: Lucas Stach > Cc: > Closes: https://lore.kernel.org/all/fccbb040330a706a4f7b34875db1d896a0bf8= 1c8.camel@gmail.com/ > Fixes: d39d4bb15310 ("arm64: dts: imx8mm: add GPC node") > Signed-off-by: Vitor Soares > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/= dts/freescale/imx8mm.dtsi > index 8a1b42b94dce..97d0c6d23ad8 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -739,16 +739,19 @@ pgc_vpumix: power-domain@6 { > pgc_vpu_g1: power-domain@7 { > #power-domain-cells =3D <0>; > reg =3D ; > + power-domains =3D <&pgc_vpumix>; > }; > =20 > pgc_vpu_g2: power-domain@8 { > #power-domain-cells =3D <0>; > reg =3D ; > + power-domains =3D <&pgc_vpumix>; > }; > =20 > pgc_vpu_h1: power-domain@9 { > #power-domain-cells =3D <0>; > reg =3D ; > + power-domains =3D <&pgc_vpumix>; > }; > =20 > pgc_dispmix: power-domain@10 {