From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Flavio Suligoi <f.suligoi@asem.it>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Douglas Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>, Ray Chi <raychi@google.com>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH v2 3/3] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0/3.0 PHY
Date: Fri, 2 Jun 2023 07:33:55 +0000 [thread overview]
Message-ID: <9cf3f726120846fabfcca269155d948c@realtek.com> (raw)
In-Reply-To: <1231d116-ca4b-fb73-d000-d531297343e7@linaro.org>
Hi Krzysztof,
> >> If these can be in the driver, why would ever they be in DTS in the first
> place?
> >>
> > Our platforms have 3 xhci controllers which map to 3 different phy ports.
>
> You mean on the same SoC?
Yes, one SoC has three xhci controllers.
> > And the three phy ports use the same driver, but the parameters are
> different.
> > So I put the parameter settings in DTS, we have 3 usb-phy nodes representing
> 3 phy ports.
> > Also, some parameters have to be adjusted for different boards.
> > Therefore, it is more applicable in DTS than in driver.
>
> Then it looks justified in DT, so please write proper descriptions for proper
> properties. Underscores are not allowed in node names. No fake nodes.
> Properties should usually describe physical/hardware effect not the register
> value.
I will write more detail for properties.
> qcom,usb-snps-femto-v2.yaml is nice example. Few Mediatek bindings also
> would work.
> '
Thanks,
Stanley
next prev parent reply other threads:[~2023-06-02 7:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 2:26 [PATCH v2 1/3] usb: phy: add usb phy notify port status API Stanley Chang
2023-05-25 2:26 ` [PATCH v2 2/3] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0/3.0 PHY Stanley Chang
2023-05-29 14:25 ` Greg Kroah-Hartman
2023-05-30 1:50 ` Stanley Chang[昌育德]
2023-05-30 7:31 ` Greg Kroah-Hartman
2023-05-30 7:37 ` Stanley Chang[昌育德]
2023-05-25 2:26 ` [PATCH v2 3/3] dt-bindings: phy: realtek: Add the doc about " Stanley Chang
2023-05-29 18:59 ` Conor Dooley
2023-05-30 3:08 ` Stanley Chang[昌育德]
2023-05-30 6:56 ` Conor Dooley
[not found] ` <202305310146.34V1kevI7026106@rtits1.realtek.com.tw>
2023-06-01 2:24 ` Stanley Chang[昌育德]
2023-06-01 20:13 ` Conor Dooley
[not found] ` <0b2143ca-ead7-c8fa-2e80-a94222af51ca@linaro.org>
2023-06-01 10:49 ` Stanley Chang[昌育德]
2023-06-01 15:32 ` Krzysztof Kozlowski
2023-06-02 3:20 ` Stanley Chang[昌育德]
2023-06-02 7:10 ` Krzysztof Kozlowski
2023-06-02 7:33 ` Stanley Chang[昌育德] [this message]
2023-05-29 14:27 ` [PATCH v2 1/3] usb: phy: add usb phy notify port status API Greg Kroah-Hartman
2023-05-30 2:19 ` Stanley Chang[昌育德]
2023-05-30 7:32 ` Greg Kroah-Hartman
2023-05-30 7:38 ` Stanley Chang[昌育德]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cf3f726120846fabfcca269155d948c@realtek.com \
--to=stanley_chang@realtek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mathias.nyman@linux.intel.com \
--cc=mka@chromium.org \
--cc=raychi@google.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).