From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB01C7EE2A for ; Thu, 11 May 2023 09:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236816AbjEKJ1G (ORCPT ); Thu, 11 May 2023 05:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237123AbjEKJ0a (ORCPT ); Thu, 11 May 2023 05:26:30 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7D3FD068 for ; Thu, 11 May 2023 02:26:22 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-94f4b911570so1309379766b.0 for ; Thu, 11 May 2023 02:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683797181; x=1686389181; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X1IslJ7/3eQpHk0/ZONImP6ek9rvCI7d+h3hwQhusW0=; b=A3Lr/820FEisUc53N/6tIVzuEVp+khhimTcSLGsHq/i4fzqx7tp7I5DIC8bO/XwKAj DeCiey9CQk6CwmWdxVDc0ZLz0mFUSFVrXlg5gDkLclK8DPZxwGUd8Yk6O8WeNnw0ZD8n Y/BfVlIyj84qT8f0TXBAstume3ASfUzN6q65DvvZ74VUOE188xiWnitj/+IhI6/eUNgH i4cs5MlkAoXkApk/gkivGx4lkUZfcNoETbCpJEgZmTQtRt1GRkblYskEkCSle1KNUfwd kYSffouJuyUP8LZi2uM6C0wNwsQ+oJ+XUE/aeW0qabBZyLyg45XDKfxconB4I5sjwxsd TJDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683797181; x=1686389181; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X1IslJ7/3eQpHk0/ZONImP6ek9rvCI7d+h3hwQhusW0=; b=bMo4X0/BjgahbpykS+CLKGke82T6diUmANrX9lr285Ntjibf7ByTmhSNgDUY9x4iPl lYWdjQm2dxHDJx4yFjMOOLB1jIbMQmVfmoMJ2eYJl2nGfn63G1HKAWQ95F+7l2CnFmz7 /jRfeoaVyiz+YWYvrjl0OcSrv10HF0EDwSXmuwmQMQVmLJhM50r22m1O7i5JBJWFPVDq FKm+y2k5AYXpW0KOyDppBY5aQ1+PwZqHHrqsCdky011faPbom6sF//61QQhQ27hHpqP4 f2LnIz21yViUxMWvRCwMdACuIke3mKYbmncxiCScs4t8eKpRpDgTWCcSK+oRRiiDY+bY EQeg== X-Gm-Message-State: AC+VfDw09HqqfHACN4XAgx+u+AveS/ROdBV41msyef9kVfKG/ZPDQLvC R4yrmMTd3xaMp9KwxPG5R8TcAQ== X-Google-Smtp-Source: ACHHUZ74t7K+CeQz4z8BQyobf4t7TRb93OAiK2Zks93fMy5n6HFkZY/H0v/9xh4mpxhbpUlCfqdB2A== X-Received: by 2002:a17:907:78c:b0:953:43a1:1988 with SMTP id xd12-20020a170907078c00b0095343a11988mr17157850ejb.46.1683797181377; Thu, 11 May 2023 02:26:21 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7e61:f14a:c3a4:809e? ([2a02:810d:15c0:828:7e61:f14a:c3a4:809e]) by smtp.gmail.com with ESMTPSA id n7-20020aa7d047000000b004fbdfbb5acesm2818308edo.89.2023.05.11.02.26.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 May 2023 02:26:20 -0700 (PDT) Message-ID: <9cf5965a-8290-dfff-9f92-07ed2df66650@linaro.org> Date: Thu, 11 May 2023 11:26:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/2] dt-bindings: cdns,usb3: Add clock and reset Content-Language: en-US To: Minda Chen , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Roger Quadros , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20230510132816.108820-1-minda.chen@starfivetech.com> <20230510132816.108820-2-minda.chen@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230510132816.108820-2-minda.chen@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/05/2023 15:28, Minda Chen wrote: > To support generic clock and reset init in Cadence USBSS > controller, add clock and reset dts configuration. > > Signed-off-by: Minda Chen > --- > .../devicetree/bindings/usb/cdns,usb3.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > index cae46c4982ad..623c6b34dee3 100644 > --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > @@ -42,6 +42,18 @@ properties: > - const: otg > - const: wakeup > > + clocks: > + minItems: 1 > + maxItems: 8 > + description: > + USB controller clocks. You need to list the items. And why is it variable? Your clock choice in the example is poor, I doubt it is real. > + > + resets: > + minItems: 1 > + maxItems: 8 > + description: > + USB controller generic resets. Here as well. You had one clock last time, thus the review was - drop the names. Now you changed it to 8 clocks... I don't understand. Best regards, Krzysztof