devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gatien CHEVALLIER <gatien.chevallier@foss.st.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	<devicetree@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] arm64: dts: st: enable ethernet1 controller on stm32mp257f-dk
Date: Wed, 3 Sep 2025 15:35:01 +0200	[thread overview]
Message-ID: <9cfa9cb4-bf7e-4d48-b0cc-0726784b7462@foss.st.com> (raw)
In-Reply-To: <5c49e94a-9267-459a-ba6c-70f3763f1a7b@lunn.ch>



On 9/3/25 14:21, Andrew Lunn wrote:
>> +&ethernet1 {
>> +	pinctrl-0 = <&eth1_rgmii_pins_b>;
>> +	pinctrl-1 = <&eth1_rgmii_sleep_pins_b>;
>> +	pinctrl-names = "default", "sleep";
>> +	max-speed = <1000>;
> 
> RGMII naturally has a max-speed of 1G, so this line is pointless.
> 
> You only use max-speed when you need to restrict the system below what
> it would normally use, for example if the PCB is badly designed and
> the tracks don't support 1G, but can do 100Mbps
> 
> 	Andrew

Right, I'll simply remove these lines.

Gatien

  reply	other threads:[~2025-09-03 13:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03  9:53 [PATCH 0/4] arm64: dts: st: add ethernet1 controller support on stm32mp23/25 boards Gatien Chevallier
2025-09-03  9:53 ` [PATCH 1/4] arm64: dts: st: add eth1 pins for stm32mp2x platforms Gatien Chevallier
2025-09-03  9:53 ` [PATCH 2/4] arm64: dts: st: enable ethernet1 controller on stm32mp257f-dk Gatien Chevallier
2025-09-03 12:21   ` Andrew Lunn
2025-09-03 13:35     ` Gatien CHEVALLIER [this message]
2025-09-03  9:53 ` [PATCH 3/4] arm64: dts: st: enable ethernet1 controller on stm32mp257f-ev1 Gatien Chevallier
2025-09-03 12:24   ` Andrew Lunn
2025-09-03 12:46     ` Gatien CHEVALLIER
2025-09-03  9:53 ` [PATCH 4/4] arm64: dts: st: enable ethernet1 controller on stm32mp235f-dk Gatien Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cfa9cb4-bf7e-4d48-b0cc-0726784b7462@foss.st.com \
    --to=gatien.chevallier@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).