From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naushir Patuck <naush@raspberrypi.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH 2/4] dt-bindings: media: Add bindings for raspberrypi,rp1-cfe
Date: Tue, 19 Mar 2024 14:02:24 +0100 [thread overview]
Message-ID: <9d238cd6-0e11-4775-bc00-7df50f0a6638@linaro.org> (raw)
In-Reply-To: <CAEmqJPrLP3j37Kcj0mX23x00p=gWuxZPNSUTRGNkcEqsUJ2MjQ@mail.gmail.com>
On 19/03/2024 13:57, Naushir Patuck wrote:
>>>>
>>>> See writing bindings. Compatibles should be SoC specific. In some cases
>>>> generic fallbacks make sense, in some note. But don't just choose
>>>> "generic fallback" because you want. Provide rationale.
>>>
>>> If the compatible is SoC specific, I suppose "raspberrypi,rp1-cfe"
>>> would be the correct string.
>>
>> Sure, but then please think what if rp1 is on Rpi6, called exactly the
>> same (rp1), with some minor differences? Could it be?
>
> Yes, this is definitely possible. In such cases, I would expect the
> hardware to have a version register that would be queried by the
> driver to adjust for minor differences, and the compatible string
> remains the same. Does that seem reasonable?
The "would expect" is concerning. The register(s) must be there already,
with proper value.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-19 13:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 15:49 [PATCH 0/4] media: raspberrypi: Support RPi5's CFE Tomi Valkeinen
2024-03-18 15:49 ` [PATCH 1/4] media: uapi: Add meta formats for PiSP FE config and stats Tomi Valkeinen
2024-03-18 15:49 ` [PATCH 2/4] dt-bindings: media: Add bindings for raspberrypi,rp1-cfe Tomi Valkeinen
2024-03-18 17:33 ` Rob Herring
2024-03-19 6:09 ` Krzysztof Kozlowski
2024-03-19 6:46 ` Tomi Valkeinen
2024-03-19 9:31 ` Krzysztof Kozlowski
2024-03-19 13:56 ` Tomi Valkeinen
2024-03-19 6:23 ` Krzysztof Kozlowski
2024-03-19 6:48 ` Tomi Valkeinen
2024-03-19 7:00 ` Tomi Valkeinen
2024-03-19 9:32 ` Krzysztof Kozlowski
2024-03-19 12:06 ` Naushir Patuck
2024-03-19 12:21 ` Krzysztof Kozlowski
2024-03-19 12:57 ` Naushir Patuck
2024-03-19 13:02 ` Krzysztof Kozlowski [this message]
2024-03-19 13:05 ` Naushir Patuck
2024-03-19 14:03 ` Tomi Valkeinen
2024-03-19 15:32 ` Naushir Patuck
2024-03-19 17:05 ` Tomi Valkeinen
2024-03-20 8:50 ` Naushir Patuck
2024-03-20 9:12 ` Krzysztof Kozlowski
2024-03-18 15:49 ` [PATCH 3/4] media: raspberrypi: Add support for RP1-CFE Tomi Valkeinen
2024-03-18 15:49 ` [PATCH 4/4] media: admin-guide: Document the Raspberry Pi CFE (rp1-cfe) Tomi Valkeinen
2024-03-19 6:05 ` [PATCH 0/4] media: raspberrypi: Support RPi5's CFE Krzysztof Kozlowski
2024-03-19 6:21 ` Tomi Valkeinen
2024-03-19 6:23 ` Krzysztof Kozlowski
2024-03-19 6:29 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d238cd6-0e11-4775-bc00-7df50f0a6638@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel-list@raspberrypi.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=naush@raspberrypi.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox