[PATCH] ASoC: dt-bindings: irondevice,sma1303.yaml: Fix about breaking the checks

[PATCH] ASoC: dt-bindings: irondevice,sma1303.yaml: Fix about breaking the checks

[Kiseok Jo]

Fix the bindings checks like syntax error.

Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>
Reported-by: Rob Herring <robh@kernel.org>
---
 .../bindings/sound/irondevice,sma1303.yaml          | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
index eb87374cc812..162c52606635 100644
--- a/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
+++ b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
@@ -19,14 +19,13 @@ required:
   - compatible
   - reg
 
-additionalProperties: true
+additionalProperties: false
 
 examples:
   - |
-    #include <dt-bindings/gpio/gpio.h>
     i2c_bus {
-		sma1303_amp: sma1303@1e {
-			compatible = "irondevice,sma1303";
-			reg = <0x1e>;
-		};
-	};
+        amplifier@1e {
+            compatible = "irondevice,sma1303";
+            reg = <0x1e>;
+        };
+    };

base-commit: eeb6b0feb597e8fb88c4e1459323060e17350752
-- 
2.20.1

Re: [PATCH] ASoC: dt-bindings: irondevice,sma1303.yaml: Fix about breaking the checks

[Mark Brown]

On Tue, 31 Jan 2023 05:09:47 +0000, Kiseok Jo wrote:
> Fix the bindings checks like syntax error.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: irondevice,sma1303.yaml: Fix about breaking the checks
      commit: 1c24d12b68fa85fe51184ac64f446b27a4ccfaec

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH] ASoC: dt-bindings: irondevice,sma1303.yaml: Fix about breaking the checks

[Krzysztof Kozlowski]

On 31/01/2023 06:09, Kiseok Jo wrote:
> Fix the bindings checks like syntax error.
> 
> Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>
> Reported-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/sound/irondevice,sma1303.yaml          | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
> index eb87374cc812..162c52606635 100644
> --- a/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
> +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml

I would actually prefer to revert... patch was never reviewed (never
CC'ed to all maintainers as requested by get_maintainer.pl) and will
need more fixes after that fix. Eh, more patches to come.

Best regards,
Krzysztof

Re: [PATCH] ASoC: dt-bindings: irondevice,sma1303.yaml: Fix about breaking the checks

[Krzysztof Kozlowski]

On 31/01/2023 06:09, Kiseok Jo wrote:
> Fix the bindings checks like syntax error.

BTW, so not only original patch was not tested but also fix was not
tested at all. This still fails next.

Best regards,
Krzysztof