From: "Rafał Miłecki" <zajec5@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"William Zhang" <william.zhang@broadcom.com>,
"Anand Gore" <anand.gore@broadcom.com>,
"Kursad Oney" <kursad.oney@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
"Brian Norris" <briannorris@chromium.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] ARM: dts: bcm63138: drop invalid "nand" interrupt name
Date: Thu, 3 Nov 2022 17:19:23 +0100 [thread overview]
Message-ID: <9d4da23c-7acd-d23f-22e9-78677f0e9ca2@gmail.com> (raw)
In-Reply-To: <2989929f-d042-99c8-f933-2a811eab339b@gmail.com>
On 3.11.2022 17:12, Florian Fainelli wrote:
> On 11/3/2022 9:02 AM, Rafał Miłecki wrote:
>> On 3.11.2022 16:31, Florian Fainelli wrote:
>>> On 11/3/2022 3:24 AM, Rafał Miłecki wrote:
>>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>>
>>>> String "nand" was never a valid interrupt name. It was never documented
>>>> and never used in Linux or U-Boot driver. It most likely comes from a
>>>> copy & paste mistake ("nand" is used in "reg-names").
>>>>
>>>> The whole "interrupt-names" property is optional and can be skipped.
>>>
>>> How about we just fix the binding document instead? Deciding the fate of a property based upon client programs of the DTS using it is a weak argument IMHO.
>>
>> It's not a matter of client programs.
>>
>>
>> Binding clearly says that the first interrupt is "NAND CTLRDY interrupt".
>> Please check: Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>
> The binding is trying to capture all of the existing conditions that are present in Linux's tree but it is not actually specific enough for instance flash_dma_done and flash_edu_done are mutually exclusive and depend upon the controller's generation. Something that ought to be fixed as a separate patch.
In that case binding it wrong and has to be fixed first.
In this case I'll work on the binding first before cleaning DTS files.
Please drop this patch for now.
prev parent reply other threads:[~2022-11-03 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 10:24 [PATCH] ARM: dts: bcm63138: drop invalid "nand" interrupt name Rafał Miłecki
2022-11-03 15:31 ` Florian Fainelli
2022-11-03 15:58 ` Krzysztof Kozlowski
2022-11-03 16:02 ` Rafał Miłecki
2022-11-03 16:12 ` Florian Fainelli
2022-11-03 16:19 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d4da23c-7acd-d23f-22e9-78677f0e9ca2@gmail.com \
--to=zajec5@gmail.com \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).