From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B8B8C0015E for ; Thu, 6 Jul 2023 06:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233733AbjGFGjI (ORCPT ); Thu, 6 Jul 2023 02:39:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233710AbjGFGjD (ORCPT ); Thu, 6 Jul 2023 02:39:03 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AEF61BE3 for ; Wed, 5 Jul 2023 23:39:01 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9924ac01f98so37747566b.1 for ; Wed, 05 Jul 2023 23:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688625540; x=1691217540; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ubpoaC9EzMplfQrBSeEcb7LUnfn7d45sUTFt95vzvBc=; b=CQAv2r9jw5Vw9NsORpehoSIOxspn0nGUVtog4W4gS/FAyNPsXCCuel9cngxv3TafTT +ZBa9AA0N/rxkymEGOMDH+S5onhIAtQTdLoEAJMSJ7bGvGvUb3BSF0ABWRVbrsR14pjw ul4F/dN1SVMWUYwYsRmppzMlm6dHhSAi+AcJrNkBcS7rtpdjjrQm5GMtdtvK/ras3XLH C8wJ03F2x1hpoQ2VPDqtq89tKjQiQLT+uC8Vwg+oy4IfylklYNIVvMHJMYrX3A98zU2J l6ttWevu95ZeGROAk4cgc0UH8zakCbUFTb+G7QOxQCZOIniLH0ljJvotq2iHdDI6Stas P+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688625540; x=1691217540; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ubpoaC9EzMplfQrBSeEcb7LUnfn7d45sUTFt95vzvBc=; b=T0j2RrzGTNA7uJjwdppFlCPJ/e5nAzsai6QbPTpucaqOeBcyTR7MEkf9BMWTURP8W+ WEWCG16p8ruKL/yHnNboBuiCUoPf9WnFu/a/5mnLK4yo6UKPOE24yUaXm3ogVZ8yxnNR DWmypXskQXjKgKGGpFrmgCgP5LFVln/m4OLvDplybwqfDVwVZC5DikP2cIgh+RMAYOUa 3CYcnh6cE1PjCL6eYLYevQhXRiM3uHJeTnG7cvMUD+1q+xShcP7845uE3n8BzVybrkam 8ynbnraBg+kbSYleUoGbjOVTvc3vVGmPxr6wasAPbL8wRuKlW7aAixxmHjgaR+6cZIOl R1cA== X-Gm-Message-State: ABy/qLaFqdDvm34UGnUxAzeickLFj6ti6Ftjm5Be59m6S3jtOaX1PLCO lA3CKSPbfdOTRwEYkEER5A2frg== X-Google-Smtp-Source: APBJJlGdk6m02V0kX8E+G3wiBzfjjWJX4q5mx5yIhxxnI72FPFBQh7N6W0jmb66+UCh2kWaVXY/jNA== X-Received: by 2002:a17:906:729d:b0:988:b58d:5e0 with SMTP id b29-20020a170906729d00b00988b58d05e0mr738996ejl.16.1688625539940; Wed, 05 Jul 2023 23:38:59 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s24-20020a170906169800b0096f7500502csm381433ejd.199.2023.07.05.23.38.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 23:38:59 -0700 (PDT) Message-ID: <9d5c1411-e56e-fa56-c8f2-808e0c403d9a@linaro.org> Date: Thu, 6 Jul 2023 08:38:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 6/6] arm64: dts: qcom: sa8775p-ride: enable pcie nodes Content-Language: en-US To: Mrinmay Sarkar , agross@kernel.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, konrad.dybcio@linaro.org, mani@kernel.org Cc: quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Vinod Koul , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <1688545032-17748-1-git-send-email-quic_msarkar@quicinc.com> <1688545032-17748-7-git-send-email-quic_msarkar@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1688545032-17748-7-git-send-email-quic_msarkar@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/07/2023 10:17, Mrinmay Sarkar wrote: > Enable pcie0, pcie1 nodes and their respective phy's. > > Signed-off-by: Mrinmay Sarkar > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 68 +++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > index ab767cfa51ff..4a39294259fe 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > @@ -443,6 +443,74 @@ qup_uart17_rx: qup0-uart17-rx-pins { > bias-pull-down; > }; > }; > + > + pcie0_default_state: pcie0-default { > + perst { It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof