From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amelie DELAUNAY Subject: Re: [PATCH 4/6] ARM: dts: stm32: add MFX support on I2C1 on stm32746g-eval Date: Thu, 22 Feb 2018 15:34:28 +0000 Message-ID: <9d66c639-7f3e-86f3-e744-237b4be31d09@st.com> References: <1518100057-23234-1-git-send-email-amelie.delaunay@st.com> <1518100057-23234-5-git-send-email-amelie.delaunay@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Content-ID: <7A4D238C51BDB04293015EAAD0F3A6F8@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Linus Walleij Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Alexandre TORGUE , Russell King , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Rob Herring , Maxime Coquelin , Lee Jones , Linux ARM List-Id: devicetree@vger.kernel.org On 02/22/2018 02:54 PM, Linus Walleij wrote: > On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay wrote: > >> MFX is used as gpio expander on stm32746g-eval. >> >> Signed-off-by: Amelie Delaunay > > (...) >> + mfx: mfx@42 { >> + compatible = "st,mfx"; >> + reg = <0x42>; >> + interrupts = <8 1>; >> + interrupt-parent = <&gpioi>; >> + interrupt-controller; >> + #interrupt-cells = <1>; >> + >> + mfxgpio: mfx_gpio { >> + compatible = "st,mfx-gpio"; >> + interrupts = <0>; >> + interrupt-parent = <&mfx>; >> + gpio-controller; >> + #gpio-cells = <2>; > > So I think this node should contain some pin config states > that can be referenced by the drivers to set up push/pull > etc. Probably it can use just standard pin config properties > like sx150x. > I will check that point. Regards, Amelie > Yours, > Linus Walleij >