From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E6FC69313 for ; Wed, 21 Feb 2024 12:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708519147; cv=none; b=FF5a+pxBqk0aModonVLxHMAEj03yYciJxBjCVE8dDn5X73VJyzlhofq01yorRBGp1Ujrj7XaH6JNr2SxoZHb6Jjs+cJ4ghRymyWijWC+/SVXrfg3tumZDYQpGpUgbzxGomXirpFkotQzcRV4RlBnqu/PamHAJDbQ4sgxmehd5m0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708519147; c=relaxed/simple; bh=TnCYrVlMAEj4JGct0x0C+MCjGej53rLLfJWT8uFiK1k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XH+Q+xQWQ/Hu+7RLjOoSiIhKH8t7kAR5lN8gaV5Jx71ooxdLvv/ySq63LWeFXGIVcxmub/lnQNqqfyD0KMXfvusQmsmAoGrZw9rgorfXeox0n4CM4TW5ijRz/X1LNeG/2uehre3bkStmSNMZNnyfjVoItjc2yElBbEjBi4eoYDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IMbIAvvx; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IMbIAvvx" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5129cdae3c6so725955e87.1 for ; Wed, 21 Feb 2024 04:39:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708519143; x=1709123943; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=ZYeuyppugLflRNVzH8TAb7o8jn2ofICIvCXSssHvo4c=; b=IMbIAvvxny+YZCa/pnJSrDalL4/F8lGMq4C+RmUNOD983ohfKWSlohT1q3cmbhMIlV /HORdh1RJEwN7KLnO4xLAQShL7HqjzHf2Glf4F/VSz9oT29R6DAuyHn96hWTQ+FmEcTp V330YGg5Aj7gxLdhff4eQWt9LHNdwbEPaXe+kLmIXxdnxg2axOLkFKMji1I/VzIb2DBZ VItuzPM2/LO0j6+M3crZJp2d4S3gt8qZMjMphrRt5iJgfG0GxC/jCBcQcBJOLfP8EiF+ MYs6opY95GGhcqAWxNY+1NioPHZw/XKVD6aZ6oVwlefpDTGng0Vk04nt/OErjIVMRd20 zIgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708519143; x=1709123943; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZYeuyppugLflRNVzH8TAb7o8jn2ofICIvCXSssHvo4c=; b=JaUKpbM6dYptdlwK2Z5SGTegdwEvYssSnnBvTNjTnOTSLyH078xRSJkJ/DLodt8NFC Vl/Zv5t5lW+UmKuCzwEShTMpu/gqnY37E7VIAPNvAmnYTgN+gDVRYXVyYNrspQbN1gyZ LhN25jq8MB26QK5qMxfvblxvlHU/5EHSsDSy1sWz8T0R4UZjPGzUXKDRkF818qdhd5BR Dde/Ec5aKeBHfxaX5JzlbfOUoe13k0ZKGmclpADWz3Y66HYZhKLR0EJQCtvElD+nVcmt 0xLpYghzLFP61dcTYc7guJMFr8gYb7CkExY4WyWdusEEokgEsyO7pK9wcJumBUJtALIX Xa9A== X-Forwarded-Encrypted: i=1; AJvYcCUO6ryZ6SSVE5H141+LKvpELjfNzS9zX7C6kK2+DniKSHgHqJWA9Pw2py7bQLKOnixYc9Rfv+PFyUyonY1IXrNJ8/nQx4sD4LGPHw== X-Gm-Message-State: AOJu0Ywmu2SuVetunmM3qnZNlLLfzr6FuEuByF7qINSelKPrF/fLAnSB phopFARlIow3yiCDV5ww8ZWFZCJ/snNiIkcANT+MXQJjLxmcsJ9SnzRoeWKT0VXrWvlxRGNvkYo F X-Google-Smtp-Source: AGHT+IHDtSjnXmA0nn9poXI5T8J6HgDj54PdBjMLPUp030yba5bI4wq0rDdcM0l2f+N8J7SKjb69Nw== X-Received: by 2002:ac2:5a4e:0:b0:512:d86c:42d1 with SMTP id r14-20020ac25a4e000000b00512d86c42d1mr68316lfn.45.1708519143522; Wed, 21 Feb 2024 04:39:03 -0800 (PST) Received: from [192.168.192.135] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id bp25-20020a056512159900b0051148f220ccsm1631678lfb.285.2024.02.21.04.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 04:39:03 -0800 (PST) Message-ID: <9d6c617a-bc3a-47c4-a988-b41b804d8cfe@linaro.org> Date: Wed, 21 Feb 2024 13:39:01 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/21] arm64: dts: qcom: sc8280xp: Add PCIe bridge node To: Manivannan Sadhasivam , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240221-pcie-qcom-bridge-dts-v1-0-6c6df0f9450d@linaro.org> <20240221-pcie-qcom-bridge-dts-v1-9-6c6df0f9450d@linaro.org> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20240221-pcie-qcom-bridge-dts-v1-9-6c6df0f9450d@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21.02.2024 04:41, Manivannan Sadhasivam wrote: > On Qcom SoCs, the PCIe host bridge is connected to a single PCIe bridge > for each controller instance. Hence, add a node to represent the bridge. > > While at it, let's remove the bridge properties from board dts as they are > now redundant. > > Signed-off-by: Manivannan Sadhasivam > --- > .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 8 ----- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 40 ++++++++++++++++++++++ > 2 files changed, 40 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index def3976bd5bb..f0a0115e08fa 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -733,14 +733,6 @@ &pcie4 { > status = "okay"; > > pcie@0 { > - device_type = "pci"; > - reg = <0x0 0x0 0x0 0x0 0x0>; > - #address-cells = <3>; > - #size-cells = <2>; > - ranges; > - > - bus-range = <0x01 0xff>; > - > wifi@0 { This doesn't seem right, pleas use a label Konrad