From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
benl@squareup.com, shawn.guo@linaro.org,
fabien.parent@linaro.org, leo.yan@linaro.org,
dmitry.baryshkov@linaro.org, Jun Nie <jun.nie@linaro.org>,
James Willcox <jwillcox@squareup.com>,
Joseph Gates <jgates@squareup.com>, Max Chen <mchen@squareup.com>,
Zac Crosby <zac@squareup.com>
Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: Add Square apq8039-t2 board
Date: Tue, 3 Jan 2023 10:17:55 +0100 [thread overview]
Message-ID: <9d8b0fca-2806-e405-f643-8a57bd55ffb8@linaro.org> (raw)
In-Reply-To: <20230103010904.3201835-7-bryan.odonoghue@linaro.org>
On 03/01/2023 02:09, Bryan O'Donoghue wrote:
> The apq8039-t2 is an apq8039 based board paired with a wcn3680b WiFi
> chipset.
>
> Co-developed-by: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Co-developed-by: Jun Nie <jun.nie@linaro.org>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> Co-developed-by: Benjamin Li <benl@squareup.com>
(...)
> +
> +&blsp_i2c2 {
> + status = "okay";
> +};
> +
> +&blsp_i2c3 {
> + status = "okay";
Blank line.
> + tps6598x: tps6598x@38 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,tps6598x";
> + reg = <0x38>;
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-03 9:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 1:08 [PATCH v2 0/7] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-01-03 1:08 ` [PATCH v2 1/7] dt-bindings: interconnect: Move interconnect child node definition Bryan O'Donoghue
2023-01-03 9:02 ` Krzysztof Kozlowski
2023-01-03 1:08 ` [PATCH v2 2/7] dt-bindings: arm: qcom: Document MSM8939 SoC binding Bryan O'Donoghue
2023-01-03 9:04 ` Krzysztof Kozlowski
2023-01-03 1:09 ` [PATCH v2 3/7] dt-bindings: soc: qcom: smd-rpm: Exclude MSM8936 from glink-channels Bryan O'Donoghue
2023-01-03 9:04 ` Krzysztof Kozlowski
2023-01-03 9:19 ` Krzysztof Kozlowski
2023-01-03 1:09 ` [PATCH v2 4/7] arm64: dts: qcom: Add msm8939 SoC Bryan O'Donoghue
2023-01-03 2:16 ` Konrad Dybcio
2023-01-03 2:32 ` Konrad Dybcio
2023-01-03 9:14 ` Krzysztof Kozlowski
2023-01-10 13:14 ` Bryan O'Donoghue
2023-01-10 13:24 ` Krzysztof Kozlowski
2023-01-10 13:42 ` Bryan O'Donoghue
2023-01-10 14:47 ` Konrad Dybcio
2023-01-11 9:12 ` Krzysztof Kozlowski
2023-01-03 9:16 ` Krzysztof Kozlowski
2023-01-03 1:09 ` [PATCH v2 5/7] arm64: dts: qcom: Add msm8939-pm8916.dtsi include Bryan O'Donoghue
2023-01-03 1:09 ` [PATCH v2 6/7] arm64: dts: qcom: Add Square apq8039-t2 board Bryan O'Donoghue
2023-01-03 2:22 ` Konrad Dybcio
2023-01-03 9:17 ` Krzysztof Kozlowski [this message]
2023-01-03 1:09 ` [PATCH v2 7/7] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
2023-01-03 2:29 ` Konrad Dybcio
2023-01-03 11:19 ` Bryan O'Donoghue
2023-01-03 9:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8b0fca-2806-e405-f643-8a57bd55ffb8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benl@squareup.com \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabien.parent@linaro.org \
--cc=jgates@squareup.com \
--cc=jun.nie@linaro.org \
--cc=jwillcox@squareup.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchen@squareup.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=zac@squareup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).