From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D629DC46467 for ; Tue, 3 Jan 2023 09:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237140AbjACJSA (ORCPT ); Tue, 3 Jan 2023 04:18:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237136AbjACJR6 (ORCPT ); Tue, 3 Jan 2023 04:17:58 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73FDBE028 for ; Tue, 3 Jan 2023 01:17:57 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id p36so44816692lfa.12 for ; Tue, 03 Jan 2023 01:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B9Wv3FdFZUA8KrBGuSYP/aqmUGr0c3p246TWkk0lSEw=; b=BScJBbEP3xsvpBGOF+42qKUXZnbwU6kdalonSqYyRk+bjVotSjVe43xZL7KKmoTB3k vAIlOfSrGmuHfnUdBf2UanB0aF49xzBejuNPWS9zACsLduFVikc6ncjchZjbuICRsCfL SqWJZRwlyvOw68mJkuK8Rskc+yp9cRwcou3mJ1PEXt77Wd0jWcyOt4YoB3fmd0PQMV8x 0dMQNjEDmnJV37yOIhbGIidz0I9S31ElOfQrbxsMMEcGRteaWsREEzXJu+FPv029LmSH DcRJwUsOxJ3uFTvHRdle8slsonugd7SMT4Y4s47++ZKN4TKdz9VG378kR7W5UiAsNQAC Mt9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B9Wv3FdFZUA8KrBGuSYP/aqmUGr0c3p246TWkk0lSEw=; b=Eb/WWGTLPFKv9L3Z3dpp84/ZGXdyioaI5jXpFzTz2ftyanRYzsd6t4QmIXh75aUYkR VoZZOKKU8xs6z/WTiVQ7mgLLjY7GaMMgm7BIi7F6c40nrqOQXjqQYNCD72PjUKQPMXAS feXT1tqzF60CBBUFkjrjc1djPkWlGcb/g32qX5dLYrWKu2sJnAHmeEqa8NjfJOHyK4t6 qQfLv13jBAvW0yuaquw/X3SLOf5y93fdLLBg7qKZBCzyYTrfQe+ppVZsqlh8c2yLQzdJ Ef7saxpYQGm2COlCo4DC3dhWOdEVqyVt5YP/IYLT+DdqwCicT5Znyhc0afKHPd/Or1VW mvpw== X-Gm-Message-State: AFqh2koXpOn5/ybZqAPKxJaQ3kj1A3FQVlxRWKcyIeMrRiVIzKlPVtuv QaVWxD56wug7/nimseboy/mY3/iyaOozTBXo X-Google-Smtp-Source: AMrXdXuR7LoWumsRY5WP6eNKvUecQts2oGh+/OUbygbiKZyvAzR2uYKF7qlfpaZWszYPdncbwTdHDQ== X-Received: by 2002:a05:6512:2624:b0:4cb:42ad:e895 with SMTP id bt36-20020a056512262400b004cb42ade895mr129068lfb.32.1672737477043; Tue, 03 Jan 2023 01:17:57 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id q16-20020a194310000000b004b5634f9b9dsm4804805lfa.115.2023.01.03.01.17.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 01:17:56 -0800 (PST) Message-ID: <9d8b0fca-2806-e405-f643-8a57bd55ffb8@linaro.org> Date: Tue, 3 Jan 2023 10:17:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: Add Square apq8039-t2 board Content-Language: en-US To: Bryan O'Donoghue , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, benl@squareup.com, shawn.guo@linaro.org, fabien.parent@linaro.org, leo.yan@linaro.org, dmitry.baryshkov@linaro.org, Jun Nie , James Willcox , Joseph Gates , Max Chen , Zac Crosby References: <20230103010904.3201835-1-bryan.odonoghue@linaro.org> <20230103010904.3201835-7-bryan.odonoghue@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230103010904.3201835-7-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/01/2023 02:09, Bryan O'Donoghue wrote: > The apq8039-t2 is an apq8039 based board paired with a wcn3680b WiFi > chipset. > > Co-developed-by: Shawn Guo > Signed-off-by: Shawn Guo > Co-developed-by: Jun Nie > Signed-off-by: Jun Nie > Co-developed-by: Benjamin Li (...) > + > +&blsp_i2c2 { > + status = "okay"; > +}; > + > +&blsp_i2c3 { > + status = "okay"; Blank line. > + tps6598x: tps6598x@38 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "ti,tps6598x"; > + reg = <0x38>; > + Best regards, Krzysztof