From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
krzysztof.kozlowski+dt@linaro.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org, linux@armlinux.org.uk,
vladimir.oltean@nxp.com, grygorii.strashko@ti.com,
vigneshr@ti.com, nsekhar@ti.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kishon@ti.com
Subject: Re: [PATCH v4 1/3] dt-bindings: net: ti: k3-am654-cpsw-nuss: Update bindings for J7200 CPSW5G
Date: Fri, 19 Aug 2022 15:04:50 +0300 [thread overview]
Message-ID: <9d9c2f78-db3e-71aa-2cdd-e2d9aa2b30cf@linaro.org> (raw)
In-Reply-To: <0ca78aad-2145-c88b-a26e-9ababa38df6e@ti.com>
On 19/08/2022 13:43, Siddharth Vadapalli wrote:
>>>> Anyway the location is not correct. Regardless if this is if-then or
>>>> allOf-if-then, put it just like example schema is suggesting.
>>>
>>> I will move the if-then statements to the lines above the
>>> "additionalProperties: false" line. Also, I will add an allOf for this
>>
>> I had a look at the example at [1] and it uses allOf after the
>> "additionalProperties: false" line. Would it be fine then for me to add
>> allOf and the single if-then statement below the "additionalProperties:
>> false" line? Please let me know.
>>
>> [1] -> https://github.com/devicetree-org/dt-schema/blob/mai/test/schemas/conditionals-allof-example.yaml
>
> Sorry, the correct link is:
> https://github.com/devicetree-org/dt-schema/blob/main/test/schemas/conditionals-allof-example.yaml
You are referring to tests? I did not suggest that. Please put it in
place like example schema is suggesting:
https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/example-schema.yaml
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-19 12:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 6:01 [PATCH v4 0/3] J7200: CPSW5G: Add support for QSGMII mode to am65-cpsw driver Siddharth Vadapalli
2022-08-16 6:01 ` [PATCH v4 1/3] dt-bindings: net: ti: k3-am654-cpsw-nuss: Update bindings for J7200 CPSW5G Siddharth Vadapalli
2022-08-16 7:44 ` Krzysztof Kozlowski
2022-08-17 5:14 ` Siddharth Vadapalli
2022-08-17 5:50 ` Krzysztof Kozlowski
2022-08-17 7:41 ` Siddharth Vadapalli
2022-08-19 10:29 ` Siddharth Vadapalli
2022-08-19 10:43 ` Siddharth Vadapalli
2022-08-19 12:04 ` Krzysztof Kozlowski [this message]
2022-08-22 4:13 ` Siddharth Vadapalli
2022-08-16 6:01 ` [PATCH v4 2/3] net: ethernet: ti: am65-cpsw: Add support " Siddharth Vadapalli
2022-08-16 6:01 ` [PATCH v4 3/3] net: ethernet: ti: am65-cpsw: Move phy_set_mode_ext() to correct location Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d9c2f78-db3e-71aa-2cdd-e2d9aa2b30cf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).