From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: k.son@samsung.com, p.zabel@pengutronix.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jszhang@kernel.org, guoren@kernel.org, wefu@redhat.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, inki.dae@samsung.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: reset: Document th1520 reset control
Date: Tue, 12 Sep 2023 09:04:47 +0200 [thread overview]
Message-ID: <9da4efe6-bbff-62af-8d05-b05cf12a4c31@linaro.org> (raw)
In-Reply-To: <20230912024914.3769440-2-k.son@samsung.com>
On 12/09/2023 04:49, k.son@samsung.com wrote:
> From: Kwanghoon Son <k.son@samsung.com>
>
> Add documentation to describe th1520 reset device
Full stop.
>
> Signed-off-by: Kwanghoon Son <k.son@samsung.com>
This is v2, not v1. Please provide changelog after ---.
> ---
> .../bindings/reset/thead,th1520-reset.yaml | 47 +++++++++++++++++++
> include/dt-bindings/reset/th1520-reset.h | 9 ++++
> 2 files changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml
> create mode 100644 include/dt-bindings/reset/th1520-reset.h
>
> diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml
> new file mode 100644
> index 000000000000..6724a9ccdd55
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/thead,th1520-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: T-HEAD th1520 SoC Reset Controller
> +
> +maintainers:
> + - Kwanghoon Son <k.son@samsung.com>
> +
> +allOf:
> + - $ref: /schemas/mfd/syscon.yaml#
Why do you need it? Which existing file suggested such code?
> +
> +properties:
> + compatible:
> + items:
> + - const: thead,th1520-reset
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + '#reset-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - '#reset-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/reset/th1520-reset.h>
> +
> + soc {
> + #address-cells = <2>;
Your indentation is messed up. Here two spaces, further four. Just keep
one indentation for the example - 4 spaces.
> + #size-cells = <2>;
> +
> + reset-controller@ffef014000 {
> + compatible = "thead,th1520-reset", "syscon";
> + reg = <0xff 0xef014000 0x0 0x1000>;
> + #reset-cells = <1>;
> + };
> + };
> diff --git a/include/dt-bindings/reset/th1520-reset.h b/include/dt-bindings/reset/th1520-reset.h
> new file mode 100644
> index 000000000000..ec10751814e5
> --- /dev/null
> +++ b/include/dt-bindings/reset/th1520-reset.h
Filename matching bindings/compatible - missing vendor prefix.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-12 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230912024917epcas1p29a513dcf6019fb7c63275aa0e39b1c71@epcas1p2.samsung.com>
2023-09-12 2:49 ` [PATCH 0/3] Introduce reset driver for T-HEAD th1520 SoC k.son
[not found] ` <CGME20230912024917epcas1p4bb4d649f97b592c3245b10b6450d32cf@epcas1p4.samsung.com>
2023-09-12 2:49 ` [PATCH 1/3] dt-bindings: reset: Document th1520 reset control k.son
2023-09-12 7:04 ` Krzysztof Kozlowski [this message]
[not found] ` <CGME20230912024917epcas1p26c59f79ab6904823417d625d6a711d36@epcas1p2.samsung.com>
2023-09-12 2:49 ` [PATCH 2/3] reset: Add th1520 reset driver support k.son
[not found] ` <CGME20230912024917epcas1p2076a3a0674ae94e8c8641cc9eb617eac@epcas1p2.samsung.com>
2023-09-12 2:49 ` [PATCH 3/3] riscv: dts: Add th1520 reset device tree k.son
2023-09-12 7:05 ` Krzysztof Kozlowski
2023-09-12 3:16 ` [PATCH 0/3] Introduce reset driver for T-HEAD th1520 SoC Kwanghoon Son
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9da4efe6-bbff-62af-8d05-b05cf12a4c31@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=inki.dae@samsung.com \
--cc=jszhang@kernel.org \
--cc=k.son@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).