From: Krzysztof Kozlowski <krzk@kernel.org>
To: Thomas Marangoni <Thomas.Marangoni@becom-group.com>,
linux-hwmon@vger.kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux@roeck-us.net, corbet@lwn.net, Jonathan.Cameron@huawei.com,
Frank.Li@nxp.com, michal.simek@amd.com,
rodrigo.gobbi.7@gmail.com, chou.cosmo@gmail.com,
wenswang@yeah.net, nuno.sa@analog.com, paweldembicki@gmail.com,
apokusinski01@gmail.com, eajames@linux.ibm.com,
vassilisamir@gmail.com, heiko@sntech.de,
neil.armstrong@linaro.org,
prabhakar.mahadev-lad.rj@bp.renesas.com,
kever.yang@rock-chips.com, mani@kernel.org, dev@kael-k.io,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: Add tids in bindings and wsen as vendor
Date: Mon, 17 Nov 2025 17:33:43 +0100 [thread overview]
Message-ID: <9da933d7-0922-47fe-9e7a-f7ef2d89803a@kernel.org> (raw)
In-Reply-To: <20251117123809.47488-4-Thomas.Marangoni@becom-group.com>
On 17/11/2025 13:38, Thomas Marangoni wrote:
> This patch adds the tids driver to the bindings as trivial-devices
> and adds the WSEN manufacturer to the vendor-prefixes.
> ---
You need to run checkpatch...
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
Also, do not reference driver. Explain here hardware, why this is a
trivial device.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-17 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 12:38 [PATCH 0/4] hwmon: Add driver for wsen tids-2521020222501 Thomas Marangoni
2025-11-17 12:38 ` [PATCH 1/4] " Thomas Marangoni
2025-11-17 16:24 ` Guenter Roeck
2025-11-19 10:40 ` Thomas Marangoni
2025-11-17 12:38 ` [PATCH 2/4] hwmon: documentation: add tids Thomas Marangoni
2025-11-17 16:31 ` Guenter Roeck
2025-11-17 12:38 ` [PATCH 3/4] dt-bindings: Add tids in bindings and wsen as vendor Thomas Marangoni
2025-11-17 16:27 ` Guenter Roeck
2025-11-17 16:33 ` Krzysztof Kozlowski [this message]
2025-11-17 12:38 ` [PATCH 4/4] MAINTAINERS: Add tids driver as maintained Thomas Marangoni
2025-11-17 16:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9da933d7-0922-47fe-9e7a-f7ef2d89803a@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Thomas.Marangoni@becom-group.com \
--cc=apokusinski01@gmail.com \
--cc=chou.cosmo@gmail.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=dev@kael-k.io \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=heiko@sntech.de \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mani@kernel.org \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=paweldembicki@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=rodrigo.gobbi.7@gmail.com \
--cc=vassilisamir@gmail.com \
--cc=wenswang@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).