From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: qcom,spmi-vadc: fix PM8350 define
Date: Thu, 17 Nov 2022 17:21:25 +0100 [thread overview]
Message-ID: <9ddf7e56-f396-5720-9960-e3ef4aa9a204@linaro.org> (raw)
In-Reply-To: <20221117155658.00005d08@Huawei.com>
On 17/11/2022 16:56, Jonathan Cameron wrote:
> On Thu, 17 Nov 2022 13:28:33 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> On 17/11/2022 13:22, Manivannan Sadhasivam wrote:
>>> On Thu, Nov 17, 2022 at 01:13:07PM +0100, Krzysztof Kozlowski wrote:
>>>> The defines from include/dt-bindings/iio/qcom,spmi-adc7-pm8350.h were
>>>> changed to take sid argument:
>>>>
>>>> Error: Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.example.dts:99.28-29 syntax error
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> Looks like I didn't rebase on top of Bjorn's for-next for my series, so didn't
>>> see this example.
>>>
>>> Thanks for fixing!
>>>
>>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>>
>>
>> This should not go via Bjorn's tree without IIO ack and
>> Jonathan/Lars-Peter/IIO lists were not in CC.
>>
> Thanks for the heads up.
>
> Not sure I'd have registered there would have been a problem here even
> if I had seen original patch. Anyhow, I assume Bjorn will pick this up
> and all will be well again.
>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
I am afraid it cannot go via Bjorn's tree, because this depends on a
change in your tree:
https://lore.kernel.org/all/20221027143411.277980-2-krzysztof.kozlowski@linaro.org/
Can you pick it up instead? This is the only way to fix the linux-next,
although your tree will have a dt_binding_check error.
Other way is to have cross-tree merge, but the commit to bindings
headers ended up in DTS patch, so it cannot be shared with driver tree.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-17 16:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 12:13 [PATCH] dt-bindings: iio: adc: qcom,spmi-vadc: fix PM8350 define Krzysztof Kozlowski
2022-11-17 12:22 ` Manivannan Sadhasivam
2022-11-17 12:28 ` Krzysztof Kozlowski
2022-11-17 15:56 ` Jonathan Cameron
2022-11-17 16:21 ` Krzysztof Kozlowski [this message]
2022-11-17 16:58 ` Jonathan Cameron
2022-11-17 17:06 ` Krzysztof Kozlowski
2022-12-05 23:36 ` Rob Herring
2022-12-06 18:13 ` Bjorn Andersson
2022-12-06 18:19 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ddf7e56-f396-5720-9960-e3ef4aa9a204@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).