* [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator
@ 2023-11-11 9:56 Krzysztof Kozlowski
2023-11-11 9:56 ` [PATCH 2/2] arm64: dts: qcom: sdm845: correct Soundwire node name Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-11 9:56 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Vivek Gautam,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
There is no "panic-indicator" default trigger but a property with that
name:
sdm845-db845c.dtb: leds: led-0: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index c7eba6c491be..7e7bf3fb3be6 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -67,8 +67,8 @@ led-0 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_GREEN>;
gpios = <&pm8998_gpios 13 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "panic-indicator";
default-state = "off";
+ panic-indicator;
};
led-1 {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sdm845: correct Soundwire node name
2023-11-11 9:56 [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator Krzysztof Kozlowski
@ 2023-11-11 9:56 ` Krzysztof Kozlowski
2023-11-14 7:33 ` Vinod Koul
2023-11-15 16:20 ` Konrad Dybcio
2023-11-15 16:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator Konrad Dybcio
2023-12-08 2:57 ` (subset) " Bjorn Andersson
2 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-11 9:56 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Vivek Gautam,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Soundwire Devicetree bindings expect the Soundwire controller device
node to be named just "soundwire":
sdm845-db845c.dtb: swm@c85: $nodename:0: 'swm@c85' does not match '^soundwire(@.*)?$'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
arch/arm64/boot/dts/qcom/sdm845-wcd9340.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 +-
arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index 7e7bf3fb3be6..ab6220456513 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -1130,7 +1130,7 @@ &wcd9340 {
vdd-rx-supply = <&vreg_s4a_1p8>;
vdd-io-supply = <&vreg_s4a_1p8>;
- swm: swm@c85 {
+ swm: soundwire@c85 {
left_spkr: speaker@0,1 {
compatible = "sdw10217201000";
reg = <0 1>;
diff --git a/arch/arm64/boot/dts/qcom/sdm845-wcd9340.dtsi b/arch/arm64/boot/dts/qcom/sdm845-wcd9340.dtsi
index c15d48860646..6172cd1539e6 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-wcd9340.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-wcd9340.dtsi
@@ -54,7 +54,7 @@ wcdgpio: gpio-controller@42 {
reg = <0x42 0x2>;
};
- swm: swm@c85 {
+ swm: soundwire@c85 {
compatible = "qcom,soundwire-v1.3.0";
reg = <0xc85 0x40>;
interrupts-extended = <&wcd9340 20>;
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index 92a812b5f423..41a3c2dbc2f7 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -797,7 +797,7 @@ &wcd9340 {
qcom,mbhc-headset-vthreshold-microvolt = <1700000>;
qcom,mbhc-headphone-vthreshold-microvolt = <50000>;
- swm: swm@c85 {
+ swm: soundwire@c85 {
left_spkr: speaker@0,3 {
compatible = "sdw10217211000";
reg = <0 3>;
diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
index 543837316001..26217836c270 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
@@ -658,7 +658,7 @@ &wcd9340 {
qcom,mbhc-headset-vthreshold-microvolt = <1700000>;
qcom,mbhc-headphone-vthreshold-microvolt = <50000>;
- swm: swm@c85 {
+ swm: soundwire@c85 {
left_spkr: speaker@0,3 {
compatible = "sdw10217211000";
reg = <0 3>;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sdm845: correct Soundwire node name
2023-11-11 9:56 ` [PATCH 2/2] arm64: dts: qcom: sdm845: correct Soundwire node name Krzysztof Kozlowski
@ 2023-11-14 7:33 ` Vinod Koul
2023-11-15 16:20 ` Konrad Dybcio
1 sibling, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2023-11-14 7:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Vivek Gautam, linux-arm-msm,
devicetree, linux-kernel
On 11-11-23, 10:56, Krzysztof Kozlowski wrote:
> Soundwire Devicetree bindings expect the Soundwire controller device
> node to be named just "soundwire":
>
> sdm845-db845c.dtb: swm@c85: $nodename:0: 'swm@c85' does not match '^soundwire(@.*)?$'
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator
2023-11-11 9:56 [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator Krzysztof Kozlowski
2023-11-11 9:56 ` [PATCH 2/2] arm64: dts: qcom: sdm845: correct Soundwire node name Krzysztof Kozlowski
@ 2023-11-15 16:19 ` Konrad Dybcio
2023-12-08 2:57 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-11-15 16:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Vivek Gautam,
linux-arm-msm, devicetree, linux-kernel
On 11/11/23 10:56, Krzysztof Kozlowski wrote:
> There is no "panic-indicator" default trigger but a property with that
> name:
>
> sdm845-db845c.dtb: leds: led-0: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
>
> Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sdm845: correct Soundwire node name
2023-11-11 9:56 ` [PATCH 2/2] arm64: dts: qcom: sdm845: correct Soundwire node name Krzysztof Kozlowski
2023-11-14 7:33 ` Vinod Koul
@ 2023-11-15 16:20 ` Konrad Dybcio
1 sibling, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-11-15 16:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Vivek Gautam,
linux-arm-msm, devicetree, linux-kernel
On 11/11/23 10:56, Krzysztof Kozlowski wrote:
> Soundwire Devicetree bindings expect the Soundwire controller device
> node to be named just "soundwire":
>
> sdm845-db845c.dtb: swm@c85: $nodename:0: 'swm@c85' does not match '^soundwire(@.*)?$'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator
2023-11-11 9:56 [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator Krzysztof Kozlowski
2023-11-11 9:56 ` [PATCH 2/2] arm64: dts: qcom: sdm845: correct Soundwire node name Krzysztof Kozlowski
2023-11-15 16:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator Konrad Dybcio
@ 2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-12-08 2:57 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Vinod Koul, Vivek Gautam, linux-arm-msm, devicetree,
linux-kernel, Krzysztof Kozlowski
On Sat, 11 Nov 2023 10:56:16 +0100, Krzysztof Kozlowski wrote:
> There is no "panic-indicator" default trigger but a property with that
> name:
>
> sdm845-db845c.dtb: leds: led-0: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
>
>
Applied, thanks!
[1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator
commit: 0c90c75e663246203a2b7f6dd9e08a110f4c3c43
[2/2] arm64: dts: qcom: sdm845: correct Soundwire node name
commit: 74eed6f467db53b9b8b7fb225f6ac475449ad073
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-08 2:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-11 9:56 [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator Krzysztof Kozlowski
2023-11-11 9:56 ` [PATCH 2/2] arm64: dts: qcom: sdm845: correct Soundwire node name Krzysztof Kozlowski
2023-11-14 7:33 ` Vinod Koul
2023-11-15 16:20 ` Konrad Dybcio
2023-11-15 16:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct LED panic indicator Konrad Dybcio
2023-12-08 2:57 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).