From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD84C4332F for ; Tue, 26 Apr 2022 20:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236617AbiDZUYP (ORCPT ); Tue, 26 Apr 2022 16:24:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355106AbiDZUX7 (ORCPT ); Tue, 26 Apr 2022 16:23:59 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB6F2E09B for ; Tue, 26 Apr 2022 13:20:49 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id bu29so33978305lfb.0 for ; Tue, 26 Apr 2022 13:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=VeBTftEEBF4n+zC0W35RUFpsE8vBxIydsA294RvLU5U=; b=dlhxKFfKur1lHnoc+nbcJrk/Ps0SWozlkk+0HPMTatI/NQMMwJL97BQUiNcOD1Oeal QJFuApixc8IRyxFPLyP+BkDzQ93RcLLBvE+fLc5XlngnHHm7zZj9ZVsF/Ux911ZFApTs JkOSiOYqFhFTtgTn9U409Kg+DUTgRLSPwlo7Ec2bYU+Ud25CayZOhieuTzzfuO4HRZ50 7NqNtvaJkgMIHRkHtHFZ4WGpOoo8PoPz2HgO8KGfORMmLHNp0ml0W4D/vBKCsWAbBXJz Hvuy2gj4XX0W6SPDVMkAXjJUtb4YYIrBSxtyrDWyNEk8A3IkLu9CJ823W5eMLVLCTbQj ky5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VeBTftEEBF4n+zC0W35RUFpsE8vBxIydsA294RvLU5U=; b=d3Ew2rsn4WyyD73nmh0X21JKnhjtnbnwLswi7p7JAnWhl+1TiZn6PYkLph3rvEuiua +rHzNukR/NBSSiGKMw19E58eaHDJuwN9giUscijbOvCjhkobLV0sG59xXxvpHswafbsE p5+0hTqcwiyCaQPeDzsKuVxcLnNxcqL28n7s5OGG9S9wc183o5AgIGi464CUb0UBeSDX pG550/R30PhaB35Qb8igFb2/w2rtoWKAUXc7/RzePH/QfYpErue2cCS0+1+EcLPw/C/Y xNfFMf11O+q6eM3g0LjFZpMMovYHrw4kXQh2oEkUwhuFqqczYStRez6WBOKN13RddcJD stjw== X-Gm-Message-State: AOAM532xLYiVREgm7f4j8NjxKiCxlOoZa/u2HuPi0ryv5tZRGy1Zdl9I 9H23OTEEbp131HjfQBVPiHgKKw== X-Google-Smtp-Source: ABdhPJzwQe3J31B9Au3qGIefBxGSsd11mJQrRCRg4tWK2TaU2RtYfE+qhsPAOoHHBkhMiyRJxa92GA== X-Received: by 2002:a19:ac42:0:b0:448:1f15:4b18 with SMTP id r2-20020a19ac42000000b004481f154b18mr17762502lfc.32.1651004448075; Tue, 26 Apr 2022 13:20:48 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id m1-20020a2e7101000000b0024f081cb0absm1169380ljc.83.2022.04.26.13.20.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 13:20:47 -0700 (PDT) Message-ID: <9df0eb75-0b2c-446e-ef66-1eb3ce442d0d@linaro.org> Date: Tue, 26 Apr 2022 23:20:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 3/3] dt-bindings: clock: qcom,gcc-apq8064: split tsens to the child node Content-Language: en-GB To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Amit Kucheria , Thara Gopinath , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, quic_tdas@quicinc.com References: <20220426094144.2958416-1-dmitry.baryshkov@linaro.org> <20220426094144.2958416-4-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/04/2022 21:24, Rob Herring wrote: > On Tue, Apr 26, 2022 at 12:41:44PM +0300, Dmitry Baryshkov wrote: >> Split tsens properties to the child node of the gcc. This follows the >> lead of ipq8064 (which also uses a separate node for tsens) and makes >> device tree closer to other platforms, where tsens is a completely >> separate device. >> >> Signed-off-by: Dmitry Baryshkov >> --- >> .../bindings/clock/qcom,gcc-apq8064.yaml | 45 +++++++------------ >> 1 file changed, 17 insertions(+), 28 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml >> index b867da12761e..f2762599f679 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml >> @@ -23,47 +23,36 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - qcom,gcc-apq8064 >> - - qcom,gcc-msm8060 >> - >> - nvmem-cells: >> - minItems: 1 >> - maxItems: 2 >> - description: >> - Qualcomm TSENS (thermal sensor device) on some devices can >> - be part of GCC and hence the TSENS properties can also be part >> - of the GCC/clock-controller node. >> - For more details on the TSENS properties please refer >> - Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> - >> - nvmem-cell-names: >> - minItems: 1 >> items: >> - - const: calib >> - - const: calib_backup >> - >> - '#thermal-sensor-cells': >> - const: 1 >> + - enum: >> + - qcom,gcc-apq8064 >> + - qcom,gcc-msm8060 >> + - const: syscon >> >> required: >> - compatible >> - - nvmem-cells >> - - nvmem-cell-names >> - - '#thermal-sensor-cells' >> >> unevaluatedProperties: false >> >> examples: >> - | >> clock-controller@900000 { >> - compatible = "qcom,gcc-apq8064"; >> + compatible = "qcom,gcc-apq8064", "syscon"; >> reg = <0x00900000 0x4000>; >> - nvmem-cells = <&tsens_calib>, <&tsens_backup>; >> - nvmem-cell-names = "calib", "calib_backup"; >> #clock-cells = <1>; >> #reset-cells = <1>; >> #power-domain-cells = <1>; >> - #thermal-sensor-cells = <1>; >> + >> + thermal-sensor { > > This should throw a warning I think as 'thermal-sensor' needs to be > defined. The patch didn't apply for me though. This series depends on https://lore.kernel.org/linux-arm-msm/20220426093608.2957210-1-dmitry.baryshkov@linaro.org/T/#u Regarding the warnings, I think this is related to the issue Krzyshtof has reported few days ago. I was not able to trigger warnings for unknown properties if unevaluatedProperties:false is used. > >> + compatible = "qcom,msm8960-tsens"; >> + >> + nvmem-cells = <&tsens_calib>, <&tsens_backup>; >> + nvmem-cell-names = "calib", "calib_backup"; >> + interrupts = <0 178 4>; >> + interrupt-names = "uplow"; >> + >> + #qcom,sensors = <11>; >> + #thermal-sensor-cells = <1>; >> + }; >> }; >> ... >> -- >> 2.35.1 >> >> -- With best wishes Dmitry