devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jason-ch Chen <jason-ch.chen@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>
Cc: "Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
	"Chen-Yu Tsai" <wenst@chromium.org>,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188
Date: Mon, 17 Jul 2023 21:55:17 +0200	[thread overview]
Message-ID: <9e46c996-3e3b-b437-f2c4-2ca86a1c7e6c@linaro.org> (raw)
In-Reply-To: <20230717120300.21388-4-jason-ch.chen@mediatek.com>

On 17/07/2023 14:02, Jason-ch Chen wrote:
> From: jason-ch chen <Jason-ch.Chen@mediatek.com>
> 
> Add MT8188 PMIC Wrapper compatible to binding document.

No improvements here - the compatible is already there. Subject has the
same issue. Explain what you are doing and why.

> 
> Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com>
> ---
>  .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml    | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index a06ac2177444..4737e5f45d54 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -41,7 +41,6 @@ properties:
>                - mediatek,mt8173-pwrap
>                - mediatek,mt8183-pwrap
>                - mediatek,mt8186-pwrap
> -              - mediatek,mt8188-pwrap

Look, here ^^^^

>                - mediatek,mt8195-pwrap
>                - mediatek,mt8365-pwrap
>                - mediatek,mt8516-pwrap
> @@ -50,6 +49,11 @@ properties:
>                - mediatek,mt8186-pwrap
>                - mediatek,mt8195-pwrap
>            - const: syscon
> +      - items:
> +          - enum:
> +              - mediatek,mt8188-pwrap


Best regards,
Krzysztof


  reply	other threads:[~2023-07-17 19:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 12:02 [PATCH v3 0/4] Add basic node support for MediaTek MT8188 SoC Jason-ch Chen
2023-07-17 12:02 ` [PATCH v3 1/4] dt-bindings: arm: Add compatible for MediaTek MT8188 Jason-ch Chen
2023-07-17 12:02 ` [PATCH v3 2/4] dt-bindings: arm: mediatek: Add mt8188 pericfg compatible Jason-ch Chen
2023-07-17 12:02 ` [PATCH v3 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188 Jason-ch Chen
2023-07-17 19:55   ` Krzysztof Kozlowski [this message]
2023-07-18  6:34     ` Jason-ch Chen (陳建豪)
2023-07-18  6:36       ` Krzysztof Kozlowski
2023-07-18  7:09         ` Jason-ch Chen (陳建豪)
2023-07-17 12:03 ` [PATCH v3 4/4] arm64: dts: Add MediaTek MT8188 dts and evaluation board and Makefile Jason-ch Chen
2023-07-17 19:58   ` Krzysztof Kozlowski
2023-07-18  6:36     ` Jason-ch Chen (陳建豪)
2023-07-18  7:41       ` Krzysztof Kozlowski
2023-07-18  8:05         ` Jason-ch Chen (陳建豪)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e46c996-3e3b-b437-f2c4-2ca86a1c7e6c@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jason-ch.chen@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).