From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Praveenkumar I <quic_ipkumar@quicinc.com>,
agross@kernel.org, andersson@kernel.org, vkoul@kernel.org,
kishon@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
gregkh@linuxfoundation.org, catalin.marinas@arm.com,
will@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be,
arnd@arndb.de, neil.armstrong@linaro.org,
nfraprado@collabora.com, u-kumar1@ti.com, peng.fan@nxp.com,
quic_wcheng@quicinc.com, quic_varada@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: quic_kathirav@quicinc.com, quic_nsekar@quicinc.com,
quic_srichara@quicinc.com
Subject: Re: [PATCH 3/8] arm64: dts: qcom: ipq5332: Add USB Super-Speed PHY node
Date: Fri, 29 Sep 2023 14:56:25 +0200 [thread overview]
Message-ID: <9e5ad332-2c04-4024-8321-3a9c66586b64@linaro.org> (raw)
In-Reply-To: <20230929084209.3033093-4-quic_ipkumar@quicinc.com>
On 29.09.2023 10:42, Praveenkumar I wrote:
> Add USB Super-Speed UNIPHY node and populate the phandle on
> gcc node for the parent clock map.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 25 ++++++++++++++++++++++++-
> 1 file changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index d3fef2f80a81..b08ffd8c094e 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -158,6 +158,29 @@ usbphy0: phy@7b000 {
> status = "disabled";
> };
>
> + usbphy1: phy@4b0000 {
> + compatible = "qcom,ipq5332-usb-uniphy";
> + reg = <0x4b0000 0x800>;
Please pad the address part to 8 hex digits with leading zeroes.
> +
> + clocks = <&gcc GCC_PCIE3X1_PHY_AHB_CLK>,
> + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>,
> + <&gcc GCC_USB0_PIPE_CLK>;
> + clock-names = "ahb",
> + "cfg_ahb",
> + "pipe";
> +
> + resets = <&gcc GCC_USB0_PHY_BCR>;
Looks like there's a double space after '='
Konrad
next prev parent reply other threads:[~2023-09-29 12:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 8:42 [PATCH 0/8] Enable USB3 for Qualcomm IPQ5332 Praveenkumar I
2023-09-29 8:42 ` [PATCH 1/8] dt-bindings: phy: qcom,uniphy-usb: Document qcom,uniphy-usb phy Praveenkumar I
2023-09-30 14:56 ` Krzysztof Kozlowski
2023-10-03 14:09 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 2/8] phy: qcom: Introduce Super-Speed USB UNIPHY driver Praveenkumar I
2023-09-30 17:18 ` Dmitry Baryshkov
2023-10-03 14:21 ` Praveenkumar I
2023-10-03 14:54 ` Dmitry Baryshkov
2023-10-03 16:33 ` Praveenkumar I
2023-10-06 23:57 ` Konrad Dybcio
2023-10-09 12:22 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 3/8] arm64: dts: qcom: ipq5332: Add USB Super-Speed PHY node Praveenkumar I
2023-09-29 12:56 ` Konrad Dybcio [this message]
2023-09-29 13:30 ` Praveenkumar I
2023-09-30 17:22 ` Dmitry Baryshkov
2023-10-03 14:28 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 4/8] dt-bindings: usb: dwc3: Add clocks on Qualcomm IPQ5332 Praveenkumar I
2023-09-30 14:58 ` Krzysztof Kozlowski
2023-09-30 17:23 ` Dmitry Baryshkov
2023-10-03 14:30 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 5/8] arm64: dts: qcom: ipq5332: Add clocks for USB Super-Speed Praveenkumar I
2023-09-30 17:25 ` Dmitry Baryshkov
2023-10-03 14:42 ` Praveenkumar I
2023-10-03 14:45 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in USB node Praveenkumar I
2023-09-29 13:14 ` Konrad Dybcio
2023-09-29 13:31 ` Praveenkumar I
2023-09-30 17:26 ` Dmitry Baryshkov
2023-10-03 14:02 ` Praveenkumar I
2023-09-30 17:27 ` Dmitry Baryshkov
2023-10-03 14:42 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 7/8] arm64: dts: qcom: ipq5332: Enable USB Super-Speed PHY Praveenkumar I
2023-09-29 8:42 ` [PATCH 8/8] arm64: defconfig: Enable qcom USB UNIPHY driver Praveenkumar I
2023-09-30 14:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e5ad332-2c04-4024-8321-3a9c66586b64@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).