From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15837C54EED for ; Mon, 23 Jan 2023 16:29:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232002AbjAWQ33 (ORCPT ); Mon, 23 Jan 2023 11:29:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232051AbjAWQ31 (ORCPT ); Mon, 23 Jan 2023 11:29:27 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 145A92A9AD for ; Mon, 23 Jan 2023 08:29:26 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id 18so15203434edw.7 for ; Mon, 23 Jan 2023 08:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QnI9gK1RE/xFPeiF67JBO03UXJnSe4HAgZlnhIo2fT8=; b=lGzKRehrYviynINTjrUw56QeQxwcOHWugpQVBuDkTuP7zf3a+WnHtvRWcud4bpErK+ eZ3dCED9L8dYqv4hxX5ywJKIiOKeK7ybjBLXQQL8Hp2NzSyrda1ovALv+HehedLJs/i6 P8HQvJRseK4QSXmD8nCcZmCvTS3rMlRZabCzXNL/WFiQYWYpe44OdSMcTywtujcCalRC gJRJfffvzoBICrA3RXJUtlsRyN6m3scEv+P0AngFWPjUB7Yx7qED2K0y9qqn0tQQGJJ6 W5noqYosOk7CMRsW/SVx+geIgk8IHf6+aJ7m/31TrS0G99liIGPkZ7PWGXax812yxnBa QkKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QnI9gK1RE/xFPeiF67JBO03UXJnSe4HAgZlnhIo2fT8=; b=uGk/vasyu9cV4626jBDfSVzNtlBn8cnK+qetcx99LC51kFzefObePtgAwbEolbhp9n S2WTqVwbeXlkalUzteFzQbmdNsLdgBaq6D03Fhj2z5zWESZ2Qvy/SstN6B9nx2DHlxc8 uxX7YwC5AzYKG/V9sh0Zoxy7sk5KzdO1J4ESOgZKqa6iDV51h2Hj/ETVfyjcSwk4Rn0y f4GgpediBusetJ0q8uwVkhsFMA1l3OuEBG1NnLNHl3SX7nA3Kk0d3IhV6Nk8O733rc9i 02X4dmKAWUA085++qDb2VOSQlygdzAPYfnfUyw/IARmDucJn68ZqteAKMWwZLdNdYfll xk4g== X-Gm-Message-State: AFqh2kq5vDXXswTGaYo3cAIhsNih4qOnAydy73s9U2wH6oI4mnlCwmpf hPufTlkWM59+asb6AGW4hch+yQ== X-Google-Smtp-Source: AMrXdXv62D+0kWD668M4VSNsQwQ7Zg3qF5p3+nxzuZbn14rakRNZm5NWFlyx0fFyQSPTqMyqC1JQQA== X-Received: by 2002:a05:6402:43ce:b0:461:2288:6808 with SMTP id p14-20020a05640243ce00b0046122886808mr27684361edc.21.1674491365637; Mon, 23 Jan 2023 08:29:25 -0800 (PST) Received: from [192.168.1.101] (abxi24.neoplus.adsl.tpnet.pl. [83.9.2.24]) by smtp.gmail.com with ESMTPSA id 24-20020a170906329800b0087190b479c4sm10922617ejw.43.2023.01.23.08.29.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 08:29:25 -0800 (PST) Message-ID: <9e69f980-658e-0f06-a2d6-893ad3637d3f@linaro.org> Date: Mon, 23 Jan 2023 17:29:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: sm8450: drop incorrect cells from serial Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , Vinod Koul , Neil Armstrong , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230123125612.154840-1-krzysztof.kozlowski@linaro.org> <20230123125612.154840-3-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20230123125612.154840-3-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23.01.2023 13:56, Krzysztof Kozlowski wrote: > The serial/UART device node does not have children with unit addresses, > so adderss/size cells are not correct. > > Fixes: f5837418479a ("arm64: dts: qcom: sm8450: add uart20 node") > Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI") > Signed-off-by: Krzysztof Kozlowski > > --- Reviewed-by: Konrad Dybcio Konrad > > Changes since v1: > 1. None > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index d66dcd8fe61f..395a3a156e24 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -1017,8 +1017,6 @@ uart20: serial@894000 { > pinctrl-names = "default"; > pinctrl-0 = <&qup_uart20_default>; > interrupts = ; > - #address-cells = <1>; > - #size-cells = <0>; > status = "disabled"; > }; > > @@ -1411,8 +1409,6 @@ uart7: serial@99c000 { > pinctrl-names = "default"; > pinctrl-0 = <&qup_uart7_tx>, <&qup_uart7_rx>; > interrupts = ; > - #address-cells = <1>; > - #size-cells = <0>; > status = "disabled"; > }; > };