From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D52351CF9C for ; Mon, 4 Mar 2024 21:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709586205; cv=none; b=AnBJFCiW1YwIhIKXDYL9pdxyHxoqg4JM57+ZlpB8d1jl0AnX9w3Fp4oCVLeA64VnN1exYbSp6rnA+xlft3i1daszo6k1URSIv8b6aAFMYFhHHz2169A9EKxJnZSlsLU6/fpDXAdzA8Csn/9WCZ5ATPr66BuH0cK1TsGiLzus+j8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709586205; c=relaxed/simple; bh=OOBr6oNTTFSsUJsbHGRPhYZJAleWvuaQK38mc3RQmb0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hqKkrCYIO14NYPOejv6ZSzxogTUJV0rv7WKGL8me3xA3gL706pb+b4tdnxGzEBwL+CQxc0XOiizoRtTR9L56NGdWg10vxJFks9KXnjF0MNcBr8+48lrSUEYjnQrf9TW55UM0HyHD8eaUuQcCxckhp0WiVgORvcGytFsGmfz8WVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=IxHRc6er; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="IxHRc6er" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Reply-To:Content-ID:Content-Description; bh=DmGb6+Q1mNlu6VCk7kl84rD0txL+0WYOa43KIKbfRL8=; b=IxHRc6erhiEl0McnvwpzI4K2t3 qjKHRlbrdHpIpFQiFfOaPTah58qMMcm2sw1gPwMsdY8eaeAa8q6bwM/fezVPKlzOd3nGlONTz4lLA dX9cMG+bXs4HbYC65Ow5KtnmKbzIZMLuMeVYBwwZ34RS8fs8uV/ZplCYKE0+JM9FE2jnlOSrUqTNL a8ybk6D/sllwCNw5R/rFxgrs33jpcx+A+kaJgusJrVDk/ihCGgnhE5wyio8heGpdxaasJAEY7GKKG 37XfmKh7FEPqmwbIxLPcYAS1VHzLfPn1AOoEzV/HtAEL1ZdVyxPqXSq68sU9tkFW6OPSxsJvOKFke YjKph05Q==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim 4.94.2) (envelope-from ) id 1rhFSs-003CtY-0K; Mon, 04 Mar 2024 21:03:14 +0000 Message-ID: <9e6d2e18-ed39-49f1-be1a-3ede2e4a850c@debian.org> Date: Mon, 4 Mar 2024 22:03:07 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20240304084612.711678-2-ukleinek@debian.org> <3082796.ktpJ11cQ8Q@diego> <0f7d2882-aa4b-424e-a999-45f2e18fc7f0@debian.org> <3246455.0WQXIW03uk@diego> Content-Language: en-US, de-DE From: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Autocrypt: addr=ukleinek@debian.org; keydata= xsFNBEwXmCYBEACoJSJcKIlkQcTYia0ymmMOBk2veFoy/a0LlqGUEjQ4WECBL19F2BYX1dSp 5/ZdfKuV605usI6oq4x6k/LKmqZDl6YnqW/YmN/iZVCRunBRfvpTlL4lcNUu5Va/4GBRzBRr rrIhCIVL5zMV6hKywhHKTdOHVSZRftf+eRSBwENKXahmfOMDmekyf585etDPdzkFrLHNVFOC sFOU0gCK0uVPyY0LH13eo4qEEMi88RCOfwYCFQqKXDdo41DWoDPB5OGCMaphIx9wC/nvtdcv MowsGde5iGgmHWK6sdC/O/xaV7fnz1sJzoJB1eT91LkGbdGxsLAT6nqlaNJiJtiBoRhscguV xVbn/I9mnUu7bLmTFBEAlaQGU/J7uQ4w94FXfosNGROt/otqltetMZlPbNvNhKnXv8U6eRyA P3ZMKTJa4hGr3UdYdt4+MIiHcsANWp8T7oLYVxRbHPXPG49IURnhXUoGbscZmpptWcl29ebo qCxL9n3KIyUT3ZB1xHbW3Sk/Dqzf52tQOxZubzrpUJ8zaGIwYVUjfcPFwf3R3zrQvJq7mI4S ddNIE8w3WJOPXDOYx7GjOa+IubhSpCrr74NbN8q9oS3hnsqWw16i3HSUuPuYeZo1t6D5p/mX EVyZ2QrS1kGgGi7bmlQMSFkb6g1T8aWSYuX3PBYq2VntnWAXPwARAQABzSdVd2UgS2xlaW5l LUvDtm5pZyA8dWtsZWluZWtAZGViaWFuLm9yZz7CwZQEEwEKAD4CGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AWIQQNJRHzIr+rHBWAJmvi3N2RMmab1gUCXQ9wCgUJGl3ZVAAKCRDi3N2R Mmab1hToD/9c/8pxDne+x5Q7lyguEdUgzcB6KADlLnUqdxPGJ3r4Qvd9GPFtnoheV+rrn8zZ f0ChmifNxuld2MxucCLwkpgLSd0vixMHAM7Iv1yqgkhUzGQkO5iBjOgpmph3OGnnxQzEC0Yo 5C5ON/Ty0pbXdstnYvyXnVT3zKCm5lXzSJcCGJ+DgxzjzUiUqGd3tr5Z2j7w3gFcaV/Ttlh1 aVuNJ9R4faM5Zg/hX7h/N6hMvplE+Sx2UC3ez+jesSm6thIMmEREaM3Ey2l/Uxxm2OobKX0P yrm4iDVT0EvjUTMo0mJXXPA4iPWi6vfrKg4rYxg337YSKQ587c9jPAtm+SGOGb05tDhYGkpe 5tK7QQ7koQdFLy+5n4gc7J5z1Bf9/p/hHHH8e4HYNSpORhDSSMqdvDzbYBLgvFg/9Qu0xsNh BHikc/vIgraSYMt1uWWPS0Y3ZTkSfM8/u4Qu529dlzNiMOOMEf8Fmsc65hkvfADa66WSBF+e sWp3wA5g5kzhTolLV1wZjXtVaFgB2FLvegSeAn10/M/dk/NIjHLKP/ugCJpVYQ8hAR8t3Ni9 CCFudav6hE4wyzRA18trapLIUpD3yCfe1q6d+dy8qG8pyVE5ttq5QnBnwLyhN9+6G2jylcjM c7HoqLCAJ5qRmUAsVVsSzld18OnovJm+8jGVZksatxfWVs7ATQRkFLItAQgA2YB8yT/7jfl0 8gwChlc9V6QlIc394+h2t6dazX/IoOF6nkkA0JAX9zY2Cdmzl1wmcoItVFIPZQUlSmiDPQ4o zo8kzIgTgsa+lsRPeX+kP+V4BKwxqzBN+rgI2ml5LUFXdCrEcJzkDnpnZRIgBJAPXHo3r4bf EQpQlCnSHO3nkOajXWaEqZqN0qGJY9py6ZY8iHMro04rLyX66YJakxko3kD3xoPdkOVoZn0v uY6ht1ZyE2IoXrh62a36Z/k721iq8aFOnAe3jnGu3muvBQ2Hn/WWMDvDwvj/G6ROng0dV/LZ /3VIBEsDSLaOkNR2ang7vcnXEjICoBh/EoHop8/ozQARAQABwsF8BBgBCgAmFiEEDSUR8yK/ qxwVgCZr4tzdkTJmm9YFAmQUsi0CGwwFCQPCZwAACgkQ4tzdkTJmm9aruQ//ToofW/CRkwr0 eWMwTnAdLVMtfKZiu1akzBstsA4lCPpphKRllvJZKSlr0fgOmKbGQ4ufGi9dNlZfMeani9cJ HrVf6tIHmvzTMWpLNBNxTtKXnYknG/SKfJs6H3IV0LLceua+PcqSG+yU7oRxhZzgPrQ0kHVg D2AQ9xgUxPGJd8HCKYW+Z0f/+p9+lZjEScKHwsDgkidVQ+/UJkxfOXDzfYYm36Ebpxlunq7y Wo+4PXBlJQzTDuTEMng6td7PCLt2hshO8CpRNW8p0GZq7CMRr6W7H8ktVPV1aXd0pQDjwsaK Vz7Fmiza84MHMQQOPzIHdERuDFGzALXzyZfy+Kc7b3fWTueFNSzKPFtqWfHXfbfvJxoiTDUl O1RvomHetBqDIr67eaW6ekdA7+3nCjRM5BaG3c/WHl0HDiNzOEbK33XxMODUBLsLbbda4IzA suMIj+WVXwX9bnTQ98fHGVFd5cGpKi9oxQl98HaKB16lPfqVMGUZW2zdRLhHoCgePsekMBe+ yYtJ0zPz5nzVrT/i8B0teBgX9drvARHEe0ARcb5b45HxF6GqTfFkz5XJOvcmLs5x3VA+Icb1 C3ZFzCSZg0TfzXFEFBmWMTjhLS8vPmtNtT4dPevEa1lzKrzYXA2EvZ4usYT0Xf8zIhQTj+3m MaQkyqbBqIbxBNgANCE5eTk= In-Reply-To: <3246455.0WQXIW03uk@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Debian-User: ukleinek Hello, [I already replied to this mail earlier today, but I just noticed I only did that to Heiko. So here comes the mail again.] On 04.03.24 10:24, Heiko Stübner wrote: > Am Montag, 4. März 2024, 10:15:57 CET schrieb Uwe Kleine-König: >> On 04.03.24 10:07, Heiko Stübner wrote: >>> Am Montag, 4. März 2024, 09:46:11 CET schrieb Uwe Kleine-König: >>>> While it requires to have the right phy driver loaded (i.e. motorcomm) >>>> to make the phy asserting the right delays, this is generally the >>>> preferred way to define the MAC <-> PHY connection. >>>> >>>> Signed-off-by: Uwe Kleine-König >>>> --- >>>> Hello, >>>> >>>> Andrew already pointed out when I posted the patch introducing the gmac0 node >>>> that rgmii-id would be the preferred way to setup things. Back then this didn't >>>> happen because this change broke reception of network packets. However this >>>> only happend because I didn't have the right phy driver loaded. >>> >>> trying to understand how the (not) loaded module fits into this :-) >>> The mdio-bus is supposed to probe the phy and load the appropriate module. >>> >>> From your description it sounds like the correct phy module needs to be >>> actually loaded? Or was that meant to be a "requires to have the right phy >>> driver compiled" instead? >> >> The latter. i.e. with MOTORCOMM_PHY=n it's broken, but works fine with >> MOTORCOMM_PHY=y or =m. > > ah great, then it's really fine. If it's ok with you I'll change the "loaded" > to "available" then (for compiled in or as module) ack! Best regards Uwe