From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2A09212F12 for ; Fri, 4 Oct 2024 14:03:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728050584; cv=none; b=u9WC/IvJgXrGWR2xDfwXzAQZeJR67lDL0TSmuP5HWXNA6/MOW1FC3hjQ03a6v9iMjqAfRaHSEvV2apsHdEEWc7FegQKWzVl8cGIbw/K2UyMXXopGBANWnT70RGyOc9DUxH2g973ni8hF0nkXTxPesVYjGmmtc1n3bVPG/MmkBgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728050584; c=relaxed/simple; bh=8Z5LddFwZKIemlr/TdgLpEWQcSrNFAmlrDgUkTpKh24=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fCk4e2RQbKBga8aflZbbb3ZxzTCuuUpbU7FyEeGWJAY3lU5wDeS7AleLxXIKl0CIIU3LR+yE8P05zl0UZagwQprOeGT9IIACJJ4UPOsdd3U3wUb+6JZT2FOL1/DvG8VfKOGKUHBZgEuFnzUWfE2KdhYUWLegHa225srN/+m/924= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Rkz73g/f; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Rkz73g/f" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-42cb3c6c353so3439325e9.3 for ; Fri, 04 Oct 2024 07:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728050581; x=1728655381; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=i+W0UPcMEUofL0GGlPfd7SpsVs7uF/Pb41LRoiyF420=; b=Rkz73g/fIH5cVMvXPi+Q38zQU+brBVZz6nVVVV7KYzRFRHZPglNPqPDM/T/1i5GeAc vVPfcJr2Vo93c5yckk4lLsNNRhXFIrSt1LQwdIV8K6yAw8DlXcBLRmAhG1TI31/8Aqd1 xpz8PxkfrHIkgsE5RhGBSRXisa5S7OBM9IvYoBn6+cpVRthO8VBqrzHJhgmF68AzQS6x CpzamKEaQaHj/gqjLXCe9c6htBbXjjvhP+PxbbTcUhnYXYqdrGL1WyY0wD36iwJogzDC GakGjYgqQOT2g6gcA0kTO29WiVD5aNrxY4HgAnsqEDhz7iA3vede/C1x1NIOOAdtnVHZ tQKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728050581; x=1728655381; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i+W0UPcMEUofL0GGlPfd7SpsVs7uF/Pb41LRoiyF420=; b=OoXQZmcb11QulB87ZBdd1nizRX9Mk673IsOlN6lz0mmqkNq++VqNdhPZsgaZ3IBPQ7 WWptaL/gc4AP5bIyHFBYT2vJJShNGoSxwvK8PhjDRlSWw+5bBh5gn3cJXD8eNHR9LWvk dg1YxfgSUGs8nedYlLYdBX/gj/NsOc/0yHQUy2XO3nOEbIS2wjmiSTFb17V6uyFXOKgd NzuQ/DlhCKEKudKKNsdP6N7XddSDhk/J+9XGI2SFIWH2WDYqEKmlx90EJd+mmbR80dqf pOJdwbJMTXpC3Ou5QGRyz75isPOMwJflFnDTBuTSs8KNhRXoRXL0cLFfjhyAxlhSZUYC b4gQ== X-Forwarded-Encrypted: i=1; AJvYcCXLTrl7SPee1pIs8m6p9ES5sp7IoMcZAzVu7QLMGwiYHXV5uFgQqMzpd+Pz19D6sL/U47Tjhu/Zy+VJ@vger.kernel.org X-Gm-Message-State: AOJu0YymESj43wBIWA0qXMwvYWEWHOdQCUmSp5yJW5QNwWzjmRos8zOb OKAHgGLaimoFjQwtJPwNmV2T1Q07jLpVm8MdpD+8QKUQ1sAQ1ApUGcD6MfkqG4Q= X-Google-Smtp-Source: AGHT+IHMYtl2nBgLbFLufrWZfLcFV65YNtkPQLP5BGhMO6MK5Y7lAZPaJbtx2Uha/T4JpCR6JEPpSA== X-Received: by 2002:a05:600c:4fc8:b0:42c:baba:13cb with SMTP id 5b1f17b1804b1-42f85aa360fmr10305185e9.2.1728050580906; Fri, 04 Oct 2024 07:03:00 -0700 (PDT) Received: from [192.168.1.20] ([178.197.211.167]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f86a1f74fsm16530345e9.2.2024.10.04.07.02.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Oct 2024 07:02:57 -0700 (PDT) Message-ID: <9e744cc1-9c27-4172-aacc-8599079f5570@linaro.org> Date: Fri, 4 Oct 2024 16:02:54 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: RFC: Advice on adding support for Qualcomm IPQ9574 SoC Ethernet To: Andrew Lunn , "Kiran Kumar C.S.K" Cc: netdev@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Russell King , Jacob Keller , Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vsmuthu@qti.qualcomm.com, arastogi@qti.qualcomm.com, linchen@qti.qualcomm.com, john@phrozen.org, Luo Jie , Pavithra R , "Suruchi Agarwal (QUIC)" , "Lei Wei (QUIC)" References: <817a0d2d-e3a6-422c-86d2-4e4216468fe6@lunn.ch> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/10/2024 20:42, Andrew Lunn wrote: >> Agree that switchdev is the right model for this device. We were >> planning to enable base Ethernet functionality using regular >> (non-switchdev) netdevice representation for the ports initially, >> without offload support. As the next step, L2/VLAN offload support using >> switchdev will be enabled on top. Hope this phased approach is fine. > > Since it is not a DSA switch, yes, a phased approach should be O.K. > >>>> 3) PCS driver patch series: >>>> Driver for the PCS block in IPQ9574. New IPQ PCS driver will >>>> be enabled in drivers/net/pcs/ >>>> Dependent on NSS CC patch series (2). >>> >>> I assume this dependency is pure at runtime? So the code will build >>> without the NSS CC patch series? >> >> The MII Rx/Tx clocks are supplied from the NSS clock controller to the >> PCS's MII channels. To represent this in the DTS, the PCS node in the >> DTS is configured with the MII Rx/Tx clock that it consumes, using >> macros for clocks which are exported from the NSS CC driver in a header Huh? How is this anyhow related to the point discussed here? That's DTS. You *CANNOT* send DTS to net-next/net. >> file. So, there will be a compile-time dependency for the dtbindings/DTS >> on the NSS CC patch series. We will clearly call out this dependency in >> the cover letter of the PCS driver. Hope that this approach is ok. > > Since there is a compile time dependency, you might want to ask for > the clock patches to be put into a stable branch which can be merged > into netdev. > > Or you need to wait a kernel cycle. Sorry guys, but this is not accurate. There is no such dependency, but what's more: there cannot be such dependency. If there is such dependency and above cross-tree merging is needed, then it is a clear NAK from me, because patchset is utterly broken. Upstreaming SoCs have clear rules, already documented in the kernel, in various emails and in Qualcomm internal guideline (I think, if it is not in your internal guideline, then please update because we keep repeating it once per month to you guys). Best regards, Krzysztof