From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD433C7EE23 for ; Thu, 18 May 2023 14:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231347AbjEROiM (ORCPT ); Thu, 18 May 2023 10:38:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230308AbjEROiL (ORCPT ); Thu, 18 May 2023 10:38:11 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77DD410F for ; Thu, 18 May 2023 07:38:09 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-965ddb2093bso335524166b.2 for ; Thu, 18 May 2023 07:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684420688; x=1687012688; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TJB68kUgGSfkYFcpmVSEE26XJ5wmbNdGl8hf0140WyY=; b=QXC24dYERdPj7w5IyHqJSOkP2OV+NyEoktJjOctGrN44M93oC8MV8N8ACJNDiZyw3g 4Rpt8ut143fHkcGwK6/P9gouJquw1mzjIi4xjmypiBvOc6DtUhhBHp/g3NbNNKoEX5Pv vQKn7eyWZTRKxJDBPBjQQI8hW9w+Y61yedZX0BFUjnDs3xkUuUTKcgrXgfdnHbWo8g0t vIGW9kSH1LFbX7kzWBfx0laEz88mqfQ80sqzakBCljLzp1Azu87Af8h6UVzxHA6o/6ot vf+rams1FbTxZZIJQ3NzIRI4B4eYndEk27BtCTcdf/hpc3JopKjcKscr/G78W4/+yK5a mPCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684420688; x=1687012688; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TJB68kUgGSfkYFcpmVSEE26XJ5wmbNdGl8hf0140WyY=; b=EvAA+9jIXF14bUKLo6Rv32jcf0Jab6D/7tnUiX76Y1qj/nWahsVqp9E/VN9CtrvYJV VkOFjIle5uziwW7g1VSzB3dvHdPLj9bPLSwbqaFmuQfVEezYiiS5tiJVzssaZtuB0aIi ANpe/e2eQXPIlg77InCEMZeisGLfaS0YrErucO04EgGcyT2TuEszuyMKaNjzWFt6KPJf 6WKu5v67hHh/N+fw56uXWar7KFIcwWh8okCkZXa2Ytm3YkYej3LpcBlCEnwyKvp29yoM kZVOA0+ZPPt55kT8wewua2DdEkp4BwW35IWl62D3GxdmnmeZ/FWA79JLGe14NeejEIUI ve/A== X-Gm-Message-State: AC+VfDxn5zuk+Cu8Ona4XgnEvjmSwZhl2aEgzBeMCxu25x6CO9sI/wFU 83GvH3//hxJ1qikByfyD79pygg== X-Google-Smtp-Source: ACHHUZ5OY62Jnuu4B35AUP+mSoCx9lsYdrzczRWwud1XT5I9W4/XGfvXHS9KlHBKFtC9FLytNd8tNw== X-Received: by 2002:a17:906:58d4:b0:96f:504b:4672 with SMTP id e20-20020a17090658d400b0096f504b4672mr416887ejs.13.1684420687886; Thu, 18 May 2023 07:38:07 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7e24:6d1b:6bf:4249? ([2a02:810d:15c0:828:7e24:6d1b:6bf:4249]) by smtp.gmail.com with ESMTPSA id f4-20020a05640214c400b0050e04125a46sm637734edx.10.2023.05.18.07.38.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 May 2023 07:38:07 -0700 (PDT) Message-ID: <9e84a332-4b31-6f90-8d06-78f49d4f1275@linaro.org> Date: Thu, 18 May 2023 16:38:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml Content-Language: en-US From: Krzysztof Kozlowski To: "Gaddam, Sarath Babu Naidu" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "michal.simek@xilinx.com" , "radhey.shyam.pandey@xilinx.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Sarangi, Anirudha" , "Katakam, Harini" , "git (AMD-Xilinx)" References: <20230308061223.1358637-1-sarath.babu.naidu.gaddam@amd.com> <5d074e6b-7fe1-ab7f-8690-cfb1bead6927@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/05/2023 16:34, Krzysztof Kozlowski wrote: > On 18/05/2023 08:17, Gaddam, Sarath Babu Naidu wrote: >> >> >>> -----Original Message----- >>> From: Gaddam, Sarath Babu Naidu >>> Sent: Wednesday, May 3, 2023 3:01 PM >>> To: Krzysztof Kozlowski ; >>> davem@davemloft.net; edumazet@google.com; kuba@kernel.org; >>> pabeni@redhat.com; robh+dt@kernel.org; >>> krzysztof.kozlowski+dt@linaro.org >>> Cc: michal.simek@xilinx.com; radhey.shyam.pandey@xilinx.com; >>> netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Sarangi, >>> Anirudha ; Katakam, Harini >>> ; git (AMD-Xilinx) >>> Subject: RE: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: >>> convert bindings document to yaml >>> >>> >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski >>>> Sent: Tuesday, May 2, 2023 3:56 PM >>>> To: Gaddam, Sarath Babu Naidu >>>> ; davem@davemloft.net; >>>> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >>>> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org >>>> Cc: michal.simek@xilinx.com; radhey.shyam.pandey@xilinx.com; >>>> netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >>>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Sarangi, >>>> Anirudha ; Katakam, Harini >>>> ; git (AMD-Xilinx) >>>> Subject: Re: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: >>>> convert bindings document to yaml >>>> >>>> On 28/03/2023 14:52, Gaddam, Sarath Babu Naidu wrote: >>>>> >>>>> >>>>>> -----Original Message----- >>>>>> From: Krzysztof Kozlowski >>>>>> Sent: Tuesday, March 14, 2023 9:22 PM >>>>>> To: Gaddam, Sarath Babu Naidu >>>>>> ; davem@davemloft.net; >>>>>> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >>>>>> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org >>>>>> Cc: michal.simek@xilinx.com; radhey.shyam.pandey@xilinx.com; >>>>>> netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >>>>>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Sarangi, >>>>>> Anirudha ; Katakam, Harini >>>>>> ; git (AMD-Xilinx) >>>>>> Subject: Re: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: >>>>>> convert bindings document to yaml >>>>>> >>>>>> On 08/03/2023 07:12, Sarath Babu Naidu Gaddam wrote: >>>>>>> From: Radhey Shyam Pandey >>>>>>> >>>>>>> Convert the bindings document for Xilinx AXI Ethernet Subsystem >>>> from >>>>>>> txt to yaml. No changes to existing binding description. >>>>>>> >>>>>> >>>>>> (...) >>>>>> >>>>>>> +properties: >>>>>>> + compatible: >>>>>>> + enum: >>>>>>> + - xlnx,axi-ethernet-1.00.a >>>>>>> + - xlnx,axi-ethernet-1.01.a >>>>>>> + - xlnx,axi-ethernet-2.01.a >>>>>>> + >>>>>>> + reg: >>>>>>> + description: >>>>>>> + Address and length of the IO space, as well as the address >>>>>>> + and length of the AXI DMA controller IO space, unless >>>>>>> + axistream-connected is specified, in which case the reg >>>>>>> + attribute of the node referenced by it is used. >>>>>> >>>>>> Did you test it with axistream-connected? The schema and >>>>>> description feel contradictory and tests would point the issue. >>>>> >>>>> Thanks for review comments. We tested with axistream-connected >>> and >>>> did >>>>> not observe any errors. Do you anticipate any issues/errors ? >>>> >>>> Yes, I anticipate errors. What you wrote here looks incorrect based on >>>> the schema. >>>> >>>> Also, See also my further comments (or you ignored them?). >>>> >>>> You can come many months after my review to ask about details, to be >>>> sure I will forget the topic. >>> >>> >>> Hi Krzysztof, Apologies for miscommunication. I replied to this thread on >>> March 28 and said that I would address remaining review comments in >>> the next version. >>> >>> Lore link: >>> https://lore.kernel.org/all/MW5PR12MB559880B0E220BDBD64E06D24 >>> 87889@MW5PR12MB5598.namprd12.prod.outlook.com/ >>> https://lore.kernel.org/all/MW5PR12MB5598678BB9AB6EC2FFC424F48 >>> 7889@MW5PR12MB5598.namprd12.prod.outlook.com/ >>> >>> I planned to send next version with phy-mode and pcs-handle maxItems >>> fixed.but I wanted to close on the axistream-connected discussion before >>> doing so. >>> >>> Related to axistream-connected discussion: >>> I already ran dt binding check for schema and dts node validation. I >>> assume this should point any errors on it. > > And how do we know that you tested correct DTS with it? > >>> >> >> Hi Krzysztof, Could you please comment on this ? Please let me if I missed >> any changes or comments. > > I don't think anything improved in this patchset. The binding has > incomplete and I believe incorrect constraints for axistream-connected. > You did not provide DTS to prove me otherwise. If you are not going to > fix the issue nor provide DTS, what I can say more? Looks wrong. I think my concerns would be solved if you extend the example with a correct second possibility - device with axistream-connected. An example, which will match all your constraints and all your descriptions (we expect then not having any reg, right?). Best regards, Krzysztof