Re: [PATCH 1/2] dt-bindings: tegra: pmc: Update aotag as an optional aperture

Krzysztof Kozlowski
2025-11-15T12:25:22Z

On Fri, Nov 14, 2025 at 04:17:10PM +0000, Jon Hunter wrote:
> Not all Tegra SoCs or all versions of a particular Tegra SoC may include
> the AOTAG aperture. This change makes "aotag" as an optional aperture for
> Tegra234 and Tegra264.
>
> Co-developed-by: Prathamesh Shete <pshete@nvidia.com>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> Admittedly I don't know if there is a better way to handle this,
> but if there is please let me know!
>
> .../arm/tegra/nvidia,tegra186-pmc.yaml | 57 ++++++++++++-------
> 1 file changed, 38 insertions(+), 19 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.yaml b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.yaml
> index be70819020c5..defd9000eed2 100644
> --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.yaml
> +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.yaml
> @@ -19,17 +19,12 @@ properties:
> - nvidia,tegra264-pmc
>
> reg:
> - minItems: 4
> + minItems: 3
> maxItems: 5
>
> reg-names:
> - minItems: 4
> - items:
> - - const: pmc
> - - const: wake
> - - const: aotag
> - - enum: [ scratch, misc ]
> - - const: misc
> + minItems: 3
> + maxItems: 5

minItems: 3
items:
- const: pmc
- const: wake
- enum: [ aotag, cratch, misc ]
- enum: [ scratch, misc ]
- const: misc

Should work, no?

> interrupt-controller: true
>
> @@ -50,12 +45,12 @@ allOf:
> const: nvidia,tegra186-pmc
> then:
> properties:
> - reg:
> - maxItems: 4

You need to keep reg here. Each variant needs matching constraints
between xxx and xxx-names.

> reg-names:
> - maxItems: 4
> - contains:
> - const: scratch
> + items:
> + - const: pmc
> + - const: wake
> + - const: aotag
> + - const: scratch
>
> - if:
> properties:
> @@ -64,21 +59,45 @@ allOf:
> const: nvidia,tegra194-pmc
> then:
> properties:
> - reg:
> - minItems: 5

Same here

> reg-names:
> - minItems: 5
> + items:
> + - const: pmc
> + - const: wake
> + - const: aotag
> + - const: scratch
> + - const: misc
>
> - if:
> properties:
> compatible:
> contains:
> - const: nvidia,tegra234-pmc
> + enum:
> + - nvidia,tegra234-pmc
> + - nvidia,tegra264-pmc
> then:
> properties:

This is fine.

> reg-names:
> - contains:
> - const: misc

Best regards,
Krzysztof