Re: [PATCH 1/2] dt-bindings: tegra: pmc: Update aotag as an optional aperture

Krzysztof Kozlowski
2025-11-18T14:22:24Z

On 18/11/2025 15:11, Jon Hunter wrote:
>
> On 18/11/2025 13:08, Krzysztof Kozlowski wrote:
>> On 18/11/2025 12:11, Jon Hunter wrote:
>>> then:
>>> properties:
>>> reg-names:
>>> @@ -184,7 +187,7 @@ examples:
>>> <0x0c370000 0x10000>,
>>> <0x0c380000 0x10000>,
>>> <0x0c390000 0x10000>;
>>> - reg-names = "pmc", "wake", "aotag", "scratch";
>>> + reg-names = "pmc", "wake", "scratch", "scratch";
>>> nvidia,invert-interrupt;
>>>
>>> sdmmc1_3v3: sdmmc1-3v3 {
>>>
>>>
>>> The above did not trigger any errors even though I introduced
>>> an error in the example. Anything I am missing?
>>
>> You are right - dtschema does not work here. That's a bug, because it
>> should and we already rely on that for many other bindings. You can add
>> "uniqueItems: true" as workaround, but we should fix it in dtschema, so
>> you can go with my approach anyway.
>
> Thanks. Looks like I can't add 'uniqueItems' to reg-names ...
>
> Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.yaml: properties:reg-names: Additional properties are not allowed ('uniqueItems' was unexpected)
> from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
>
> Would it be OK to go with your proposal for now without
> the uniqueItems?

Yes, that syntax should work anyway.

Best regards,
Krzysztof