From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5A1126C3B1; Mon, 16 Jun 2025 08:22:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750062131; cv=none; b=d/AoS0YTgOijqFZpusMMM0T9Kpmi1ZUbEz65TO7i/+ZORO/ASBQkeMLOwjRLIquLES0pDdlg1c2ilGh+a0ah+xS2Zhg6/xq2ONyTGKQ8NpY4NJgf6S6PlBreHPy4HCNuNxtLe9dhn3oxQsNpeBTHF1RCffFGuEdWxllm5o1DJsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750062131; c=relaxed/simple; bh=2Wb49PEMjKe99vkksWOrOtfqvziTMVq2U+Zv5BWwveQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BlAi42jiHPern6VzgbKqElYKQnw8yLjLfDY6i/tEvlHYf1hScAzomCteLPjE0SSK2coXmyeWkgmQ9JaZNxDL4j3WGUJCSzOcPjotFXyojHidgnbsesqRq6IhzOicF3yeV8iGYnZFzRmJGBRbm6EYUqbML2OB+ZhLJoz32fRHVV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cz8GN647; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cz8GN647" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65611C4CEEA; Mon, 16 Jun 2025 08:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750062131; bh=2Wb49PEMjKe99vkksWOrOtfqvziTMVq2U+Zv5BWwveQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Cz8GN647MOfPqUl6IWqWmTF/TwerIdMpSq/EbRDKCtB581nQfleq7HA+1CM/8D/U1 hR8PJTlHmL6B4//fL3lJZQBaLRWu1yictAsSfOJ3si4NBq5sJ5OEweqK8a9xhguNb/ EX3d8KZ9Oh2g3gMgNUWMXa6XXrNrTDto9IihuLlvb1Xlfo1jU2ywtGhgwSB+OB65Ks oOoN38vswSZlI7sn2Wgdv0BAcq4PS2DRvCLvpWgA9/GKvRw3iU3qQpnKnrm9nvFptA gNrE1m/GFff4VT8CZYoUuOecEXExCOyqVIQPKKrRdgudOwAUB0HY63IfwNFvA3iGKu y+KL0JAJrvLdw== Message-ID: <9e901aba-5e4b-40d8-810c-a7322637752f@kernel.org> Date: Mon, 16 Jun 2025 10:22:06 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] arch: arm64: dts: qcom: qcm2290: Add venus video node To: Jorge Ramirez-Ortiz , quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, stanimir.varbanov@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250613140402.3619465-1-jorge.ramirez@oss.qualcomm.com> <20250613140402.3619465-3-jorge.ramirez@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20250613140402.3619465-3-jorge.ramirez@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/06/2025 16:03, Jorge Ramirez-Ortiz wrote: > Add DT entries for the qcm2290 venus encoder/decoder. > > Signed-off-by: Jorge Ramirez-Ortiz > --- > arch/arm64/boot/dts/qcom/qcm2290.dtsi | 53 +++++++++++++++++++++++++++ DTS cannot be a dependency for driver. Order your patches correctly (see dts coding style, soc maintainer rules or internal guidelines). > 1 file changed, 53 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > index f49ac1c1f8a3..af2c1f66fe07 100644 > --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > @@ -1628,6 +1628,59 @@ adreno_smmu: iommu@59a0000 { > #iommu-cells = <2>; > }; > > + venus: video-codec@5a00000 { > + compatible = "qcom,qcm2290-venus"; > + reg = <0 0x5a00000 0 0xff000>; > + interrupts = ; > + > + power-domains = <&gcc GCC_VENUS_GDSC>, > + <&gcc GCC_VCODEC0_GDSC>, > + <&rpmpd QCM2290_VDDCX>; > + power-domain-names = "venus", "vcodec0", "cx"; > + operating-points-v2 = <&venus_opp_table>; > + > + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, > + <&gcc GCC_VIDEO_AHB_CLK>, > + <&gcc GCC_VENUS_CTL_AXI_CLK>, > + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, > + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, > + <&gcc GCC_VCODEC0_AXI_CLK>; > + clock-names = "core", "iface", "bus", "throttle", > + "vcodec0_core", "vcodec0_bus"; > + > + memory-region = <&pil_video_mem>; > + iommus = <&apps_smmu 0x860 0x0>, > + <&apps_smmu 0x880 0x0>, > + <&apps_smmu 0x861 0x04>, > + <&apps_smmu 0x863 0x0>, > + <&apps_smmu 0x804 0xE0>; > + > + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 0 &bimc SLAVE_EBI1 0>, > + <&bimc MASTER_APPSS_PROC 0 &config_noc SLAVE_VENUS_CFG 0>; > + interconnect-names = "video-mem", "cpu-cfg"; > + > + venus_opp_table: opp-table { > + compatible = "operating-points-v2"; > + opp-133000000 { > + opp-hz = /bits/ 64 <133000000>; > + required-opps = <&rpmpd_opp_low_svs>; > + }; > + > + opp-240000000 { > + opp-hz = /bits/ 64 <240000000>; > + required-opps = <&rpmpd_opp_svs>; > + }; > + }; > + > + video-decoder { > + compatible = "venus-decoder"; Don't add deprecated properties. Best regards, Krzysztof