Re: [PATCH v1 1/3] dt-bindings: PCI: brcmstb: Add two optional props

Krzysztof Kozlowski
2023-04-06T18:53:52Z

On 06/04/2023 20:47, Florian Fainelli wrote:
>>>>> +
>>>>> + brcm,completion-timeout-msecs:
>>>>> + description: Number of msecs before completion timeout
>>>>> + abort occurs.
>>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>>
>>>> According to the driver at least 0 is not allowed, maybe we should
>>>> define minimum and maximum here and let dtbs_check take care of invalid
>>>> values?
>>> I'm not sure I follow what you mean about a zero value; the property
>>> may have any value but the driver will clamp it
>>> to a minimum of ~30msec. Regardless, I can add a "minimum: 30" line
>>> to the YAML.
>>
>> If "completion" means Linux completion, then it is not suitable for DT
>> and entire property should be removed. If it is something else, then
>> explain here and commit msg. So far both refer to some completion...
>
> This is a PCIe root complex binding so completion needs to be understood
> in the context of PCIe, that is the time needed for the root complex to
> complete/finish/proceed with a PCIe transaction layer packet (TLP).

OK, so I assume keyword "completion" is well known term in PCI (although
for some reason no other bindings mention it).

Best regards,
Krzysztof