Re: [PATCH v1 0/3] PCI: brcmstb: Clkreq# accomodations of downstream device

Cyril Brulebois
2023-04-06T21:31:37Z

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Hi Jim,

Jim Quinlan <jim2101024@gmail.com> (2023-04-06):
> The current driver assumes the downstream devices can provide clkreq# for
> ASPM. These commits accomodate devices w/ or w/o clkreq# and also handle
> L1SS-capable devices.
>
> The Raspian Linux folks have already been using a PCIe RC property
> "brcm,enable-l1ss". These commits use the same property, in a
> backward-compatible manner, and the implementaion adds more detail and also
> automatically identifies devices w/o a clkreq# signal, i.e. most devices
> plugged into an RPi CM4 IO board.
>
> Jim Quinlan (3):
> dt-bindings: PCI: brcmstb: Add two optional props
> PCI: brcmstb: Clkreq# accomodations of downstream device
> PCI: brcmstb: Allow setting the completion timeout
>
> .../bindings/pci/brcm,stb-pcie.yaml | 12 +++
> drivers/pci/controller/pcie-brcmstb.c | 93 +++++++++++++++++--
> 2 files changed, 95 insertions(+), 10 deletions(-)
>
>
> base-commit: 99ddf2254febae9eab7fb0bcc02c5322243f5c49

I've just verified with the exact same hardware as in Bugzilla#217276
that latest master (v6.3-rc5-137-gf2afccfefe7b) still gets a kernel
panic at boot, which goes away once those 3 patches are applied. Do you
need any extra information, log excerpt, or something like that?

Cheers,
--
Cyril Brulebois (kibi@debian.org) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]