From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Otto Pflüger" <otto.pflueger@abscue.de>, linux-arm-msm@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: power: rpmpd: Add MSM8917, MSM8937 and QM215
Date: Tue, 12 Sep 2023 09:01:00 +0200 [thread overview]
Message-ID: <9ea20b20-43f8-7619-40a9-710340ea7acf@linaro.org> (raw)
In-Reply-To: <20230912050028.4804-2-otto.pflueger@abscue.de>
On 12/09/2023 07:00, Otto Pflüger wrote:
> The MSM8917, MSM8937 and QM215 SoCs have VDDCX and VDDMX power domains
> controlled in voltage level mode. Define the MSM8937 and QM215 power
> domains as aliases because these SoCs are similar to MSM8917 and may
> share some parts of the device tree.
>
> Also add the compatibles for these SoCs to the documentation, with
> qcom,msm8937-rpmpd using qcom,msm8917-rpmpd as a fallback compatible
> because there are no known differences. QM215 is not compatible with
> these because it uses different regulators.
>
> Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
> ---
> .../devicetree/bindings/power/qcom,rpmpd.yaml | 79 ++++++++++---------
> include/dt-bindings/power/qcom-rpmpd.h | 21 +++++
> 2 files changed, 64 insertions(+), 36 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> index 9b03c41d3604..d4dac8b54045 100644
> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> @@ -15,42 +15,49 @@ description:
>
> properties:
> compatible:
> - enum:
> - - qcom,mdm9607-rpmpd
> - - qcom,msm8226-rpmpd
> - - qcom,msm8909-rpmpd
> - - qcom,msm8916-rpmpd
> - - qcom,msm8939-rpmpd
> - - qcom,msm8953-rpmpd
> - - qcom,msm8976-rpmpd
> - - qcom,msm8994-rpmpd
> - - qcom,msm8996-rpmpd
> - - qcom,msm8998-rpmpd
> - - qcom,qcm2290-rpmpd
> - - qcom,qcs404-rpmpd
> - - qcom,qdu1000-rpmhpd
> - - qcom,sa8155p-rpmhpd
> - - qcom,sa8540p-rpmhpd
> - - qcom,sa8775p-rpmhpd
> - - qcom,sdm660-rpmpd
> - - qcom,sc7180-rpmhpd
> - - qcom,sc7280-rpmhpd
> - - qcom,sc8180x-rpmhpd
> - - qcom,sc8280xp-rpmhpd
> - - qcom,sdm670-rpmhpd
> - - qcom,sdm845-rpmhpd
> - - qcom,sdx55-rpmhpd
> - - qcom,sdx65-rpmhpd
> - - qcom,sdx75-rpmhpd
> - - qcom,sm6115-rpmpd
> - - qcom,sm6125-rpmpd
> - - qcom,sm6350-rpmhpd
> - - qcom,sm6375-rpmpd
> - - qcom,sm8150-rpmhpd
> - - qcom,sm8250-rpmhpd
> - - qcom,sm8350-rpmhpd
> - - qcom,sm8450-rpmhpd
> - - qcom,sm8550-rpmhpd
> + oneOf:
> + - enum:
> + - qcom,mdm9607-rpmpd
> + - qcom,msm8226-rpmpd
> + - qcom,msm8909-rpmpd
> + - qcom,msm8916-rpmpd
> + - qcom,msm8917-rpmpd
> + - qcom,msm8939-rpmpd
> + - qcom,msm8953-rpmpd
> + - qcom,msm8976-rpmpd
> + - qcom,msm8994-rpmpd
> + - qcom,msm8996-rpmpd
> + - qcom,msm8998-rpmpd
> + - qcom,qcm2290-rpmpd
> + - qcom,qcs404-rpmpd
> + - qcom,qdu1000-rpmhpd
> + - qcom,qm215-rpmpd
> + - qcom,sa8155p-rpmhpd
> + - qcom,sa8540p-rpmhpd
> + - qcom,sa8775p-rpmhpd
> + - qcom,sdm660-rpmpd
Move it down to sort, while you are changing it.
With above (and assumption if you ever need to rebase the patch you will
be extra careful and re-check all entries):
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-12 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 5:00 [PATCH v2 0/3] genpd: qcom: rpmpd: Add MSM8917 and similar SoCs Otto Pflüger
2023-09-12 5:00 ` [PATCH v2 1/3] dt-bindings: power: rpmpd: Add MSM8917, MSM8937 and QM215 Otto Pflüger
2023-09-12 7:01 ` Krzysztof Kozlowski [this message]
2023-09-12 5:00 ` [PATCH v2 2/3] genpd: qcom: rpmpd: Add MSM8917 power domains Otto Pflüger
2023-09-12 5:00 ` [PATCH v2 3/3] genpd: qcom: rpmpd: Add QM215 " Otto Pflüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea20b20-43f8-7619-40a9-710340ea7acf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=otto.pflueger@abscue.de \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).