From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
sophgo@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 2/3] clk: sophgo: Add support for newly added precise compatible
Date: Wed, 30 Apr 2025 17:39:52 +0200 [thread overview]
Message-ID: <9ea234373b18a91c6a2f7a41c441002de1e92e98.camel@gmail.com> (raw)
In-Reply-To: <20250430020932.307198-3-inochiama@gmail.com>
Hi Inochi!
On Wed, 2025-04-30 at 10:09 +0800, Inochi Amaoto wrote:
> Add of device id definition for newly added precise compatible.
>
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> drivers/clk/sophgo/clk-cv1800.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/sophgo/clk-cv1800.c b/drivers/clk/sophgo/clk-cv1800.c
> index e0c4dc347579..e10221df6385 100644
> --- a/drivers/clk/sophgo/clk-cv1800.c
> +++ b/drivers/clk/sophgo/clk-cv1800.c
> @@ -1519,8 +1519,11 @@ static int cv1800_clk_probe(struct platform_device *pdev)
>
> static const struct of_device_id cv1800_clk_ids[] = {
> { .compatible = "sophgo,cv1800-clk", .data = &cv1800_desc },
> + { .compatible = "sophgo,cv1800b-clk", .data = &cv1800_desc },
> { .compatible = "sophgo,cv1810-clk", .data = &cv1810_desc },
> + { .compatible = "sophgo,cv1812h-clk", .data = &cv1800_desc },
^
Should it have been "cv1810_desc" instead?
> { .compatible = "sophgo,sg2000-clk", .data = &sg2000_desc },
> + { .compatible = "sophgo,sg2002-clk", .data = &sg2000_desc },
> { }
> };
> MODULE_DEVICE_TABLE(of, cv1800_clk_ids);
--
Alexander Sverdlin.
next prev parent reply other threads:[~2025-04-30 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 2:09 [PATCH 0/3] riscv: sophgo: cv18xx: dts rework, part 2 Inochi Amaoto
2025-04-30 2:09 ` [PATCH 1/3] dt-bindings: clock: sophgo: Use precise compatible for CV1800 series SoC Inochi Amaoto
2025-04-30 2:09 ` [PATCH 2/3] clk: sophgo: Add support for newly added precise compatible Inochi Amaoto
2025-04-30 15:33 ` Conor Dooley
2025-04-30 15:37 ` Conor Dooley
2025-04-30 22:43 ` Inochi Amaoto
2025-05-01 14:22 ` Conor Dooley
2025-05-01 22:23 ` Inochi Amaoto
2025-04-30 22:42 ` Inochi Amaoto
2025-04-30 15:39 ` Alexander Sverdlin [this message]
2025-04-30 22:38 ` Inochi Amaoto
2025-04-30 2:09 ` [PATCH 3/3] riscv: dts: sophgo: switch precise compatible for existed clock device for CV18XX Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea234373b18a91c6a2f7a41c441002de1e92e98.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=sophgo@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).