From: "Sven Peter" <sven@svenpeter.dev>
To: "kernel test robot" <lkp@intel.com>
Cc: "Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Joerg Roedel" <joro@8bytes.org>,
"Rob Herring" <robh+dt@kernel.org>,
kbuild-all@lists.01.org, "Arnd Bergmann" <arnd@kernel.org>,
devicetree@vger.kernel.org, "Hector Martin" <marcan@marcan.st>,
linux-kernel@vger.kernel.org, "Marc Zyngier" <maz@kernel.org>
Subject: Re: [PATCH v2 3/3] iommu: dart: Add DART iommu driver
Date: Sun, 28 Mar 2021 12:11:34 +0200 [thread overview]
Message-ID: <9ea84c5b-55db-4b16-aede-bf972e35f1f3@www.fastmail.com> (raw)
In-Reply-To: <202103281719.Xb7Kqjb4-lkp@intel.com>
Hi,
On Sun, Mar 28, 2021, at 11:34, kernel test robot wrote:
>
> All error/warnings (new ones prefixed by >>):
>
> drivers/iommu/apple-dart-iommu.c: In function 'apple_dart_finalize_domain':
> >> drivers/iommu/apple-dart-iommu.c:427:34: error: implicit declaration of function 'DMA_BIT_MASK'; did you mean 'BIT_MASK'? [-Werror=implicit-function-declaration]
> 427 | domain->geometry.aperture_end = DMA_BIT_MASK(32);
> | ^~~~~~~~~~~~
> | BIT_MASK
Fixed by adding the missing <linux/dma-mapping.h> include for DMA_BIT_MASK.
> drivers/iommu/apple-dart-iommu.c: In function 'apple_dart_attach_stream':
> >> drivers/iommu/apple-dart-iommu.c:456:11: error: implicit declaration of function 'kzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
> 456 | stream = kzalloc(sizeof(*stream), GFP_KERNEL);
> | ^~~~~~~
> | kvzalloc
> >> drivers/iommu/apple-dart-iommu.c:456:9: warning: assignment to 'struct apple_dart_stream *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 456 | stream = kzalloc(sizeof(*stream), GFP_KERNEL);
> | ^
> drivers/iommu/apple-dart-iommu.c: In function 'apple_dart_detach_stream':
> >> drivers/iommu/apple-dart-iommu.c:523:5: error: implicit declaration of function 'kfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
> 523 | kfree(stream);
> | ^~~~~
> | kvfree
> drivers/iommu/apple-dart-iommu.c: In function 'apple_dart_domain_alloc':
> >> drivers/iommu/apple-dart-iommu.c:627:14: warning: assignment to 'struct apple_dart_domain *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 627 | dart_domain = kzalloc(sizeof(*dart_domain), GFP_KERNEL);
> | ^
> drivers/iommu/apple-dart-iommu.c: In function 'apple_dart_of_xlate':
> >> drivers/iommu/apple-dart-iommu.c:659:7: warning: assignment to 'struct apple_dart_master_cfg *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 659 | cfg = kzalloc(struct_size(cfg, streams, 1), GFP_KERNEL);
> | ^
> >> drivers/iommu/apple-dart-iommu.c:663:13: error: implicit declaration
> of function 'krealloc'; did you mean 'kvcalloc'?
> [-Werror=implicit-function-declaration]
> 663 | cfg_new = krealloc(
> | ^~~~~~~~
> | kvcalloc
> drivers/iommu/apple-dart-iommu.c:663:11: warning: assignment to
> 'struct apple_dart_master_cfg *' from 'int' makes pointer from integer
> without a cast [-Wint-conversion]
> 663 | cfg_new = krealloc(
> | ^
> cc1: some warnings being treated as errors
>
>
Fixed by adding the missing <linux/slab.h> include for krealloc, kfree and kzalloc.
Thanks,
Sven
next prev parent reply other threads:[~2021-03-28 10:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 7:40 [PATCH v2 0/3] Apple M1 DART IOMMU driver Sven Peter
2021-03-28 7:40 ` [PATCH v2 1/3] iommu: io-pgtable: add DART pagetable format Sven Peter
2021-03-28 9:42 ` kernel test robot
2021-03-28 10:13 ` Sven Peter
2021-03-28 10:04 ` kernel test robot
2021-04-07 10:44 ` Will Deacon
2021-04-09 16:55 ` Sven Peter
2021-04-09 19:38 ` Arnd Bergmann
2021-04-19 16:31 ` Will Deacon
2021-03-28 7:40 ` [PATCH v2 2/3] dt-bindings: iommu: add DART iommu bindings Sven Peter
2021-03-28 8:16 ` Arnd Bergmann
2021-03-28 9:22 ` Sven Peter
2021-03-28 7:40 ` [PATCH v2 3/3] iommu: dart: Add DART iommu driver Sven Peter
2021-03-28 9:34 ` kernel test robot
2021-03-28 10:11 ` Sven Peter [this message]
2021-04-07 10:42 ` Will Deacon
2021-04-09 16:50 ` Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea84c5b-55db-4b16-aede-bf972e35f1f3@www.fastmail.com \
--to=sven@svenpeter.dev \
--cc=arnd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joro@8bytes.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).