devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Georgi Djakov <djakov@kernel.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Cc: agross@kernel.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, andersson@kernel.org,
	bhupesh.linux@gmail.com, krzysztof.kozlowski@linaro.org,
	robh+dt@kernel.org, konrad.dybcio@linaro.org,
	vladimir.zapolskiy@linaro.org, rfoss@kernel.org,
	neil.armstrong@linaro.org
Subject: Re: [PATCH v5 10/11] arm64: dts: qcom: sm8350: Add Crypto Engine support
Date: Mon, 3 Apr 2023 15:15:59 +0300	[thread overview]
Message-ID: <9ecab48e-e828-0a03-2bc7-678e555bc80d@kernel.org> (raw)
In-Reply-To: <20230402100509.1154220-11-bhupesh.sharma@linaro.org>

Hi Bhupesh,

On 2.04.23 13:05, Bhupesh Sharma wrote:
> Add crypto engine (CE) and CE BAM related nodes and definitions to
> 'sm8350.dtsi'.
> 
> Co-developed-by and Signed-off-by: Robert Foss <rfoss@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/sm8350.dtsi | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index 7fbc288eca58..090ee07d1800 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -1730,6 +1730,28 @@ ufs_mem_phy_lanes: phy@1d87400 {
>   			};
>   		};
>   
> +		cryptobam: dma-controller@1dc4000 {
> +			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> +			reg = <0 0x01dc4000 0 0x24000>;
> +			interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
> +			#dma-cells = <1>;
> +			qcom,ee = <0>;
> +			qcom,controlled-remotely;
> +			iommus = <&apps_smmu 0x594 0x0011>,
> +				 <&apps_smmu 0x596 0x0011>;
> +		};
> +
> +		crypto: crypto@1dfa000 {
> +			compatible = "qcom,sm8350-qce", "qcom,sm8150-qce", "qcom,qce";
> +			reg = <0 0x01dfa000 0 0x6000>;
> +			dmas = <&cryptobam 4>, <&cryptobam 5>;
> +			dma-names = "rx", "tx";
> +			iommus = <&apps_smmu 0x594 0x0011>,
> +				 <&apps_smmu 0x596 0x0011>;
> +			interconnects = <&aggre2_noc MASTER_CRYPTO &mc_virt SLAVE_EBI1>;
> +			interconnect-names = "memory";

We switched to #interconnect-cells = <2> (since commit 4f287e31ff5f), so maybe #include
dt-bindings/interconnect/qcom,icc.h and add the tags.

BR,
Georgi

> +		};
> +
>   		ipa: ipa@1e40000 {
>   			compatible = "qcom,sm8350-ipa";
>   


  reply	other threads:[~2023-04-03 12:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-02 10:04 [PATCH v5 00/11] arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
2023-04-02 10:04 ` [PATCH v5 01/11] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Bhupesh Sharma
2023-04-04 13:41   ` Rob Herring
2023-04-02 10:05 ` [PATCH v5 02/11] dt-bindings: dma: Increase iommu maxItems for BAM DMA Bhupesh Sharma
2023-04-02 10:05 ` [PATCH v5 03/11] arm64: dts: qcom: sdm8550: Fix the BAM DMA engine compatible string Bhupesh Sharma
2023-04-02 10:05 ` [PATCH v5 04/11] arm64: dts: qcom: sdm845: Fix the slimbam " Bhupesh Sharma
2023-04-02 10:05 ` [PATCH v5 05/11] dt-bindings: qcom-qce: Fix compatible combinations for SM8150 and IPQ4019 SoCs Bhupesh Sharma
2023-04-03  5:36   ` Vladimir Zapolskiy
2023-04-03  6:15     ` Bhupesh Sharma
2023-04-03 10:48       ` Konrad Dybcio
2023-04-03 11:07         ` Bhupesh Sharma
2023-04-02 10:05 ` [PATCH v5 06/11] dt-bindings: qcom-qce: Add compatibles for SM6115 and QCM2290 Bhupesh Sharma
2023-04-02 10:05 ` [PATCH v5 07/11] arm64: dts: qcom: sm6115: Add Crypto Engine support Bhupesh Sharma
2023-04-02 10:05 ` [PATCH v5 08/11] arm64: dts: qcom: sm8150: " Bhupesh Sharma
2023-04-02 10:05 ` [PATCH v5 09/11] arm64: dts: qcom: sm8250: " Bhupesh Sharma
2023-04-02 10:05 ` [PATCH v5 10/11] arm64: dts: qcom: sm8350: " Bhupesh Sharma
2023-04-03 12:15   ` Georgi Djakov [this message]
2023-04-04  6:51     ` Bhupesh Sharma
2023-04-02 10:05 ` [PATCH v5 11/11] arm64: dts: qcom: sm8450: add crypto nodes Bhupesh Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ecab48e-e828-0a03-2bc7-678e555bc80d@kernel.org \
    --to=djakov@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bhupesh.linux@gmail.com \
    --cc=bhupesh.sharma@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).