From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9783C433EF for ; Tue, 21 Jun 2022 18:57:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352345AbiFUS5B (ORCPT ); Tue, 21 Jun 2022 14:57:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352204AbiFUS47 (ORCPT ); Tue, 21 Jun 2022 14:56:59 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8BAB2A242 for ; Tue, 21 Jun 2022 11:56:57 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id a13so14041986lfr.10 for ; Tue, 21 Jun 2022 11:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=WnoLWhxeYHm5yTgtcGD1IsezPefmqZIcjwjw5Wg8Y1s=; b=A0iPKWj/b60aY72nWLN+L+5qwzuBwgkTum1Nj3z85tVeILqikpZo97/piph2moEAyI ZAA5BM8ZMmcGV+3zxaWwi0lPt+yVJkZOmJ/qN0sH6z/ioOvf0Kezc0cJLj8f3NQ7m1pc eB1q+sX9/jXxB78m0DhfWhyW40vltUW/UiB3WK4EPIeKXPAj7ecznjMPow0YduS7gwP5 f1b54Vs01hf9s3H/yG2oTu5b1GqmF2MH9VPm40JiN5fBJWpR8Uv5ustdhVHU5fRZ1Z5G DBH2agrb2JSwNH4CpO18Vhe702GF/BFl0r0bIJdQJTwrESpYDe9meRlfhODVit0zZ9Vb uyLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=WnoLWhxeYHm5yTgtcGD1IsezPefmqZIcjwjw5Wg8Y1s=; b=24uXyskYZHQYykVG6KFqCbSzFfgEev//xBF9mbuBg0F6rp+EdEI7ee+40p+GyXQ8Mo fAnTT5nm6crMh6IPgjeWeZQkMbP0Hg35coe3Y/QESKPyGxMb+hcyNrkwrJ1e02O7Sez3 UBG2NUQRctPiVM77Hz3CqPpJiou6zFsVSbhW0EGn3DKAHdRv+jOM4Zoy8F4ETrRseMap C036C8CwXNGagqVka/YFUAEDgjV1kIAHH3zqHPRXyKAJwDJyELIbxWBkrmJ3sYbcmTrM p8RcX16tWR7ToK2IeIQsh8kaJffvF2Jj2xnuJYmcMwREYEnfYJGX6sJTDIlRzNyPFQrZ 0VKQ== X-Gm-Message-State: AJIora9dst3hu5WVFu+DZtzcdQSTwah0uqG0v+ZZncI95BG7jsm7rsaP buR3CuWoJZfISxf6FeS30XHXRg== X-Google-Smtp-Source: AGRyM1sftYHhG2H1/RbaWHAxQwPnIdXY1mfFVlAOlwLGeBmR2GQ87dQlV7VOlpFL1C5+w62FZN3G5A== X-Received: by 2002:a05:6512:1513:b0:47f:6b4b:5e8b with SMTP id bq19-20020a056512151300b0047f6b4b5e8bmr7764466lfb.469.1655837816113; Tue, 21 Jun 2022 11:56:56 -0700 (PDT) Received: from [192.168.43.7] ([188.162.64.230]) by smtp.gmail.com with ESMTPSA id b3-20020a2e8943000000b00253eee43dd7sm555624ljk.44.2022.06.21.11.56.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jun 2022 11:56:55 -0700 (PDT) Message-ID: <9ed319ee-07bd-253a-c7d8-a35d7d709da0@linaro.org> Date: Tue, 21 Jun 2022 21:56:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [v3 2/5] drm/bridge: use atomic enable/disable callbacks for panel bridge functions Content-Language: en-GB From: Dmitry Baryshkov To: Vinod Polimera , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, quic_sbillaka@quicinc.com References: <1655808800-3996-1-git-send-email-quic_vpolimer@quicinc.com> <1655808800-3996-3-git-send-email-quic_vpolimer@quicinc.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/06/2022 21:54, Dmitry Baryshkov wrote: > On 21/06/2022 13:53, Vinod Polimera wrote: >> Use atomic variants for panel bridge callback functions such that >> certain states like self-refresh can be accessed as part of >> enable/disable sequence. >> >> Signed-off-by: Vinod Polimera > > Reviewed-by: Dmitry Baryshkov Oh, wait. NACK. This will not compile. Please fix compilation with this patch. > >> --- >>   drivers/gpu/drm/bridge/panel.c | 16 ++++++++-------- >>   1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/panel.c >> b/drivers/gpu/drm/bridge/panel.c >> index 0ee563e..59a3496 100644 >> --- a/drivers/gpu/drm/bridge/panel.c >> +++ b/drivers/gpu/drm/bridge/panel.c >> @@ -108,28 +108,28 @@ static void panel_bridge_detach(struct >> drm_bridge *bridge) >>           drm_connector_cleanup(connector); >>   } >> -static void panel_bridge_pre_enable(struct drm_bridge *bridge) >> +static void panel_bridge_atomic_pre_enable(struct drm_bridge *bridge) >>   { >>       struct panel_bridge *panel_bridge = >> drm_bridge_to_panel_bridge(bridge); >>       drm_panel_prepare(panel_bridge->panel); >>   } >> -static void panel_bridge_enable(struct drm_bridge *bridge) >> +static void panel_bridge_atomic_enable(struct drm_bridge *bridge) >>   { >>       struct panel_bridge *panel_bridge = >> drm_bridge_to_panel_bridge(bridge); >>       drm_panel_enable(panel_bridge->panel); >>   } >> -static void panel_bridge_disable(struct drm_bridge *bridge) >> +static void panel_bridge_atomic_disable(struct drm_bridge *bridge) >>   { >>       struct panel_bridge *panel_bridge = >> drm_bridge_to_panel_bridge(bridge); >>       drm_panel_disable(panel_bridge->panel); >>   } >> -static void panel_bridge_post_disable(struct drm_bridge *bridge) >> +static void panel_bridge_atomic_post_disable(struct drm_bridge *bridge) >>   { >>       struct panel_bridge *panel_bridge = >> drm_bridge_to_panel_bridge(bridge); >> @@ -158,10 +158,10 @@ static void panel_bridge_debugfs_init(struct >> drm_bridge *bridge, >>   static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { >>       .attach = panel_bridge_attach, >>       .detach = panel_bridge_detach, >> -    .pre_enable = panel_bridge_pre_enable, >> -    .enable = panel_bridge_enable, >> -    .disable = panel_bridge_disable, >> -    .post_disable = panel_bridge_post_disable, >> +    .atomic_pre_enable = panel_bridge_atomic_pre_enable, >> +    .atomic_enable = panel_bridge_atomic_enable, >> +    .atomic_disable = panel_bridge_atomic_disable, >> +    .atomic_post_disable = panel_bridge_atomic_post_disable, >>       .get_modes = panel_bridge_get_modes, >>       .atomic_reset = drm_atomic_helper_bridge_reset, >>       .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > > -- With best wishes Dmitry