From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3C2C43334 for ; Wed, 13 Jul 2022 09:11:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231801AbiGMJL5 (ORCPT ); Wed, 13 Jul 2022 05:11:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbiGMJL5 (ORCPT ); Wed, 13 Jul 2022 05:11:57 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5741CE0265 for ; Wed, 13 Jul 2022 02:11:56 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id bf9so17998806lfb.13 for ; Wed, 13 Jul 2022 02:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=saO2Vm+/KyaP+id6PNz07neSMyog2NEC8zLvu+tIFmM=; b=OzJImiJoAdCFlMCkcZjWWKX+Nr+zXuJYdDbRkrnViyRoiXtNb4r8yzK7RRQx+xzR/S jQgOn/ZR5XNLERq7zzE7yFxrmXVWodyd7Medkc+OH5NG0y4PC9Ie5wc6/vzT4XTgnoGN cAGAJQ7HoJmvMcbRvEZdOTxzTJSILaylDXxZNjJaj8d3BtgmB/HFjAozbnCbCtDOHUEp WRnJvLBpIMLJO2T/Pw7onHKfvP1mBejdWGwnnXXr3Qdr7SFiQ1G+JmT+P9I+cGp2hOnp nlOeQ973l0qXlLUzwtUr8VAR5CUAv+a+Bb1NBXZKBXh4wqEhG0pVK9CHR7ZlS9RkE/9a mYww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=saO2Vm+/KyaP+id6PNz07neSMyog2NEC8zLvu+tIFmM=; b=nC4vUdixJiCG+BoIGzzPvHrydfTEPoNvE43OQChc/GYWnYC4RoDfI0DUrERZfO5eSY Rqd4n5vfvMu2RnOVlyQM80VveIXXRw+rHvaJZznmQEv5OGk33ovRvXAeHCHXDrDCqtL8 ZrokKT+JCnbwzefjb9O/BihQwkQxWlRbSSsirpqxAcmYNaHMxtuBjXEedjUHtSQ7874m fCrdyx5+Ou1CrYrTI4UMoWZQ7IyTCR5kdQbjU2zIKQRHlI+Oz1H/VZEN+HSqZxah/FwR CM8qb04rkhM3f4P83++fmDqQvVrxuKE1cWtkve8mHQSvaDe3WKqEjBjWgmxkJptplPNr NezQ== X-Gm-Message-State: AJIora97TjsZhDVmHwgwSEBOEAb29RR77IEzHOQyAzgKaRm0wJUlrRXu O4ngrCKZmFGle/ehWmpldghl5g== X-Google-Smtp-Source: AGRyM1thb1RspXQrd9rr8p+Xg+Flcp6pMnFUTlW/oaoUlJ1Ds/9A2MeXytLAnYoXFEVBe5Q6Yt1dIg== X-Received: by 2002:a05:6512:3daa:b0:489:d1b2:8b29 with SMTP id k42-20020a0565123daa00b00489d1b28b29mr1509727lfv.218.1657703514591; Wed, 13 Jul 2022 02:11:54 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id r14-20020ac25a4e000000b0047255d211c7sm2684080lfn.246.2022.07.13.02.11.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 02:11:53 -0700 (PDT) Message-ID: <9ed772a9-ad01-55c9-fda5-5b3f8082bc7e@linaro.org> Date: Wed, 13 Jul 2022 11:11:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "l.stach@pengutronix.de" Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "laurent.pinchart@ideasonboard.com" , "marex@denx.de" , "paul.elder@ideasonboard.com" , "aford173@gmail.com" , "Markus.Niebel@ew.tq-group.com" , "alexander.stein@ew.tq-group.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Aisheng Dong References: <20220713063653.2584488-1-peng.fan@oss.nxp.com> <20220713063653.2584488-3-peng.fan@oss.nxp.com> <52c0d236-49c6-7c31-abd8-2a083ca7ef8c@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/07/2022 11:03, Peng Fan wrote: > Hi Krzysztof, > >> Subject: Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl >> >> On 13/07/2022 08:36, Peng Fan (OSS) wrote: >>> From: Peng Fan >>> >>> i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse >>> the i.MX8MM VPU blk ctrl yaml file. And add description for the items. >>> >>> Signed-off-by: Peng Fan >>> --- >>> .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml | 93 ++++++++++++++++--- >>> include/dt-bindings/power/imx8mp-power.h | 4 + >>> 2 files changed, 86 insertions(+), 11 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk- >> ctrl.ya >>> ml >>> b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk- >> ctrl.ya >>> ml index 26487daa64d9..d05930f61f95 100644 >>> --- >>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk- >> ctrl.ya >>> ml >>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk- >> ctr >>> +++ l.yaml >>> @@ -28,24 +28,15 @@ properties: >>> >>> power-domains: >>> minItems: 4 >>> - maxItems: 4 >> >> This is not correct. maxItems must stay, but you could drop minItems, >> prefferrably in separate patch. > [Peng Fan] > > Ok, I will only keep maxItems. For separate patch, you mean > separate adding description for i.MX8MM to one patch, right? I mean, a new patch doing cleanup. You currently have minItems and maxItems set as the same value. In such case minItems is not necessary. You could remove all of minItems (when equal to maxItems) before adding new device support. Best regards, Krzysztof