From: David Virag <virag.david003@gmail.com>
To: Chanho Park <chanho61.park@samsung.com>,
'Sam Protsenko' <semen.protsenko@linaro.org>,
'Jaewon Kim' <jaewon02.kim@samsung.com>
Cc: 'Krzysztof Kozlowski' <krzysztof.kozlowski@canonical.com>,
'Wolfram Sang' <wsa@kernel.org>,
'Rob Herring' <robh+dt@kernel.org>,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/2] i2c: exynos5: add support for ExynosAutov9 SoC
Date: Wed, 17 Nov 2021 23:17:55 +0100 [thread overview]
Message-ID: <9ee9584833d948188347414991a117ca86edfaaf.camel@gmail.com> (raw)
In-Reply-To: <001401d7da86$f7ebd660$e7c38320$@samsung.com>
> Current version of USI is v2 which means there is a v1 version as well.
> It might be a non-upstream SoC so we don't need to consider it so far.
The Exynos7885 I'm working on has USI v1. It doesn't seem to be heavily
used as the SoC has just 3 USI blocks if I didn't miss anything.
The most obvious difference I saw was instead of having 3 modes (SPI,
UART, and HSI2C) It has:
- SPI
- HSI2C0 (meaning I2C pins are connected to the first 2 pins out of
the 4 if I understand it correctly)
- HSI2C1 (connected to last 2 pins)
- HSI2C0_HSI2C1 (2 I2C devices connected to first 2 and last 2 pins)
- UART
- UART_HSI2C1 (first 2 pins are UART, rest is I2C)
Also there doesn't seem to be any USI_CON or USI_OPTION registers in
SPI, UART, or I2C. It seems like it's just the USI driver doing all the
work (just setting up the SYSREG) and the I2C driver writing values to
the SYSREG at suspend/resume for some reason.
From the looks of it, it doesn't look like it'd be hard to add this to
USI v2 drivers when needed. (USI driver (if that's the way it will go)
would just need minor modifications to add v1 modes and UART/SPI/I2C
drivers may just work with non-USI compatibles/would only need SoC
specific data added).
Best Regards,
David
prev parent reply other threads:[~2021-11-17 22:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20211112010603epcas2p331fe717eabfd9fc0280792921b25c535@epcas2p3.samsung.com>
2021-11-12 1:01 ` [PATCH v3 0/2] i2c: exynos5: add support for ExynosAutov9 SoC Jaewon Kim
[not found] ` <CGME20211112010603epcas2p26c076e65e0cb286cb53f06053165ef60@epcas2p2.samsung.com>
2021-11-12 1:01 ` [PATCH v3 1/2] dt-bindings: i2c: exynos5: add exynosautov9-hsi2c compatible Jaewon Kim
2021-11-15 18:56 ` Sam Protsenko
2021-11-19 8:57 ` Krzysztof Kozlowski
[not found] ` <CGME20211112010603epcas2p339d1a6ef3df7cdbe61c87c8afa541fd0@epcas2p3.samsung.com>
2021-11-12 1:01 ` [PATCH v3 2/2] i2c: exynos5: add support for ExynosAutov9 SoC Jaewon Kim
2021-11-12 8:09 ` Krzysztof Kozlowski
2021-11-15 18:55 ` Sam Protsenko
2021-11-16 1:12 ` Chanho Park
2021-11-16 9:31 ` Krzysztof Kozlowski
2021-11-16 15:31 ` Sam Protsenko
2021-11-19 8:51 ` Krzysztof Kozlowski
2021-11-18 19:59 ` Sam Protsenko
2021-11-19 8:54 ` Krzysztof Kozlowski
2021-11-19 14:12 ` Sam Protsenko
2021-11-22 2:51 ` Jaewon Kim
2021-11-17 22:17 ` David Virag [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ee9584833d948188347414991a117ca86edfaaf.camel@gmail.com \
--to=virag.david003@gmail.com \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jaewon02.kim@samsung.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).