From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jiucheng Xu <jiucheng.xu@amlogic.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v3 3/4] arm64: dts: meson: Add DDR PMU node
Date: Tue, 2 Aug 2022 10:05:18 +0200 [thread overview]
Message-ID: <9ef21f8e-163e-fc31-636d-c0d6d004f27f@linaro.org> (raw)
In-Reply-To: <20220801060049.1655177-3-jiucheng.xu@amlogic.com>
On 01/08/2022 08:00, Jiucheng Xu wrote:
> Add DDR PMU device node for G12 series SoC
>
> Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
> ---
> Changes v2 -> v3:
> - No change
>
> Changes v1 -> v2:
> - Remove model, dmc_nr, chann_nr properties
> - Add g12a-ddr-pmu, g12b-ddr-pmu, sm1-ddr-pmu compatibles as
> identifier
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 7 +++++++
> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 4 ++++
> arch/arm64/boot/dts/amlogic/meson-g12b.dtsi | 4 ++++
> arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 4 ++++
> 4 files changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 45947c1031c4..7e556fe575be 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -2146,6 +2146,13 @@ hdmi_tx_out: endpoint {
> };
> };
>
> + ddr_pmu: ddr_pmu@ff638000 {
> + compatible = "amlogic,g12-ddr-pmu";
No. Test your DTS against bindings first.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-02 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 6:00 [PATCH v3 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Jiucheng Xu
2022-08-01 6:00 ` [PATCH v3 2/4] docs/perf: Add documentation for the Amlogic G12 DDR PMU Jiucheng Xu
2022-08-01 6:00 ` [PATCH v3 3/4] arm64: dts: meson: Add DDR PMU node Jiucheng Xu
2022-08-02 8:05 ` Krzysztof Kozlowski [this message]
2022-08-01 6:00 ` [PATCH v3 4/4] dt-binding: perf: Add Amlogic DDR PMU Jiucheng Xu
2022-08-01 13:43 ` Rob Herring
2022-08-02 8:04 ` Krzysztof Kozlowski
2022-08-02 9:25 ` Jiucheng Xu
2022-08-02 12:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ef21f8e-163e-fc31-636d-c0d6d004f27f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jiucheng.xu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).