From: Peng Fan <peng.fan@oss.nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
haibo.chen@nxp.com, adrian.hunter@intel.com,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com,
cniedermaier@dh-electronics.com, devicetree@vger.kernel.org,
kernel@dh-electronics.com
Subject: Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"
Date: Tue, 23 May 2023 10:03:08 +0800 [thread overview]
Message-ID: <9ef80685-3ef7-ac59-05a6-0c46e0ecf57e@oss.nxp.com> (raw)
In-Reply-To: <d0329227-b579-5557-b449-7961ec0a1463@linaro.org>
On 5/6/2023 6:59 PM, Krzysztof Kozlowski wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
>
>
> On 06/05/2023 09:40, haibo.chen@nxp.com wrote:
>> From: Haibo Chen <haibo.chen@nxp.com>
>>
>> Driver do not use this property, so remove it here.
>
> You still need to expand the commit msg and justify why this property is
> being removed. "Driver" is vague, as it can be BSD driver which also
> might use this binding. Instead describe why this property should be
> removed, so we can understand also ABI implications.
The better approach would be mark it as deprecated.
Regards,
Peng.
>
>>
>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>>
>> ---
>> v2:
>> -fix dt-binding-check issue, also remove "fsl,wp-controller" in examples.
>> ---
>> Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------
>> 1 file changed, 6 deletions(-)
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-05-23 2:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 7:40 [PATCH v2 0/4] cd/wp code clean up for i.MX USDHC haibo.chen
2023-05-06 7:40 ` [PATCH v2 1/4] mmc: sdhci-esdhc-imx: remove unused enum cd_types haibo.chen
2023-05-19 10:37 ` Adrian Hunter
2023-05-06 7:40 ` [PATCH v2 2/4] mmc: sdhci-esdhc-imx: remove redundant write protect code haibo.chen
2023-05-19 10:36 ` Adrian Hunter
2023-06-01 7:50 ` Bough Chen
2023-05-06 7:40 ` [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller" haibo.chen
2023-05-06 10:59 ` Krzysztof Kozlowski
2023-05-23 2:03 ` Peng Fan [this message]
2023-06-08 17:44 ` Rob Herring
2023-05-06 7:40 ` [PATCH v2 4/4] arm: dts: imx: remove "fsl,wp-controller" since it is dropped haibo.chen
-- strict thread matches above, loose matches on Subject: below --
2023-05-05 10:12 [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller" haibo.chen
2023-05-05 17:47 ` Krzysztof Kozlowski
2023-05-06 2:37 ` Bough Chen
2023-05-06 6:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ef80685-3ef7-ac59-05a6-0c46e0ecf57e@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=adrian.hunter@intel.com \
--cc=cniedermaier@dh-electronics.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@dh-electronics.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).