From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7E9213E89 for ; Wed, 30 Jul 2025 20:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753907579; cv=none; b=JDW8ZuRcwJ5oKjyEfl7CgkLIISSS+c8HN0pfAMdHpumkF1F/NsjlkhF+kq++ELVBETZeKBhhPU72TCMsF4ObMhPl/AccAdeZhPYrIinsS3agUSZZb+4quAnB3i/WdTwd/gzT+Yor2NH7OwCvng8Fm9UgkyNDHA1h9PEYxfLW2J8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753907579; c=relaxed/simple; bh=uvt9rrj1TfF+mFhxIuv74KF8VgsvkHhZWRdK7kDoaas=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z0RhslSCav0V6DwYgN7UdDCUeho4DUBvSuyGUGbnzDDC/EILK9159KlHSdEh04Rj42KTSiiqsn4OHAFvyLLnEXe7Cdedi5UyRr8vCgzHWzChgQHjdpOu/nx1DyKn1cKSrl6NHrqsuUdxbZDvpRrWA7RtPs3GsZHN57nwa3k7aSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gCqu0Mr7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gCqu0Mr7" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56UCbGto006299 for ; Wed, 30 Jul 2025 20:32:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kmZ13PavdbM+7K9N+GS2cQ75CPBXi6rmaEREINxw3kc=; b=gCqu0Mr7cewK04W3 8Dnm3tg5cqm6HpMyiJMHz0DunSW/tU/aMfDr86ZneUpg3zt6GR/hz2Vq7z5amnVH c/PUlxAbLn6EaSNh+lhU+rUbRYkmNjReA5UWvo51OGQOYtB7uxMH6PyKw/GefuZI vz9UhPImWFkH+IeV8hNFkdK+qPElZBJMFOJS/tnsbLwcAjBfwrHvjiAhT0+5sXHI K0ceugQ/Pq0wjHBlSIryi37xYvZAaF3oqgpkw6uD8DKjlgZg7vSJkjLV9kJF/6uT yh9BQVAMVk7y2mqXNEfGLMjy/Q661zl/PlL0z4Ed98hZ/UMAbEDCLWUwWHiR0rg7 7mpTGQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 487jwg9ne4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 30 Jul 2025 20:32:57 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7e33e133f42so6889885a.3 for ; Wed, 30 Jul 2025 13:32:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753907576; x=1754512376; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kmZ13PavdbM+7K9N+GS2cQ75CPBXi6rmaEREINxw3kc=; b=OAcz26YodU6MmAxtSRiK0FXU40/zsbfOkuKk94HS88h+54Qd2X1EB3GKkKmFIpQKwP he/+Y5O44ZAi64u0sup+Szrx2PVPMKm3PSPk+EBw56zETxh36894BtZewgT67d4/u0Kd JZt5da9P+QrxEYCxQ6Dny5UkgKI4J3ScqzZ04hKLEMz7UYfbRxxq+6Vjq8tG6xODyDw0 0mlfQr++oTE+g7TsGW7inluDj75XNYXl06DN/ybk09loyqF7Rsxa/TOy7N5+8866KE7U rujyGQWH29Ut+gScUrW4dtCZGF4/9oZ4I7KzfOm4d/phDF4JZ8142bZyUrKJE9W87ecp NRZQ== X-Forwarded-Encrypted: i=1; AJvYcCV07imnMeoMMadzP8++TVtjzOrtHC9llZ3Vg9I3/rxvprZzwjOzmWAI4kRksdt0bfGsOkPJ7xrE4JoF@vger.kernel.org X-Gm-Message-State: AOJu0Yx0DBpn6SrazUwrZmgpMxM2zGLE13UIZW/zjsbYB00nf8YuFeUB uXZ5SeSB0xR1JTDPqJ+El4I2nLNngcP1VZp6yGDVAflrTvBjOzTv20267l5eB+jNBlxHyfT+auv BA4lpTfAJOawFI2EC+RR9+sLQJ9E4DNun9ymYUKH3GSz3N3gKxPenPtaLseBD5tnb X-Gm-Gg: ASbGncu3sxQB1Ls4WuzUQFLyYQNsEfoYVIu3uveLKwZ7Z7akl6Z1+KiPZAdzuFRkX+t 52yAlRrkSbj5fOF5OWM12m+0vdbkMclm3k+H3S3RZvmoDJQQdNL6w80uo9et5Z6oWiZSeeJefad VSx7/m0hykjK+/7Fu3/+kQmVqroxUxaOS9cZFFNlS2tmuB3O6xVkX0bwNlgJyhAgzRpIM1mPJzn IpR36FbAyVk5zVVFXbHE2kT5Fq1LQVuKdKnwdZbQaVzUeHTPvSFNnXhn0jpqpq1e1xmxRYXlejK mimMOLe5FQS6NUEVo4uYSY3V9kzTtn3W7sLdPUzQDjxU3xg2gZwq1Yza6K+twmIJcI0c6eEPCF1 UAEk5ZKgM4pOL62Fq7g== X-Received: by 2002:a05:620a:459f:b0:7e4:ca52:8ea1 with SMTP id af79cd13be357-7e66f376042mr320614085a.13.1753907575418; Wed, 30 Jul 2025 13:32:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSLNdW1IN7xY3Gba+7rda4ucNErpcsxk9NFfI63KFRacCoTX/l3Blyf4LmiJlM2wEwGkHBrw== X-Received: by 2002:a05:620a:459f:b0:7e4:ca52:8ea1 with SMTP id af79cd13be357-7e66f376042mr320611085a.13.1753907574863; Wed, 30 Jul 2025 13:32:54 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-615a8eff8f4sm48682a12.11.2025.07.30.13.32.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jul 2025 13:32:53 -0700 (PDT) Message-ID: <9efafa16-e6db-4227-9b47-5803f5933a7d@oss.qualcomm.com> Date: Wed, 30 Jul 2025 22:32:51 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: sc8280xp: Add initial support for Ntmer TW220 To: Pengyu Luo Cc: aliceryhl@google.com, andersson@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, ebiggers@google.com, ilpo.jarvinen@linux.intel.com, joel.granados@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, len.brown@intel.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, lossin@kernel.org, mingo@kernel.org, ojeda@kernel.org, robh@kernel.org, sfr@canb.auug.org.au, vanyang@smail.nju.edu.cn, viro@zeniv.linux.org.uk References: <20250706034303.5404-1-mitltlatltl@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=WvgrMcfv c=1 sm=1 tr=0 ts=688a8179 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=UX9tP_KbSWm2z_bZeVQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: hLhCYiSZWXLyrHYxOBl369LZDnTrrY3D X-Proofpoint-GUID: hLhCYiSZWXLyrHYxOBl369LZDnTrrY3D X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzMwMDE1MCBTYWx0ZWRfX1uyVF+9hQ6za SkLRH1K6Qt4iTF2gOiTTSFdafoVljYzK69XQ4vOw0bgAW8QnlXN/uPoP+HU4fZiRNaecC4AeTpv 16xiFhVzJRPLM1NDacYAzGpulHRrwUvgxuWSB9YOBlsZ6he8F4iewggpz9cSq7ZhdAI4sPXfvDd 8RHvQfQTJ9WP2YYyZoObq2JE+pP+4NGVcUQcIwbDerx4NCNP5n6MfwDCXgGwPSvmygmPrBoT9m7 hSfHXgcsSF2NrZwv56Sk85mpFY2RlJLwF8RuD3x0BMkgzDjAv/LelhOHHtM8xJHe3+xXPsPg2d0 Sl45AMTaHSuC93m1rRy8DgdEXIRHrSVg1RYOisy11Hm0JPLWn1aXfHg9cyAibid4AErbJE8lpnG 0NjJjQt+E4ZIAjV0VeF8wGT99VPppM3W7oOwSPY0QnAnq1uN17tArqzfqytJmo9qbeDqf/JT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-30_06,2025-07-30_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507300150 On 7/30/25 5:29 PM, Pengyu Luo wrote: > On Wed, Jul 30, 2025 at 8:53 PM Konrad Dybcio > wrote: >> >> On 7/6/25 5:43 AM, Pengyu Luo wrote: >>> On Sat, Jun 28, 2025 at 3:48 AM Konrad Dybcio wrote: >>>> On 6/17/25 11:29 AM, Pengyu Luo wrote: >>>>> The Ntmer TW220 is a WOS tablet based on the Qualcomm SC8280XP platform, >>>>> also known as the Robo&Kala 2-in-1 Laptop. Thanks to Hong for providing >>>>> the unlocked device and early development work. This patch adds an >>>>> initial device tree to enable basic functionality. >>>>> >>>>> Currently supported components include: >>>>> - Bluetooth & Wi-Fi (board file regeneration required) >>>>> - Battery charging (up to 15V/3A fixed PDO) and reporting via pmic-glink >>>>> - Flash LEDs (front and rear) >>>>> - Hall sensor (lid detection) >>>>> - Keyboard (via Bluetooth or USB) >>>>> - NVMe SSD >>>>> - Power and volume keys >>>>> - Simple-framebuffer >>>>> - Sound (playback and capture; top-left DMIC only, top-right works only >>>>> on Windows) >>>>> - Touchscreen and stylus (requires GPI DMA support [1] and stylus support [2]) >>>>> - USB Type-C ports >>>>> >>>>> The following components are currently non-functional: >>>>> - Cameras (GalaxyCore GC5035; only sensor ID is detectable, no frames in libcamera; >>>>> partial driver can be found on LKML archives) >>>>> - DSI display (blank screen with `dsi_err_worker: status=4`; primary DSI register >>>>> dump included below) >>>>> - Stylus wireless charger (CPS4035) >>>>> - UCSI over GLINK >>>>> >>>>> [1]: https://lore.kernel.org/linux-arm-msm/20250617090032.1487382-3-mitltlatltl@gmail.com >>>>> [2]: https://lore.kernel.org/linux-input/20250605054855.403487-2-mitltlatltl@gmail.com >>>>> >>>>> Note: This series does **not** include any confidential material. Those >>>>> who wish to run Linux on this device should contact Ntmer, as the >>>>> bootloader is locked via secure boot. >>>>> >>>>> Co-developed-by: Hong Zhu >>>>> Signed-off-by: Hong Zhu >>>>> Signed-off-by: Pengyu Luo >>>>> >>>>> dsi_ctrl, reg = <0 0x0ae94000 0 0x400>; >>>>> 0xae94000 20050001 000001f3 0000000b dddd1011 >>>> >>>> This is not something we want in the commit log >>>> >>> >>> I will remove it. I need help, then I attached it, two of my sc8280xp >>> devices require dsi to work. Reversing and guessing wasted a lot of >>> time. I will appreciate it if qcom could support it. >> >> There should be nothing interesting compared to what's on SM8350 when it >> comes to DSI on 8280. >> >> I would assume something's wrong with how your panel is being set up. > > Just to mention it. According to some public sources, the Adreno 1095 DPU > is included in the sm8350, while the Adreno 1199 DPU is included in the > sc8280xp, they are slightly different. Here is a quick comparison > > dpu_version dsi_version dsi_phy_version > Adreno 1095 DPU: 7.0 2.5.0 4.2 > Adreno 1199 DPU: 8.0 2.5.1 4.2 Patchlevel/step versions are usually not supposed to break any software interfaces, so I'd be *really* surprised if this is the case DPU is rather different (the one on 8280 is way larger than 8350's), but ultimately they're built of the same bricks > > The panel setup has been tweaked and tested countless times, I really don't > think I screwed it up. I had already brought up a lcd video panel with dual > dsi and dual dsc on the sm8650. On the sc8280xp, I’ve worked with two > different panels: > > - One LCD video panel with dual DSI and dual DSC > - One OLED video panel with dual DSI only > > Both fail to display anything and complain about DSI FIFO errors > (dsi_err_worker: status=4). Someone also encountered a similar issue on > the SC8180X([1]), another WoA platform. > > Anyway, I had quit. This doesn’t bother me anymore. Just mentioning the > info for reference. Sad to see you go. If you still want to, I saw a fix for a sneaky bug earlier today on LKML that may actually be related to your issue, given you seem to have a really high res panel.. https://lore.kernel.org/linux-arm-msm/20250730123938.1038640-1-quic_amakhija@quicinc.com/ Konrad