* drm/mediatek: fixup crtc event null pointer issue
@ 2022-03-14 7:42 Yongqiang Niu
2022-03-14 7:42 ` [PATCH v1, 1/1] " Yongqiang Niu
0 siblings, 1 reply; 4+ messages in thread
From: Yongqiang Niu @ 2022-03-14 7:42 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Rob Herring, Matthias Brugger, Philipp Zabel, David Airlie,
Daniel Vetter, Jassi Brar, Yongqiang Niu, Fabien Parent,
Dennis YC Hsieh, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
Hsin-Yi Wang
base linux v5.17-rc1
Yongqiang Niu (1):
drm/mediatek: fixup crtc event null pointer issue
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++
1 file changed, 3 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1, 1/1] drm/mediatek: fixup crtc event null pointer issue
2022-03-14 7:42 drm/mediatek: fixup crtc event null pointer issue Yongqiang Niu
@ 2022-03-14 7:42 ` Yongqiang Niu
2022-03-17 12:49 ` Rex-BC Chen
2022-03-28 9:34 ` CK Hu
0 siblings, 2 replies; 4+ messages in thread
From: Yongqiang Niu @ 2022-03-14 7:42 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Rob Herring, Matthias Brugger, Philipp Zabel, David Airlie,
Daniel Vetter, Jassi Brar, Yongqiang Niu, Fabien Parent,
Dennis YC Hsieh, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
Hsin-Yi Wang
if crtc event is null pointer, do not send vblank event
Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
index d661edf7e0fe..265fed446628 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
@@ -92,6 +92,9 @@ static void mtk_drm_crtc_finish_page_flip(struct mtk_drm_crtc *mtk_crtc)
struct drm_crtc *crtc = &mtk_crtc->base;
unsigned long flags;
+ if (!mtk_crtc->event)
+ return;
+
spin_lock_irqsave(&crtc->dev->event_lock, flags);
drm_crtc_send_vblank_event(crtc, mtk_crtc->event);
drm_crtc_vblank_put(crtc);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1, 1/1] drm/mediatek: fixup crtc event null pointer issue
2022-03-14 7:42 ` [PATCH v1, 1/1] " Yongqiang Niu
@ 2022-03-17 12:49 ` Rex-BC Chen
2022-03-28 9:34 ` CK Hu
1 sibling, 0 replies; 4+ messages in thread
From: Rex-BC Chen @ 2022-03-17 12:49 UTC (permalink / raw)
To: Yongqiang Niu, Chun-Kuang Hu
Cc: Rob Herring, Matthias Brugger, Philipp Zabel, David Airlie,
Daniel Vetter, Jassi Brar, Fabien Parent, Dennis YC Hsieh,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
dri-devel, Project_Global_Chrome_Upstream_Group, Hsin-Yi Wang
On Mon, 2022-03-14 at 15:42 +0800, Yongqiang Niu wrote:
> if crtc event is null pointer, do not send vblank event
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index d661edf7e0fe..265fed446628 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -92,6 +92,9 @@ static void mtk_drm_crtc_finish_page_flip(struct
> mtk_drm_crtc *mtk_crtc)
> struct drm_crtc *crtc = &mtk_crtc->base;
> unsigned long flags;
>
> + if (!mtk_crtc->event)
> + return;
> +
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> spin_lock_irqsave(&crtc->dev->event_lock, flags);
> drm_crtc_send_vblank_event(crtc, mtk_crtc->event);
> drm_crtc_vblank_put(crtc);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1, 1/1] drm/mediatek: fixup crtc event null pointer issue
2022-03-14 7:42 ` [PATCH v1, 1/1] " Yongqiang Niu
2022-03-17 12:49 ` Rex-BC Chen
@ 2022-03-28 9:34 ` CK Hu
1 sibling, 0 replies; 4+ messages in thread
From: CK Hu @ 2022-03-28 9:34 UTC (permalink / raw)
To: Yongqiang Niu, Chun-Kuang Hu
Cc: devicetree, Project_Global_Chrome_Upstream_Group, David Airlie,
Jassi Brar, linux-kernel, dri-devel, Dennis YC Hsieh,
Fabien Parent, Rob Herring, linux-mediatek, Hsin-Yi Wang,
Matthias Brugger, linux-arm-kernel
Hi, Yongqiang:
On Mon, 2022-03-14 at 15:42 +0800, Yongqiang Niu wrote:
> if crtc event is null pointer, do not send vblank event
This is a bug-fix, so add a Fixes tag here.
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index d661edf7e0fe..265fed446628 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -92,6 +92,9 @@ static void mtk_drm_crtc_finish_page_flip(struct
> mtk_drm_crtc *mtk_crtc)
> struct drm_crtc *crtc = &mtk_crtc->base;
> unsigned long flags;
>
> + if (!mtk_crtc->event)
> + return;
> +
> spin_lock_irqsave(&crtc->dev->event_lock, flags);
> drm_crtc_send_vblank_event(crtc, mtk_crtc->event);
I think pending_needs_vblank is used to protect this situation. It
seems that pending_needs_vblank should be protected by critical
section.
Regards,
CK
> drm_crtc_vblank_put(crtc);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-28 9:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-14 7:42 drm/mediatek: fixup crtc event null pointer issue Yongqiang Niu
2022-03-14 7:42 ` [PATCH v1, 1/1] " Yongqiang Niu
2022-03-17 12:49 ` Rex-BC Chen
2022-03-28 9:34 ` CK Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).