From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD0541BFE00 for ; Mon, 11 Aug 2025 07:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754898012; cv=none; b=b2Dva1uuUNzrkx41PtL5eZmmf+Q+1srcE9nyqt86MDjh6AHFmVS70CMfJ9/uhtvlgpXQ+GANr4+f6WvMwAoA8ys9V122o3tbJDfGoIkBNakIyKoyRb+RtNNjcGS1Iixq+esFlrwuxhantdn9/CYWnzPt8qQevRbFy4Hk9leUKI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754898012; c=relaxed/simple; bh=WaxqPwe60aGUkhXsZ36hb/BaEfdKvftcdVEBEnneZvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZOSK0D5aFHfbELcl2hzzk+4VMBJhuBEsOqbDMJ6XEFvSrZwUMNk/rTS8MyuEgXfEtbZbPe0elVLUqFe2HMB0JE+VitcVjpiVBa38pwUy50ogW13wuf2zCK5S70nyqpKZ6c+/adpasKrT+kjTjn9ruPcptaYxceXzK1u+lF9pqbQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n/8nidds; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n/8nidds" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-455b00339c8so25034165e9.3 for ; Mon, 11 Aug 2025 00:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754898008; x=1755502808; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=POALZcOL5uP4hmBAgsW0NLC3bq36nPwjL/gPbRn+/O8=; b=n/8niddsEqxjRK+EuEcwA4m1Kh1sxcGL6NLj0rmLanaJTpojCV4ycONQpR4x49mWPN 7vdDpbJZJgcNjatAH6ZxCpNgqMYTP1XIt+YuQ/ZmqiejOUkOV3dT+VNMOJTGeDiTJe1k TQEbGW4t1otUFMYXSJGrkCCApw1JgndqA/iOw4mz0/qBM/Q1ovVO7T8lyeBFNcPrmw3d dRJhn5wDx46V+3PpG4CA0Z4bv22vXzxO69bSA/tegMrohqFznXtRxSoqIIXe/ZES2MCS dO1Bl+Bp4qe2UWEKhXbCfuh6dSrGoe5ag4u0zlQCGXsX++tJL0OMP0V3IIXdts8ool5C nLAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754898008; x=1755502808; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=POALZcOL5uP4hmBAgsW0NLC3bq36nPwjL/gPbRn+/O8=; b=mf9HrDI77ExXId1HSOA4JB8Q+mN4B68ypZwhATOMXAqvvCzeSGpOvHAVtE25L5RrhF rbMu91dYcgoN+z7Pcvewae7SzB7CqniZ+B3N9nOAwJlprqTvw89d1wFpNURlofgBdOhZ 15vQDxWRz84/WySjBcNp3+Z5TFLBh5epdAIEwWKrQRczLnuENqyw1OjEElvbcdc3mVAQ dxzaPVTBFdxU3ZrLL6UMLUbTGK8CJi7w7roz9AyBJv9QM88k0a8wAZcifvM/hENyVdkL Dq8pwIld/+sw4Fay5Y3sUbGVwD8aCuRA4KvflLm+fH/A9Blg1ZoxMshX8wv+7eBOIvcI ERCQ== X-Forwarded-Encrypted: i=1; AJvYcCUfudBKWaHQ7BCP8Z+NoJS1jeIII5yI6JFFuF5XgbR3Qg82nECOeEJMBFTux2QME/OSJH5u+ATpC9OE@vger.kernel.org X-Gm-Message-State: AOJu0YyHjvI8mG7gh7+vuab/Vj7qfivWrYItOsn56OBJzpI/buAo3FjS BEj2woGve4WKh90WeFlmLgoH04AYRfBn4jDeang2BcRuFR3zzxy/lBiWUAsRJyrJsK8= X-Gm-Gg: ASbGncuDTiLn3LfKV96suYpJMNl9uZBAy6tHhQo0oGqjy50WfXKHvOYgtFdUBdH7yCd n8y8n0NMk8Ss+h7xayqncAuLV/mm8hZVsmchXnGQeCYT3LbRqNn7LcdllpIGHiufEIvfl563shS PhXBFU+3o/CysoxHf0g8VJCvW5IHFqJfeBHeEBzTpb1vmtal/MoC3X2WxjaAtWWYNV/NRW7w3QO /j+y3TUMggpz/zIA2nhNxAtRudMYwDjJzQY4m1Mp66zcKOkiHcu5op9qRDhGjRLxjf1d2pqz/Rk 8h5OC5ZlVs3Ye05ME0EySJSEWC4GbQWenYp1JjQhX0fSFSPLHrCkwcxREZw3grA47YezZLNDT4O wMg6CsnjrW6ei2f14zhdErEcXm0WjaMieoZOhz7gLbOvfY7U2p07k8GkeZOy/yp2iNTZwB/XK+1 xcpeKk8RNlxQ== X-Google-Smtp-Source: AGHT+IH4eA/RKU/GboTJ9VfoA/pYzZzZec5od8RkolpPdI5Ifcjq96waQtwfFh9MBuje3p8eQLal9g== X-Received: by 2002:a05:600c:1c83:b0:456:2698:d4d9 with SMTP id 5b1f17b1804b1-459f4f2e2eemr97639165e9.3.1754898008092; Mon, 11 Aug 2025 00:40:08 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:b0fa:b045:4b82:de09? ([2a01:e0a:3d9:2080:b0fa:b045:4b82:de09]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459dbba5210sm314243925e9.2.2025.08.11.00.40.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Aug 2025 00:40:07 -0700 (PDT) Message-ID: <9f2bdd43-da4c-47b2-bba5-d69bc0b06ac7@linaro.org> Date: Mon, 11 Aug 2025 09:40:06 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH v4 2/6] phy: qcom: qmp-combo: Rename 'mode' to 'phy_mode' To: Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Dmitry Baryshkov References: <20250807-topic-4ln_dp_respin-v4-0-43272d6eca92@oss.qualcomm.com> <20250807-topic-4ln_dp_respin-v4-2-43272d6eca92@oss.qualcomm.com> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250807-topic-4ln_dp_respin-v4-2-43272d6eca92@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2025 18:33, Konrad Dybcio wrote: > From: Konrad Dybcio > > There are a numbers of ""modes"" involved: USB mode, Type-C mode (with > its altmodes), phy_mode and QMP_PHY mode (DP/combo/USB/off). > > Rename the generic sounding 'mode' to 'phy_mode' to hopefully make > the code easier to follow. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index f07d097b129fb7b3fad003103b7468b16c1c4390..30749943f66280c3aa9e9673466f6f736d1adbc8 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -1846,7 +1846,7 @@ struct qmp_combo { > int init_count; > > struct phy *usb_phy; > - enum phy_mode mode; > + enum phy_mode phy_mode; > unsigned int usb_init_count; > > struct phy *dp_phy; > @@ -3282,7 +3282,7 @@ static int qmp_combo_usb_set_mode(struct phy *phy, enum phy_mode mode, int submo > { > struct qmp_combo *qmp = phy_get_drvdata(phy); > > - qmp->mode = mode; > + qmp->phy_mode = mode; > > return 0; > } > @@ -3311,8 +3311,8 @@ static void qmp_combo_enable_autonomous_mode(struct qmp_combo *qmp) > void __iomem *pcs_misc = qmp->pcs_misc; > u32 intr_mask; > > - if (qmp->mode == PHY_MODE_USB_HOST_SS || > - qmp->mode == PHY_MODE_USB_DEVICE_SS) > + if (qmp->phy_mode == PHY_MODE_USB_HOST_SS || > + qmp->phy_mode == PHY_MODE_USB_DEVICE_SS) > intr_mask = ARCVR_DTCT_EN | ALFPS_DTCT_EN; > else > intr_mask = ARCVR_DTCT_EN | ARCVR_DTCT_EVENT_SEL; > @@ -3355,7 +3355,7 @@ static int __maybe_unused qmp_combo_runtime_suspend(struct device *dev) > { > struct qmp_combo *qmp = dev_get_drvdata(dev); > > - dev_vdbg(dev, "Suspending QMP phy, mode:%d\n", qmp->mode); > + dev_vdbg(dev, "Suspending QMP phy, mode:%d\n", qmp->phy_mode); > > if (!qmp->init_count) { > dev_vdbg(dev, "PHY not initialized, bailing out\n"); > @@ -3375,7 +3375,7 @@ static int __maybe_unused qmp_combo_runtime_resume(struct device *dev) > struct qmp_combo *qmp = dev_get_drvdata(dev); > int ret = 0; > > - dev_vdbg(dev, "Resuming QMP phy, mode:%d\n", qmp->mode); > + dev_vdbg(dev, "Resuming QMP phy, mode:%d\n", qmp->phy_mode); > > if (!qmp->init_count) { > dev_vdbg(dev, "PHY not initialized, bailing out\n"); > Reviewed-by: Neil Armstrong