devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hui Wang <hui.wang@canonical.com>,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org
Cc: jirislaby@kernel.org, hvilleneuve@dimonoff.com
Subject: Re: [PATCH 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios
Date: Tue, 4 Jun 2024 08:54:54 +0200	[thread overview]
Message-ID: <9f41e66a-3545-4b23-b34e-608fd36fb2ea@kernel.org> (raw)
In-Reply-To: <20240603123710.649549-1-hui.wang@canonical.com>

On 03/06/2024 14:37, Hui Wang wrote:
> In some designs, the chip reset pin is connected to a gpio, this
> gpio needs to be set correctly before probing the driver, so adding
> a reset-gpios in the device tree.
> 
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>  Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 4 ++++
>  1 file changed, 4 insertions(+)

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof


  parent reply	other threads:[~2024-06-04  6:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-03 12:37 [PATCH 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios Hui Wang
2024-06-03 12:37 ` [PATCH 2/2] serial: sc16is7xx: setup reset pin if it is defined in device tree Hui Wang
2024-06-03 13:11   ` Hugo Villeneuve
2024-06-04 10:34     ` Hui Wang
2024-06-03 13:18 ` [PATCH 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios Rob Herring
2024-06-04 10:35   ` Hui Wang
2024-06-04  6:54 ` Krzysztof Kozlowski [this message]
2024-06-04 10:35   ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f41e66a-3545-4b23-b34e-608fd36fb2ea@kernel.org \
    --to=krzk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hui.wang@canonical.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).