From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tanmay Shah <tanmays@amd.com>, Tanmay Shah <tanmay.shah@amd.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: sram: Tightly Coupled Memory (TCM) bindings
Date: Sun, 15 Jan 2023 15:38:33 +0100 [thread overview]
Message-ID: <9f4994de-e468-43ea-f8db-d4a37ebc30e0@linaro.org> (raw)
In-Reply-To: <b79f7e0a-8048-d0e1-ad0b-d15d72288fde@amd.com>
On 13/01/2023 19:08, Tanmay Shah wrote:
>
> On 1/12/23 11:52 PM, Krzysztof Kozlowski wrote:
>> On 13/01/2023 08:30, Tanmay Shah wrote:
>>> This patch introduces bindings for TCM memory address space on AMD-xilinx
>>> platforms. As of now TCM addresses are hardcoded in xilinx remoteproc
>>> driver. This bindings will help in defining TCM in device-tree and
>>> make it's access platform agnostic and data-driven from the driver.
>>>
>> Subject: drop second/last, redundant "bindings". The "dt-bindings"
>> prefix is already stating that these are bindings.
>
> Ack.
>
>
>>
>> Where is driver or DTS? Are you now adding a dead binding without users?
>
>
> TCM is used by drivers/remoteproc/xlnx_r5_remoteproc.c driver. Howerver,
> we have hardcode addresses in TCM as bindings are not available yet.
I don't see usage of these compatibles there. You also did not supply
DTS here. Please provide users of bindings within the same patchset.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-15 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 7:30 [PATCH] dt-bindings: sram: Tightly Coupled Memory (TCM) bindings Tanmay Shah
2023-01-13 7:52 ` Krzysztof Kozlowski
2023-01-13 18:04 ` Tanmay Shah
2023-01-15 14:45 ` Krzysztof Kozlowski
2023-01-16 18:17 ` Tanmay Shah
2023-01-17 8:13 ` Krzysztof Kozlowski
2023-01-13 7:52 ` Krzysztof Kozlowski
2023-01-13 18:08 ` Tanmay Shah
2023-01-15 14:38 ` Krzysztof Kozlowski [this message]
2023-01-16 17:43 ` Tanmay Shah
2023-01-17 8:16 ` Krzysztof Kozlowski
2023-01-18 19:23 ` Tanmay Shah
2023-01-13 13:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f4994de-e468-43ea-f8db-d4a37ebc30e0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tanmay.shah@amd.com \
--cc=tanmays@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).