From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Yang <mmyangfl@gmail.com>
Cc: Wei Xu <xuwei5@hisilicon.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/4] dt-bindings: arm: hisilicon: Add Hi37xx SoCs
Date: Fri, 17 Mar 2023 10:02:46 +0100 [thread overview]
Message-ID: <9f4cef36-d6cd-367d-161c-5dc78572f2dc@linaro.org> (raw)
In-Reply-To: <20230317085347.10147-5-mmyangfl@gmail.com>
On 17/03/2023 09:53, David Yang wrote:
> Add devicetree binding for Hisilicon Hi37xx SoCs.
>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
> .../bindings/arm/hisilicon/hisilicon.yaml | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml
> index 540876322..0e0fcb1c7 100644
> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml
> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml
> @@ -25,11 +25,39 @@ properties:
> - const: hisilicon,hi3670-hikey970
> - const: hisilicon,hi3670
>
> + - description: Hi3716cv200 based boards.
> + items:
> + - const: hisilicon,hi3716cv200
None of these here are correct compatibles for boards. Board compatible
has minimum two pieces: board compatible and SoC compatible.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-17 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230317085347.10147-1-mmyangfl@gmail.com>
2023-03-17 8:53 ` [PATCH v2 4/4] dt-bindings: arm: hisilicon: Add Hi37xx SoCs David Yang
2023-03-17 9:02 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f4cef36-d6cd-367d-161c-5dc78572f2dc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mmyangfl@gmail.com \
--cc=robh+dt@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).