* [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files
@ 2023-03-02 21:11 Douglas Anderson
2023-03-02 21:11 ` [PATCH v2 1/4] arm64: dts: qcom: sc7180: Delete wormdingler-rev0 Douglas Anderson
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Douglas Anderson @ 2023-03-02 21:11 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, mka, swboyd, Douglas Anderson, Andy Gross,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm,
linux-kernel
In general on ChromeOS we try hard not to throw away perfectly good
hardware, even if it has a few quirks. Many people keep early versions
of boards around indefinitely and keep using them for testing /
development if the feature they're working on doesn't need the latest
and greatest. This is the reason why there are so many sc7180-trogdor
device tree files.
That being said, _very_ early hardware tends not to be kept. -rev0
hardware tends (not always) to be prototype hardware and often comes
as a pile of parts. People are really only willing to put up with this
for so long. Even if it's not a pile of parts, -rev0 tends to be a
very small production run and isn't widely distributed. That means
that, by and large, we can eventually drop support for -rev0. Here,
we'll do that for kingoftown and wormdingler, and lazor.
While looking at the -rev0 of mrbland, I noticed that mrbland appears
to be long dead and unlikely to be revived. Let's just fully delete
it.
Changes in v2:
- Also delete "sc7180-trogdor-wormdingler-rev0.dtsi" (Konrad)
- Get rid of kingoftown.dtsi and merge into dts (Konrad)
Douglas Anderson (4):
arm64: dts: qcom: sc7180: Delete wormdingler-rev0
arm64: dts: qcom: sc7180: Delete kingoftown-rev0
arm64: dts: qcom: sc7180: Delete lazor-rev0
arm64: dts: qcom: sc7180: Delete mrbland
arch/arm64/boot/dts/qcom/Makefile | 10 +-
.../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 38 ---
.../dts/qcom/sc7180-trogdor-kingoftown-r1.dts | 17 -
...own.dtsi => sc7180-trogdor-kingoftown.dts} | 10 +-
.../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 34 --
.../qcom/sc7180-trogdor-mrbland-rev0-auo.dts | 22 --
.../qcom/sc7180-trogdor-mrbland-rev0-boe.dts | 22 --
.../dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi | 36 --
.../qcom/sc7180-trogdor-mrbland-rev1-auo.dts | 22 --
.../qcom/sc7180-trogdor-mrbland-rev1-boe.dts | 24 --
.../boot/dts/qcom/sc7180-trogdor-mrbland.dtsi | 320 ------------------
.../sc7180-trogdor-wormdingler-rev0-boe.dts | 22 --
.../sc7180-trogdor-wormdingler-rev0-inx.dts | 22 --
.../qcom/sc7180-trogdor-wormdingler-rev0.dtsi | 36 --
14 files changed, 10 insertions(+), 625 deletions(-)
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts
rename arch/arm64/boot/dts/qcom/{sc7180-trogdor-kingoftown.dtsi => sc7180-trogdor-kingoftown.dts} (95%)
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dts
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dts
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dts
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dts
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts
delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi
--
2.40.0.rc0.216.gc4246ad0f0-goog
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 1/4] arm64: dts: qcom: sc7180: Delete wormdingler-rev0 2023-03-02 21:11 [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Douglas Anderson @ 2023-03-02 21:11 ` Douglas Anderson 2023-03-03 0:47 ` Konrad Dybcio 2023-03-02 21:11 ` [PATCH v2 2/4] arm64: dts: qcom: sc7180: Delete kingoftown-rev0 Douglas Anderson ` (3 subsequent siblings) 4 siblings, 1 reply; 8+ messages in thread From: Douglas Anderson @ 2023-03-02 21:11 UTC (permalink / raw) To: Bjorn Andersson Cc: Konrad Dybcio, mka, swboyd, Douglas Anderson, Andy Gross, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, linux-kernel The earliest wormdingler I could find in my pile of hardware is -rev1. I believe that -rev0 boards were just distributed as a pile of components with no case. At this point I can't imagine anyone needing to make wormdingler-rev0 work, so let's delete support for it. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Changes in v2: - Also delete "sc7180-trogdor-wormdingler-rev0.dtsi" (Konrad) arch/arm64/boot/dts/qcom/Makefile | 2 -- .../sc7180-trogdor-wormdingler-rev0-boe.dts | 22 ------------ .../sc7180-trogdor-wormdingler-rev0-inx.dts | 22 ------------ .../qcom/sc7180-trogdor-wormdingler-rev0.dtsi | 36 ------------------- 4 files changed, 82 deletions(-) delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 31aa54f0428c..a51060378ddc 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -118,8 +118,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r3.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r3-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-quackingstick-r0.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-quackingstick-r0-lte.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev0-boe.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev0-inx.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-inx.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts deleted file mode 100644 index d6ed7d0afe4a..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts +++ /dev/null @@ -1,22 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Wormdingler board device tree source - * - * Copyright 2021 Google LLC. - * - * SKU: 0x10 => 16 - * - bits 7..4: Panel ID: 0x1 (BOE) - */ - -/dts-v1/; - -#include "sc7180-trogdor-wormdingler-rev0.dtsi" - -/ { - model = "Google Wormdingler rev0 BOE panel board"; - compatible = "google,wormdingler-rev0-sku16", "qcom,sc7180"; -}; - -&panel { - compatible = "boe,tv110c9m-ll3"; -}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts deleted file mode 100644 index c03525ea64ca..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts +++ /dev/null @@ -1,22 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Wormdingler board device tree source - * - * Copyright 2021 Google LLC. - * - * SKU: 0x0 => 0 - * - bits 7..4: Panel ID: 0x0 (INX) - */ - -/dts-v1/; - -#include "sc7180-trogdor-wormdingler-rev0.dtsi" - -/ { - model = "Google Wormdingler rev0 INX panel board"; - compatible = "google,wormdingler-rev0-sku0", "qcom,sc7180"; -}; - -&panel { - compatible = "innolux,hj110iz-01a"; -}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi deleted file mode 100644 index 7f272c6e95f6..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi +++ /dev/null @@ -1,36 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Wormdingler board device tree source - * - * Copyright 2021 Google LLC. - * - */ - -/dts-v1/; - -#include "sc7180-trogdor-wormdingler.dtsi" - -&avdd_lcd { - gpio = <&tlmm 80 GPIO_ACTIVE_HIGH>; -}; - -&panel { - enable-gpios = <&tlmm 76 GPIO_ACTIVE_HIGH>; -}; - -&v1p8_mipi { - gpio = <&tlmm 81 GPIO_ACTIVE_HIGH>; -}; - -/* PINCTRL - modifications to sc7180-trogdor-wormdingler.dtsi */ -&avdd_lcd_en { - pins = "gpio80"; -}; - -&mipi_1800_en { - pins = "gpio81"; -}; - -&vdd_reset_1800 { - pins = "gpio76"; -}; -- 2.40.0.rc0.216.gc4246ad0f0-goog ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/4] arm64: dts: qcom: sc7180: Delete wormdingler-rev0 2023-03-02 21:11 ` [PATCH v2 1/4] arm64: dts: qcom: sc7180: Delete wormdingler-rev0 Douglas Anderson @ 2023-03-03 0:47 ` Konrad Dybcio 0 siblings, 0 replies; 8+ messages in thread From: Konrad Dybcio @ 2023-03-03 0:47 UTC (permalink / raw) To: Douglas Anderson, Bjorn Andersson Cc: mka, swboyd, Andy Gross, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, linux-kernel On 2.03.2023 22:11, Douglas Anderson wrote: > The earliest wormdingler I could find in my pile of hardware is > -rev1. I believe that -rev0 boards were just distributed as a pile of > components with no case. At this point I can't imagine anyone needing > to make wormdingler-rev0 work, so let's delete support for it. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Changes in v2: > - Also delete "sc7180-trogdor-wormdingler-rev0.dtsi" (Konrad) > > arch/arm64/boot/dts/qcom/Makefile | 2 -- > .../sc7180-trogdor-wormdingler-rev0-boe.dts | 22 ------------ > .../sc7180-trogdor-wormdingler-rev0-inx.dts | 22 ------------ > .../qcom/sc7180-trogdor-wormdingler-rev0.dtsi | 36 ------------------- > 4 files changed, 82 deletions(-) > delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts > delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts > delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 31aa54f0428c..a51060378ddc 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -118,8 +118,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r3-lte.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-quackingstick-r0.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-quackingstick-r0-lte.dtb > -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev0-boe.dtb > -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev0-inx.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-inx.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts > deleted file mode 100644 > index d6ed7d0afe4a..000000000000 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts > +++ /dev/null > @@ -1,22 +0,0 @@ > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > -/* > - * Google Wormdingler board device tree source > - * > - * Copyright 2021 Google LLC. > - * > - * SKU: 0x10 => 16 > - * - bits 7..4: Panel ID: 0x1 (BOE) > - */ > - > -/dts-v1/; > - > -#include "sc7180-trogdor-wormdingler-rev0.dtsi" > - > -/ { > - model = "Google Wormdingler rev0 BOE panel board"; > - compatible = "google,wormdingler-rev0-sku16", "qcom,sc7180"; > -}; > - > -&panel { > - compatible = "boe,tv110c9m-ll3"; > -}; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts > deleted file mode 100644 > index c03525ea64ca..000000000000 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts > +++ /dev/null > @@ -1,22 +0,0 @@ > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > -/* > - * Google Wormdingler board device tree source > - * > - * Copyright 2021 Google LLC. > - * > - * SKU: 0x0 => 0 > - * - bits 7..4: Panel ID: 0x0 (INX) > - */ > - > -/dts-v1/; > - > -#include "sc7180-trogdor-wormdingler-rev0.dtsi" > - > -/ { > - model = "Google Wormdingler rev0 INX panel board"; > - compatible = "google,wormdingler-rev0-sku0", "qcom,sc7180"; > -}; > - > -&panel { > - compatible = "innolux,hj110iz-01a"; > -}; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi > deleted file mode 100644 > index 7f272c6e95f6..000000000000 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi > +++ /dev/null > @@ -1,36 +0,0 @@ > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > -/* > - * Google Wormdingler board device tree source > - * > - * Copyright 2021 Google LLC. > - * > - */ > - > -/dts-v1/; > - > -#include "sc7180-trogdor-wormdingler.dtsi" > - > -&avdd_lcd { > - gpio = <&tlmm 80 GPIO_ACTIVE_HIGH>; > -}; > - > -&panel { > - enable-gpios = <&tlmm 76 GPIO_ACTIVE_HIGH>; > -}; > - > -&v1p8_mipi { > - gpio = <&tlmm 81 GPIO_ACTIVE_HIGH>; > -}; > - > -/* PINCTRL - modifications to sc7180-trogdor-wormdingler.dtsi */ > -&avdd_lcd_en { > - pins = "gpio80"; > -}; > - > -&mipi_1800_en { > - pins = "gpio81"; > -}; > - > -&vdd_reset_1800 { > - pins = "gpio76"; > -}; ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/4] arm64: dts: qcom: sc7180: Delete kingoftown-rev0 2023-03-02 21:11 [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Douglas Anderson 2023-03-02 21:11 ` [PATCH v2 1/4] arm64: dts: qcom: sc7180: Delete wormdingler-rev0 Douglas Anderson @ 2023-03-02 21:11 ` Douglas Anderson 2023-03-03 0:48 ` Konrad Dybcio 2023-03-02 21:11 ` [PATCH v2 3/4] arm64: dts: qcom: sc7180: Delete lazor-rev0 Douglas Anderson ` (2 subsequent siblings) 4 siblings, 1 reply; 8+ messages in thread From: Douglas Anderson @ 2023-03-02 21:11 UTC (permalink / raw) To: Bjorn Andersson Cc: Konrad Dybcio, mka, swboyd, Douglas Anderson, Andy Gross, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, linux-kernel The earliest kingoftown that I could find in my pile of boards was -rev2 and even that revision looks pretty rough (plastics on the case are very unfinished). Though I don't actually have details about how many -rev0 devices were produced, I can't imagine anyone still using one. Let's delete support. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Changes in v2: - Get rid of kingoftown.dtsi and merge into dts (Konrad) arch/arm64/boot/dts/qcom/Makefile | 3 +- .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 38 ------------------- .../dts/qcom/sc7180-trogdor-kingoftown-r1.dts | 17 --------- ...own.dtsi => sc7180-trogdor-kingoftown.dts} | 10 ++++- 4 files changed, 10 insertions(+), 58 deletions(-) delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts rename arch/arm64/boot/dts/qcom/{sc7180-trogdor-kingoftown.dtsi => sc7180-trogdor-kingoftown.dts} (95%) diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index a51060378ddc..3ce51093ed8f 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -83,8 +83,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r2.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r3.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r4.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown-r0.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown-r1.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r0.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1-kb.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts deleted file mode 100644 index 3abd6222fe46..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts +++ /dev/null @@ -1,38 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Kingoftown board device tree source - * - * Copyright 2021 Google LLC. - */ - -/dts-v1/; - -#include "sc7180-trogdor.dtsi" -#include "sc7180-trogdor-ti-sn65dsi86.dtsi" -#include "sc7180-trogdor-kingoftown.dtsi" - -/ { - model = "Google Kingoftown (rev0)"; - compatible = "google,kingoftown-rev0", "qcom,sc7180"; -}; - -/* - * In rev1+, the enable pin of pp3300_fp_tp will be tied to pp1800_l10a - * power rail instead, since kingoftown does not have FP. - */ -&pp3300_fp_tp { - gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>; - enable-active-high; - - pinctrl-names = "default"; - pinctrl-0 = <&en_fp_rails>; -}; - -&tlmm { - en_fp_rails: en-fp-rails-state { - pins = "gpio74"; - function = "gpio"; - drive-strength = <2>; - bias-disable; - }; -}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts deleted file mode 100644 index e0752ba7df11..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts +++ /dev/null @@ -1,17 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Kingoftown board device tree source - * - * Copyright 2021 Google LLC. - */ - -/dts-v1/; - -#include "sc7180-trogdor.dtsi" -#include "sc7180-trogdor-parade-ps8640.dtsi" -#include "sc7180-trogdor-kingoftown.dtsi" - -/ { - model = "Google Kingoftown (rev1+)"; - compatible = "google,kingoftown", "qcom,sc7180"; -}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts similarity index 95% rename from arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi rename to arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts index 315ac5eb5f78..36326ef972dc 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts @@ -5,10 +5,18 @@ * Copyright 2021 Google LLC. */ -/* This file must be included after sc7180-trogdor.dtsi */ +/dts-v1/; + +#include "sc7180-trogdor.dtsi" +#include "sc7180-trogdor-parade-ps8640.dtsi" #include <arm/cros-ec-keyboard.dtsi> #include "sc7180-trogdor-lte-sku.dtsi" +/ { + model = "Google Kingoftown"; + compatible = "google,kingoftown", "qcom,sc7180"; +}; + &alc5682 { compatible = "realtek,rt5682s"; /delete-property/ VBAT-supply; -- 2.40.0.rc0.216.gc4246ad0f0-goog ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: qcom: sc7180: Delete kingoftown-rev0 2023-03-02 21:11 ` [PATCH v2 2/4] arm64: dts: qcom: sc7180: Delete kingoftown-rev0 Douglas Anderson @ 2023-03-03 0:48 ` Konrad Dybcio 0 siblings, 0 replies; 8+ messages in thread From: Konrad Dybcio @ 2023-03-03 0:48 UTC (permalink / raw) To: Douglas Anderson, Bjorn Andersson Cc: mka, swboyd, Andy Gross, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, linux-kernel On 2.03.2023 22:11, Douglas Anderson wrote: > The earliest kingoftown that I could find in my pile of boards was > -rev2 and even that revision looks pretty rough (plastics on the case > are very unfinished). Though I don't actually have details about how > many -rev0 devices were produced, I can't imagine anyone still using > one. Let's delete support. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Changes in v2: > - Get rid of kingoftown.dtsi and merge into dts (Konrad) > > arch/arm64/boot/dts/qcom/Makefile | 3 +- > .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 38 ------------------- > .../dts/qcom/sc7180-trogdor-kingoftown-r1.dts | 17 --------- > ...own.dtsi => sc7180-trogdor-kingoftown.dts} | 10 ++++- > 4 files changed, 10 insertions(+), 58 deletions(-) > delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts > delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts > rename arch/arm64/boot/dts/qcom/{sc7180-trogdor-kingoftown.dtsi => sc7180-trogdor-kingoftown.dts} (95%) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index a51060378ddc..3ce51093ed8f 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -83,8 +83,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3-lte.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r4.dtb > -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown-r0.dtb > -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown-r1.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r0.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1-kb.dtb > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts > deleted file mode 100644 > index 3abd6222fe46..000000000000 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts > +++ /dev/null > @@ -1,38 +0,0 @@ > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > -/* > - * Google Kingoftown board device tree source > - * > - * Copyright 2021 Google LLC. > - */ > - > -/dts-v1/; > - > -#include "sc7180-trogdor.dtsi" > -#include "sc7180-trogdor-ti-sn65dsi86.dtsi" > -#include "sc7180-trogdor-kingoftown.dtsi" > - > -/ { > - model = "Google Kingoftown (rev0)"; > - compatible = "google,kingoftown-rev0", "qcom,sc7180"; > -}; > - > -/* > - * In rev1+, the enable pin of pp3300_fp_tp will be tied to pp1800_l10a > - * power rail instead, since kingoftown does not have FP. > - */ > -&pp3300_fp_tp { > - gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>; > - enable-active-high; > - > - pinctrl-names = "default"; > - pinctrl-0 = <&en_fp_rails>; > -}; > - > -&tlmm { > - en_fp_rails: en-fp-rails-state { > - pins = "gpio74"; > - function = "gpio"; > - drive-strength = <2>; > - bias-disable; > - }; > -}; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts > deleted file mode 100644 > index e0752ba7df11..000000000000 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts > +++ /dev/null > @@ -1,17 +0,0 @@ > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > -/* > - * Google Kingoftown board device tree source > - * > - * Copyright 2021 Google LLC. > - */ > - > -/dts-v1/; > - > -#include "sc7180-trogdor.dtsi" > -#include "sc7180-trogdor-parade-ps8640.dtsi" > -#include "sc7180-trogdor-kingoftown.dtsi" > - > -/ { > - model = "Google Kingoftown (rev1+)"; > - compatible = "google,kingoftown", "qcom,sc7180"; > -}; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts > similarity index 95% > rename from arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi > rename to arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts > index 315ac5eb5f78..36326ef972dc 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts > @@ -5,10 +5,18 @@ > * Copyright 2021 Google LLC. > */ > > -/* This file must be included after sc7180-trogdor.dtsi */ > +/dts-v1/; > + > +#include "sc7180-trogdor.dtsi" > +#include "sc7180-trogdor-parade-ps8640.dtsi" > #include <arm/cros-ec-keyboard.dtsi> > #include "sc7180-trogdor-lte-sku.dtsi" > > +/ { > + model = "Google Kingoftown"; > + compatible = "google,kingoftown", "qcom,sc7180"; > +}; > + > &alc5682 { > compatible = "realtek,rt5682s"; > /delete-property/ VBAT-supply; ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 3/4] arm64: dts: qcom: sc7180: Delete lazor-rev0 2023-03-02 21:11 [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Douglas Anderson 2023-03-02 21:11 ` [PATCH v2 1/4] arm64: dts: qcom: sc7180: Delete wormdingler-rev0 Douglas Anderson 2023-03-02 21:11 ` [PATCH v2 2/4] arm64: dts: qcom: sc7180: Delete kingoftown-rev0 Douglas Anderson @ 2023-03-02 21:11 ` Douglas Anderson 2023-03-02 21:11 ` [PATCH v2 4/4] arm64: dts: qcom: sc7180: Delete mrbland Douglas Anderson 2023-03-16 3:20 ` [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Bjorn Andersson 4 siblings, 0 replies; 8+ messages in thread From: Douglas Anderson @ 2023-03-02 21:11 UTC (permalink / raw) To: Bjorn Andersson Cc: Konrad Dybcio, mka, swboyd, Douglas Anderson, Andy Gross, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, linux-kernel lazor-rev0 was a pile of parts. While I kept the pile of parts for lazor running on my desk for longer than I usually do, those days are still long past. Let's finally delete support for lazor-rev0. Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- (no changes since v1) arch/arm64/boot/dts/qcom/Makefile | 1 - .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 34 ------------------- 2 files changed, 35 deletions(-) delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 3ce51093ed8f..e4190a648335 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -84,7 +84,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r2.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r3.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r4.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r0.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1-kb.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1-lte.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts deleted file mode 100644 index d49de65aa960..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts +++ /dev/null @@ -1,34 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Lazor board device tree source - * - * Copyright 2020 Google LLC. - */ - -/dts-v1/; - -#include "sc7180-trogdor.dtsi" -#include "sc7180-trogdor-ti-sn65dsi86.dtsi" -#include "sc7180-trogdor-lazor.dtsi" - -/ { - model = "Google Lazor (rev0)"; - compatible = "google,lazor-rev0", "qcom,sc7180"; -}; - -&sn65dsi86_out { - /* - * Lane 0 was incorrectly mapped on the cable, but we've now decided - * that the cable is canon and in -rev1+ we'll make a board change - * that means we no longer need the swizzle. - */ - lane-polarities = <1 0>; -}; - -&usb_hub_2_x { - vdd-supply = <&pp3300_l7c>; -}; - -&usb_hub_3_x { - vdd-supply = <&pp3300_l7c>; -}; -- 2.40.0.rc0.216.gc4246ad0f0-goog ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: sc7180: Delete mrbland 2023-03-02 21:11 [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Douglas Anderson ` (2 preceding siblings ...) 2023-03-02 21:11 ` [PATCH v2 3/4] arm64: dts: qcom: sc7180: Delete lazor-rev0 Douglas Anderson @ 2023-03-02 21:11 ` Douglas Anderson 2023-03-16 3:20 ` [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Bjorn Andersson 4 siblings, 0 replies; 8+ messages in thread From: Douglas Anderson @ 2023-03-02 21:11 UTC (permalink / raw) To: Bjorn Andersson Cc: Konrad Dybcio, mka, swboyd, Douglas Anderson, Andy Gross, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, linux-kernel The mrbland board was never actually produced and there has been no activity around the board for quite some time. It seems highly unlikely to magically get revived. There should be nobody in need of these device trees, so let's delete them. If somehow the project resurrects itself then we can re-add support, perhaps just for -rev1+. Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- (no changes since v1) arch/arm64/boot/dts/qcom/Makefile | 4 - .../qcom/sc7180-trogdor-mrbland-rev0-auo.dts | 22 -- .../qcom/sc7180-trogdor-mrbland-rev0-boe.dts | 22 -- .../dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi | 36 -- .../qcom/sc7180-trogdor-mrbland-rev1-auo.dts | 22 -- .../qcom/sc7180-trogdor-mrbland-rev1-boe.dts | 24 -- .../boot/dts/qcom/sc7180-trogdor-mrbland.dtsi | 320 ------------------ 7 files changed, 450 deletions(-) delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dts delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dts delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dts delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dts delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index e4190a648335..a0ad0a8a62d8 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -98,10 +98,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-r9.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots-r4.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots-r5.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots-r9.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-mrbland-rev0-auo.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-mrbland-rev0-boe.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-mrbland-rev1-auo.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-mrbland-rev1-boe.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-lte-parade.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-lte-ti.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-parade.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dts deleted file mode 100644 index 2767817fb053..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dts +++ /dev/null @@ -1,22 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Mrbland board device tree source - * - * Copyright 2021 Google LLC. - * - * SKU: 0x0 => 0 - * - bits 7..4: Panel ID: 0x0 (AUO) - */ - -/dts-v1/; - -#include "sc7180-trogdor-mrbland-rev0.dtsi" - -/ { - model = "Google Mrbland rev0 AUO panel board"; - compatible = "google,mrbland-rev0-sku0", "qcom,sc7180"; -}; - -&panel { - compatible = "auo,b101uan08.3"; -}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dts deleted file mode 100644 index 711485574a03..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dts +++ /dev/null @@ -1,22 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Mrbland board device tree source - * - * Copyright 2021 Google LLC. - * - * SKU: 0x10 => 16 - * - bits 7..4: Panel ID: 0x1 (BOE) - */ - -/dts-v1/; - -#include "sc7180-trogdor-mrbland-rev0.dtsi" - -/ { - model = "Google Mrbland rev0 BOE panel board"; - compatible = "google,mrbland-rev0-sku16", "qcom,sc7180"; -}; - -&panel { - compatible = "boe,tv101wum-n53"; -}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi deleted file mode 100644 index f4c1f3813664..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi +++ /dev/null @@ -1,36 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Mrbland board device tree source - * - * Copyright 2021 Google LLC. - * - */ - -/dts-v1/; - -#include "sc7180-trogdor-mrbland.dtsi" - -&avdd_lcd { - gpio = <&tlmm 80 GPIO_ACTIVE_HIGH>; -}; - -&panel { - enable-gpios = <&tlmm 76 GPIO_ACTIVE_HIGH>; -}; - -&v1p8_mipi { - gpio = <&tlmm 81 GPIO_ACTIVE_HIGH>; -}; - -/* PINCTRL - modifications to sc7180-trogdor-mrbland.dtsi */ -&avdd_lcd_en { - pins = "gpio80"; -}; - -&mipi_1800_en { - pins = "gpio81"; -}; - -&vdd_reset_1800 { - pins = "gpio76"; -}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dts deleted file mode 100644 index 275313ef7554..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dts +++ /dev/null @@ -1,22 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Mrbland board device tree source - * - * Copyright 2021 Google LLC. - * - * SKU: 0x600 => 1536 - * - bits 11..8: Panel ID: 0x6 (AUO) - */ - -/dts-v1/; - -#include "sc7180-trogdor-mrbland.dtsi" - -/ { - model = "Google Mrbland rev1+ AUO panel board"; - compatible = "google,mrbland-sku1536", "qcom,sc7180"; -}; - -&panel { - compatible = "auo,b101uan08.3"; -}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dts deleted file mode 100644 index 87c6b6c30b5e..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dts +++ /dev/null @@ -1,24 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Mrbland board device tree source - * - * Copyright 2021 Google LLC. - * - * SKU: 0x300 => 768 - * - bits 11..8: Panel ID: 0x3 (BOE) - */ - -/dts-v1/; - -#include "sc7180-trogdor-mrbland.dtsi" - -/ { - model = "Google Mrbland (rev1 - 2) BOE panel board"; - /* Uses ID 768 on rev1 and 1024 on rev2+ */ - compatible = "google,mrbland-sku1024", "google,mrbland-sku768", - "qcom,sc7180"; -}; - -&panel { - compatible = "boe,tv101wum-n53"; -}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi deleted file mode 100644 index ed12ee35f06b..000000000000 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi +++ /dev/null @@ -1,320 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) -/* - * Google Mrbland board device tree source - * - * Copyright 2021 Google LLC. - */ - -/dts-v1/; - -#include "sc7180-trogdor.dtsi" - -/* This board only has 1 USB Type-C port. */ -/delete-node/ &usb_c1; - -/ { - avdd_lcd: avdd-lcd-regulator { - compatible = "regulator-fixed"; - regulator-name = "avdd_lcd"; - - gpio = <&tlmm 88 GPIO_ACTIVE_HIGH>; - enable-active-high; - pinctrl-names = "default"; - pinctrl-0 = <&avdd_lcd_en>; - - vin-supply = <&pp5000_a>; - }; - - avee_lcd: avee-lcd-regulator { - compatible = "regulator-fixed"; - regulator-name = "avee_lcd"; - - gpio = <&tlmm 21 GPIO_ACTIVE_HIGH>; - enable-active-high; - pinctrl-names = "default"; - pinctrl-0 = <&avee_lcd_en>; - - vin-supply = <&pp5000_a>; - }; - - v1p8_mipi: v1p8-mipi-regulator { - compatible = "regulator-fixed"; - regulator-name = "v1p8_mipi"; - - gpio = <&tlmm 86 GPIO_ACTIVE_HIGH>; - enable-active-high; - pinctrl-names = "default"; - pinctrl-0 = <&mipi_1800_en>; - - vin-supply = <&pp3300_a>; - }; -}; - -&backlight { - pwms = <&cros_ec_pwm 0>; -}; - -&camcc { - status = "okay"; -}; - -&cros_ec { - keyboard-controller { - compatible = "google,cros-ec-keyb-switches"; - }; -}; - -&dsi0 { - - panel: panel@0 { - /* Compatible will be filled in per-board */ - reg = <0>; - enable-gpios = <&tlmm 87 GPIO_ACTIVE_HIGH>; - pinctrl-names = "default"; - pinctrl-0 = <&vdd_reset_1800>; - avdd-supply = <&avdd_lcd>; - avee-supply = <&avee_lcd>; - pp1800-supply = <&v1p8_mipi>; - pp3300-supply = <&pp3300_dx_edp>; - backlight = <&backlight>; - rotation = <270>; - - ports { - #address-cells = <1>; - #size-cells = <0>; - port@0 { - reg = <0>; - panel_in: endpoint { - remote-endpoint = <&dsi0_out>; - }; - }; - }; - }; - - ports { - port@1 { - endpoint { - remote-endpoint = <&panel_in>; - data-lanes = <0 1 2 3>; - }; - }; - }; -}; - -&gpio_keys { - status = "okay"; -}; - -&i2c4 { - status = "okay"; - clock-frequency = <400000>; - - ap_ts: touchscreen@5d { - compatible = "goodix,gt7375p"; - reg = <0x5d>; - pinctrl-names = "default"; - pinctrl-0 = <&ts_int_l>, <&ts_reset_l>; - - interrupt-parent = <&tlmm>; - interrupts = <9 IRQ_TYPE_LEVEL_LOW>; - - reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>; - - vdd-supply = <&pp3300_ts>; - }; -}; - -&pp1800_uf_cam { - status = "okay"; -}; - -&pp1800_wf_cam { - status = "okay"; -}; - -&pp2800_uf_cam { - status = "okay"; -}; - -&pp2800_wf_cam { - status = "okay"; -}; - -&wifi { - qcom,ath10k-calibration-variant = "GO_MRBLAND"; -}; - -/* - * No eDP on this board but it's logically the same signal so just give it - * a new name and assign the proper GPIO. - */ -pp3300_disp_on: &pp3300_dx_edp { - gpio = <&tlmm 85 GPIO_ACTIVE_HIGH>; -}; - -/* PINCTRL - modifications to sc7180-trogdor.dtsi */ - -/* - * No eDP on this board but it's logically the same signal so just give it - * a new name and assign the proper GPIO. - */ - -tp_en: &en_pp3300_dx_edp { - pins = "gpio85"; -}; - -/* PINCTRL - board-specific pinctrl */ - -&tlmm { - gpio-line-names = "HUB_RST_L", - "AP_RAM_ID0", - "AP_SKU_ID2", - "AP_RAM_ID1", - "", - "AP_RAM_ID2", - "UF_CAM_EN", - "WF_CAM_EN", - "TS_RESET_L", - "TS_INT_L", - "", - "", - "AP_EDP_BKLTEN", - "UF_CAM_MCLK", - "WF_CAM_CLK", - "", - "", - "UF_CAM_SDA", - "UF_CAM_SCL", - "WF_CAM_SDA", - "WF_CAM_SCL", - "AVEE_LCD_EN", - "", - "AMP_EN", - "", - "", - "", - "", - "HP_IRQ", - "WF_CAM_RST_L", - "UF_CAM_RST_L", - "AP_BRD_ID2", - "", - "AP_BRD_ID0", - "AP_H1_SPI_MISO", - "AP_H1_SPI_MOSI", - "AP_H1_SPI_CLK", - "AP_H1_SPI_CS_L", - "BT_UART_CTS", - "BT_UART_RTS", - "BT_UART_TXD", - "BT_UART_RXD", - "H1_AP_INT_ODL", - "", - "UART_AP_TX_DBG_RX", - "UART_DBG_TX_AP_RX", - "HP_I2C_SDA", - "HP_I2C_SCL", - "FORCED_USB_BOOT", - "AMP_BCLK", - "AMP_LRCLK", - "AMP_DIN", - "PEN_DET_ODL", - "HP_BCLK", - "HP_LRCLK", - "HP_DOUT", - "HP_DIN", - "HP_MCLK", - "AP_SKU_ID0", - "AP_EC_SPI_MISO", - "AP_EC_SPI_MOSI", - "AP_EC_SPI_CLK", - "AP_EC_SPI_CS_L", - "AP_SPI_CLK", - "AP_SPI_MOSI", - "AP_SPI_MISO", - /* - * AP_FLASH_WP_L is crossystem ABI. Schematics - * call it BIOS_FLASH_WP_L. - */ - "AP_FLASH_WP_L", - "", - "AP_SPI_CS0_L", - "", - "", - "", - "", - "WLAN_SW_CTRL", - "", - "REPORT_E", - "", - "ID0", - "", - "ID1", - "", - "", - "", - "CODEC_PWR_EN", - "HUB_EN", - "TP_EN", - "MIPI_1.8V_EN", - "VDD_RESET_1.8V", - "AVDD_LCD_EN", - "", - "AP_SKU_ID1", - "AP_RST_REQ", - "", - "AP_BRD_ID1", - "AP_EC_INT_L", - "SDM_GRFC_3", - "", - "", - "BOOT_CONFIG_4", - "BOOT_CONFIG_2", - "", - "", - "", - "", - "", - "", - "", - "BOOT_CONFIG_3", - "WCI2_LTE_COEX_TXD", - "WCI2_LTE_COEX_RXD", - "", - "", - "", - "", - "FORCED_USB_BOOT_POL", - "AP_TS_PEN_I2C_SDA", - "AP_TS_PEN_I2C_SCL", - "DP_HOT_PLUG_DET", - "EC_IN_RW_ODL"; - - avdd_lcd_en: avdd-lcd-en-state { - pins = "gpio88"; - function = "gpio"; - drive-strength = <2>; - bias-disable; - }; - - avee_lcd_en: avee-lcd-en-state { - pins = "gpio21"; - function = "gpio"; - drive-strength = <2>; - bias-disable; - }; - - mipi_1800_en: mipi-1800-en-state { - pins = "gpio86"; - function = "gpio"; - drive-strength = <2>; - bias-disable; - }; - - vdd_reset_1800: vdd-reset-1800-state { - pins = "gpio87"; - function = "gpio"; - drive-strength = <2>; - bias-disable; - }; -}; -- 2.40.0.rc0.216.gc4246ad0f0-goog ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files 2023-03-02 21:11 [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Douglas Anderson ` (3 preceding siblings ...) 2023-03-02 21:11 ` [PATCH v2 4/4] arm64: dts: qcom: sc7180: Delete mrbland Douglas Anderson @ 2023-03-16 3:20 ` Bjorn Andersson 4 siblings, 0 replies; 8+ messages in thread From: Bjorn Andersson @ 2023-03-16 3:20 UTC (permalink / raw) To: Douglas Anderson Cc: linux-kernel, mka, linux-arm-msm, devicetree, Rob Herring, Konrad Dybcio, Andy Gross, Krzysztof Kozlowski, swboyd On Thu, 2 Mar 2023 13:11:03 -0800, Douglas Anderson wrote: > In general on ChromeOS we try hard not to throw away perfectly good > hardware, even if it has a few quirks. Many people keep early versions > of boards around indefinitely and keep using them for testing / > development if the feature they're working on doesn't need the latest > and greatest. This is the reason why there are so many sc7180-trogdor > device tree files. > > [...] Applied, thanks! [1/4] arm64: dts: qcom: sc7180: Delete wormdingler-rev0 commit: 62d882e62fe91ebdf4acbb8444bb3cf78a958aef [2/4] arm64: dts: qcom: sc7180: Delete kingoftown-rev0 commit: 5fe8b1c88d7b3a227d96f277cd0d36a76aff0273 [3/4] arm64: dts: qcom: sc7180: Delete lazor-rev0 commit: c0d1296512102a216f9ce10238a9f79c0ac22ccf [4/4] arm64: dts: qcom: sc7180: Delete mrbland commit: b82c362b4d27f439f9ba753e74e0e7a364263f3a Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-03-16 3:17 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-03-02 21:11 [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Douglas Anderson 2023-03-02 21:11 ` [PATCH v2 1/4] arm64: dts: qcom: sc7180: Delete wormdingler-rev0 Douglas Anderson 2023-03-03 0:47 ` Konrad Dybcio 2023-03-02 21:11 ` [PATCH v2 2/4] arm64: dts: qcom: sc7180: Delete kingoftown-rev0 Douglas Anderson 2023-03-03 0:48 ` Konrad Dybcio 2023-03-02 21:11 ` [PATCH v2 3/4] arm64: dts: qcom: sc7180: Delete lazor-rev0 Douglas Anderson 2023-03-02 21:11 ` [PATCH v2 4/4] arm64: dts: qcom: sc7180: Delete mrbland Douglas Anderson 2023-03-16 3:20 ` [PATCH v2 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).